Files
RedBear-OS/local/recipes/kde/kf6-kio/source/autotests/applicationlauncherjobtest.cpp
T
2026-04-14 10:51:06 +01:00

445 lines
18 KiB
C++

/*
This file is part of the KDE libraries
SPDX-FileCopyrightText: 2014, 2020 David Faure <faure@kde.org>
SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
#include "applicationlauncherjobtest.h"
#include "applicationlauncherjob.h"
#include <kprocessrunner_p.h>
#include "kiotesthelper.h" // createTestFile etc.
#include "mockcoredelegateextensions.h"
#include "mockguidelegateextensions.h"
#include <KConfigGroup>
#include <KDesktopFile>
#include <KJobUiDelegate>
#include <KService>
#include <KSycoca>
#ifdef Q_OS_UNIX
#include <signal.h> // kill
#endif
#include <QRegularExpression>
#include <QStandardPaths>
#include <QTemporaryDir>
#include <QTest>
QTEST_GUILESS_MAIN(ApplicationLauncherJobTest)
void ApplicationLauncherJobTest::initTestCase()
{
QStandardPaths::setTestModeEnabled(true);
KSycoca::setupTestMenu();
m_tempService = createTempService();
}
void ApplicationLauncherJobTest::cleanupTestCase()
{
std::for_each(m_filesToRemove.cbegin(), m_filesToRemove.cend(), [](const QString &f) {
QFile::remove(f);
});
}
static const char s_tempServiceName[] = "applicationlauncherjobtest_service.desktop";
static void createSrcFile(const QString path)
{
QFile srcFile(path);
QVERIFY2(srcFile.open(QFile::WriteOnly), qPrintable(srcFile.errorString()));
srcFile.write("Hello world\n");
}
void ApplicationLauncherJobTest::startProcess_data()
{
QTest::addColumn<bool>("tempFile");
QTest::addColumn<bool>("useExec");
QTest::addColumn<int>("numFiles");
QTest::newRow("1_file_exec") << false << true << 1;
QTest::newRow("1_file_waitForStarted") << false << false << 1;
QTest::newRow("1_tempfile_exec") << true << true << 1;
QTest::newRow("1_tempfile_waitForStarted") << true << false << 1;
QTest::newRow("2_files_exec") << false << true << 2;
QTest::newRow("2_files_waitForStarted") << false << false << 2;
QTest::newRow("2_tempfiles_exec") << true << true << 2;
QTest::newRow("2_tempfiles_waitForStarted") << true << false << 2;
}
void ApplicationLauncherJobTest::startProcess()
{
QSKIP("TODO startProcess doesn't pass FIXME");
QFETCH(bool, tempFile);
QFETCH(bool, useExec);
QFETCH(int, numFiles);
// Given a service desktop file and a number of source files
QTemporaryDir tempDir;
const QString srcDir = tempDir.path();
QList<QUrl> urls;
for (int i = 0; i < numFiles; ++i) {
const QString srcFile = srcDir + "/srcfile" + QString::number(i + 1);
createSrcFile(srcFile);
QVERIFY(QFile::exists(srcFile));
urls.append(QUrl::fromLocalFile(srcFile));
}
// When running a ApplicationLauncherJob
KService::Ptr servicePtr(new KService(m_tempService));
KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(servicePtr, this);
job->setUrls(urls);
if (tempFile) {
job->setRunFlags(KIO::ApplicationLauncherJob::DeleteTemporaryFiles);
}
if (useExec) {
QVERIFY2(job->exec(), qPrintable(job->errorString()));
} else {
job->start();
QVERIFY(job->waitForStarted());
}
const QList<qint64> pids = job->pids();
// Then the service should be executed (which copies the source file to "dest")
QCOMPARE(pids.count(), numFiles);
QVERIFY(!pids.contains(0));
for (int i = 0; i < numFiles; ++i) {
const QString dest = srcDir + "/dest_srcfile" + QString::number(i + 1);
QTRY_VERIFY2(QFile::exists(dest), qPrintable(dest));
QVERIFY(QFile::exists(srcDir + "/srcfile" + QString::number(i + 1))); // if tempfile is true, kioexec will delete it... in 3 minutes.
QVERIFY(QFile::remove(dest)); // cleanup
}
#ifdef Q_OS_UNIX
// Kill the running kioexec processes
for (qint64 pid : pids) {
::kill(pid, SIGTERM);
}
#endif
// The kioexec processes that are waiting for 3 minutes and got killed above,
// will now trigger KProcessRunner::slotProcessError, KProcessRunner::slotProcessExited and delete the KProcessRunner.
// We wait for that to happen otherwise it gets confusing to see that output from later tests.
QTRY_COMPARE(KProcessRunner::instanceCount(), 0);
}
void ApplicationLauncherJobTest::shouldFailOnNonExecutableDesktopFile_data()
{
QTest::addColumn<bool>("withHandler");
QTest::addColumn<bool>("handlerRetVal");
QTest::addColumn<bool>("useExec");
QTest::addColumn<bool>("serviceAction");
QTest::newRow("no_handler_exec") << false << false << true << false;
QTest::newRow("handler_false_exec") << true << false << true << false;
QTest::newRow("handler_true_exec") << true << true << true << false;
QTest::newRow("no_handler_waitForStarted") << false << false << false << false;
QTest::newRow("handler_false_waitForStarted") << true << false << false << false;
QTest::newRow("handler_true_waitForStarted") << true << true << false << false;
// Test the ctor that takes a KServiceAction
QTest::newRow("serviceaction_no_handler_exec") << false << false << true << true;
QTest::newRow("serviceaction_handler_false_exec") << true << false << true << true;
QTest::newRow("serviceaction_handler_true_exec") << true << true << true << true;
QTest::newRow("serviceaction_no_handler_waitForStarted") << false << false << false << true;
QTest::newRow("serviceaction_handler_false_waitForStarted") << true << false << false << true;
QTest::newRow("serviceaction_handler_true_waitForStarted") << true << true << false << true;
}
void ApplicationLauncherJobTest::shouldFailOnNonExecutableDesktopFile()
{
QSKIP("TODO shouldFailOnNonExecutableDesktopFile doesn't pass FIXME");
QFETCH(bool, useExec);
QFETCH(bool, withHandler);
QFETCH(bool, handlerRetVal);
QFETCH(bool, serviceAction);
// Given a .desktop file in a temporary directory (outside the trusted paths)
QTemporaryDir tempDir;
const QString srcDir = tempDir.path();
const QString desktopFilePath = srcDir + "/shouldfail.desktop";
writeTempServiceDesktopFile(desktopFilePath);
m_filesToRemove.append(desktopFilePath);
QTest::ignoreMessage(QtInfoMsg, QRegularExpression("Access to \".*\" denied, not owned by root and executable flag not set."));
const QString srcFile = srcDir + "/srcfile";
createSrcFile(srcFile);
const QList<QUrl> urls{QUrl::fromLocalFile(srcFile)};
KService::Ptr servicePtr(new KService(desktopFilePath));
KIO::ApplicationLauncherJob *job =
!serviceAction ? new KIO::ApplicationLauncherJob(servicePtr, this) : new KIO::ApplicationLauncherJob(servicePtr->actions().at(0), this);
job->setUrls(urls);
job->setUiDelegate(new KJobUiDelegate);
MockUntrustedProgramHandler *handler = withHandler ? new MockUntrustedProgramHandler(job->uiDelegate()) : nullptr;
if (handler) {
handler->setRetVal(handlerRetVal);
}
bool success;
if (useExec) {
success = job->exec();
} else {
job->start();
success = job->waitForStarted();
}
if (!withHandler) {
QVERIFY(!success);
QCOMPARE(job->error(), KJob::UserDefinedError);
QCOMPARE(job->errorString(), QStringLiteral("You are not authorized to execute this file."));
} else {
if (handlerRetVal) {
QVERIFY(success);
// check that the handler was called (before any event loop deletes the job...)
QCOMPARE(handler->m_calls.count(), 1);
QCOMPARE(handler->m_calls.at(0), QStringLiteral("KRunUnittestService"));
const QString dest = srcDir + (!serviceAction ? QLatin1String{"/dest_srcfile"} : QLatin1String{"/actionDest_srcfile"});
QTRY_VERIFY2(QFile::exists(dest), qPrintable(dest));
// The actual shell process will race against the deletion of the QTemporaryDir,
// so don't be surprised by stderr like getcwd: cannot access parent directories: No such file or directory
QTest::qWait(50); // this helps a bit
} else {
QVERIFY(!success);
QCOMPARE(job->error(), KIO::ERR_USER_CANCELED);
}
}
}
void ApplicationLauncherJobTest::shouldFailOnNonExistingExecutable_data()
{
QTest::addColumn<bool>("tempFile");
QTest::addColumn<bool>("fullPath");
QTest::newRow("file") << false << false;
QTest::newRow("tempFile") << true << false;
QTest::newRow("file_fullPath") << false << true;
QTest::newRow("tempFile_fullPath") << true << true;
}
void ApplicationLauncherJobTest::shouldFailOnNonExistingExecutable()
{
QFETCH(bool, tempFile);
QFETCH(bool, fullPath);
const QString desktopFilePath =
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1String("/applications/non_existing_executable.desktop");
KDesktopFile file(desktopFilePath);
KConfigGroup group = file.desktopGroup();
group.writeEntry("Name", "KRunUnittestService");
group.writeEntry("Type", "Service");
if (fullPath) {
group.writeEntry("Exec", "/usr/bin/does_not_exist %f %d/dest_%n");
} else {
group.writeEntry("Exec", "does_not_exist %f %d/dest_%n");
}
file.sync();
KService::Ptr servicePtr(new KService(desktopFilePath));
KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(servicePtr, this);
job->setUrls({QUrl::fromLocalFile(desktopFilePath)}); // just to have one URL as argument, as the desktop file expects
if (tempFile) {
job->setRunFlags(KIO::ApplicationLauncherJob::DeleteTemporaryFiles);
}
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("Could not find the program '.*'")); // from KProcessRunner
QVERIFY(!job->exec());
QCOMPARE(job->error(), KJob::UserDefinedError);
if (fullPath) {
QCOMPARE(job->errorString(), QStringLiteral("Could not find the program '/usr/bin/does_not_exist'"));
} else {
QCOMPARE(job->errorString(), QStringLiteral("Could not find the program 'does_not_exist'"));
}
QFile::remove(desktopFilePath);
}
void ApplicationLauncherJobTest::shouldFailOnInvalidService()
{
const QString desktopFilePath =
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1String("/applications/invalid_service.desktop");
KDesktopFile file(desktopFilePath);
KConfigGroup group = file.desktopGroup();
group.writeEntry("Name", "KRunUnittestService");
group.writeEntry("Type", "NoSuchType");
group.writeEntry("Exec", "does_not_exist");
file.sync();
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("The desktop entry file \".*\" has Type.*\"NoSuchType\" instead of \"Application\" or \"Service\""));
KService::Ptr servicePtr(new KService(desktopFilePath));
KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(servicePtr, this);
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("The desktop entry file.*is not valid")); // from KProcessRunner
QVERIFY(!job->exec());
QCOMPARE(job->error(), KJob::UserDefinedError);
const QString expectedError = QStringLiteral("The desktop entry file\n%1\nis not valid.").arg(desktopFilePath);
QCOMPARE(job->errorString(), expectedError);
QFile::remove(desktopFilePath);
}
void ApplicationLauncherJobTest::shouldFailOnServiceWithNoExec()
{
const QString desktopFilePath =
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1String("/applications/invalid_service.desktop");
KDesktopFile file(desktopFilePath);
KConfigGroup group = file.desktopGroup();
group.writeEntry("Name", "KRunUnittestServiceNoExec");
group.writeEntry("Type", "Service");
file.sync();
QTest::ignoreMessage(QtWarningMsg, qPrintable(QString("No Exec field in \"%1\"").arg(desktopFilePath))); // from KService
KService::Ptr servicePtr(new KService(desktopFilePath));
KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(servicePtr, this);
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("No Exec field in .*")); // from KProcessRunner
QVERIFY(!job->exec());
QCOMPARE(job->error(), KJob::UserDefinedError);
QCOMPARE(job->errorString(), QStringLiteral("No Exec field in %1").arg(desktopFilePath));
QFile::remove(desktopFilePath);
}
void ApplicationLauncherJobTest::shouldFailOnExecutableWithoutPermissions()
{
#ifdef Q_OS_UNIX
// Given an executable shell script that copies "src" to "dest" (we'll cheat with the MIME type to treat it like a native binary)
QTemporaryDir tempDir;
const QString dir = tempDir.path();
const QString scriptFilePath = dir + QStringLiteral("/script.sh");
QFile scriptFile(scriptFilePath);
QVERIFY(scriptFile.open(QIODevice::WriteOnly));
scriptFile.write("#!/bin/sh\ncp src dest");
scriptFile.close();
// Note that it's missing executable permissions
const QString desktopFilePath =
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1String("/applications/invalid_service.desktop");
KDesktopFile file(desktopFilePath);
KConfigGroup group = file.desktopGroup();
group.writeEntry("Name", "KRunUnittestServiceNoPermission");
group.writeEntry("Type", "Service");
group.writeEntry("Exec", scriptFilePath);
file.sync();
KService::Ptr servicePtr(new KService(desktopFilePath));
KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(servicePtr, this);
QTest::ignoreMessage(QtWarningMsg, QRegularExpression("The program .* is missing executable permissions.")); // from KProcessRunner
QVERIFY(!job->exec());
QCOMPARE(job->error(), KJob::UserDefinedError);
QCOMPARE(job->errorString(), QStringLiteral("The program '%1' is missing executable permissions.").arg(scriptFilePath));
QFile::remove(desktopFilePath);
#else
QSKIP("This test is not run on Windows");
#endif
}
void ApplicationLauncherJobTest::showOpenWithDialog_data()
{
QTest::addColumn<bool>("withHandler");
QTest::addColumn<bool>("handlerRetVal");
QTest::addColumn<bool>("nullService");
for (bool nullService : {false, true}) {
const char *nullServiceStr = nullService ? "pass_null_service" : "default_ctor";
QTest::addRow("without_handler_%s", nullServiceStr) << false << false << nullService;
QTest::addRow("false_canceled_%s", nullServiceStr) << true << false << nullService;
QTest::addRow("true_service_selected_%s", nullServiceStr) << true << true << nullService;
}
}
void ApplicationLauncherJobTest::showOpenWithDialog()
{
#ifdef Q_OS_UNIX
QSKIP("TODO showOpenWithDialog doesn't pass FIXME");
QFETCH(bool, withHandler);
QFETCH(bool, handlerRetVal);
QFETCH(bool, nullService);
// Given a local text file (we could test multiple files, too...)
QTemporaryDir tempDir;
const QString srcDir = tempDir.path();
const QString srcFile = srcDir + QLatin1String("/file.txt");
createSrcFile(srcFile);
KIO::ApplicationLauncherJob *job = nullService ? new KIO::ApplicationLauncherJob(KService::Ptr(), this) : new KIO::ApplicationLauncherJob(this);
job->setUrls({QUrl::fromLocalFile(srcFile)});
job->setUiDelegate(new KJobUiDelegate);
MockOpenWithHandler *openWithHandler = withHandler ? new MockOpenWithHandler(job->uiDelegate()) : nullptr;
KService::Ptr service = KService::serviceByDesktopName(QString(s_tempServiceName).remove(".desktop"));
QVERIFY(service);
if (withHandler) {
openWithHandler->m_chosenService = handlerRetVal ? service : KService::Ptr{};
}
const bool success = job->exec();
// Then --- it depends on what the user says via the handler
if (withHandler) {
QCOMPARE(openWithHandler->m_urls.count(), 1);
QCOMPARE(openWithHandler->m_mimeTypes.count(), 1);
QCOMPARE(openWithHandler->m_mimeTypes.at(0), QStringLiteral("text/plain")); // the job doesn't have the information
if (handlerRetVal) {
QVERIFY2(success, qPrintable(job->errorString()));
// If the user chose a service, it should be executed (it writes to "dest")
const QString dest = srcDir + "/dest_file.txt";
QTRY_VERIFY2(QFile::exists(dest), qPrintable(dest));
} else {
QVERIFY(!success);
QCOMPARE(job->error(), KIO::ERR_USER_CANCELED);
}
} else {
QVERIFY(!success);
QCOMPARE(job->error(), KJob::UserDefinedError);
}
#else
QSKIP("Test skipped on Windows because the code ends up in QDesktopServices::openUrl");
#endif
}
void ApplicationLauncherJobTest::writeTempServiceDesktopFile(const QString &filePath)
{
if (QFile::exists(filePath)) {
return;
}
KDesktopFile file(filePath);
KConfigGroup group = file.desktopGroup();
group.writeEntry("Name", "KRunUnittestService");
group.writeEntry("Type", "Service");
#ifdef Q_OS_WIN
group.writeEntry("Exec", "copy.exe %f %d/dest_%n");
#else
group.writeEntry("Exec", "cd %d ; cp %f %d/dest_%n"); // cd is just to show that we can't do QFile::exists(binary)
#endif
// Add a desktop Action
group.writeEntry("Actions", "SubServiceAction");
KConfigGroup actGroup = file.actionGroup(QStringLiteral("SubServiceAction"));
actGroup.writeEntry("Name", "ServiceActionTest");
#ifdef Q_OS_WIN
actGroup.writeEntry("Exec", "copy.exe %f %d/actionDest_%n");
#else
actGroup.writeEntry("Exec", "cd %d ; cp %f %d/actionDest_%n"); // cd is just to show that we can't do QFile::exists(binary)
#endif
file.sync();
}
QString ApplicationLauncherJobTest::createTempService()
{
const QString fileName = s_tempServiceName;
const QString fakeService = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1String("/applications/") + fileName;
writeTempServiceDesktopFile(fakeService);
m_filesToRemove.append(fakeService);
return fakeService;
}
#include "moc_applicationlauncherjobtest.cpp"