Add a couple of FIXME

virtio-core/src/arch/x86_64.rs

@@ -60,6 +60,8 @@ pub fn enable_msix(pcid_handle: &mut PcidServerHandle) -> Result<File, Error> {
     };
 
     // Allocate the primary MSI vector.
+    // FIXME allow the driver to register multiple MSI-X vectors
+    // FIXME move this MSI-X registering code into pcid_interface or pcid itself
     let interrupt_handle = {
         let table_entry_pointer = info.table_entry_pointer(MSIX_PRIMARY_VECTOR as usize);
 

virtio-core/src/probe.rs

@@ -150,6 +150,7 @@ pub fn probe_device(pcid_handle: &mut PcidServerHandle) -> Result<Device, Error>
     if let (Some(common_addr), Some(device_addr), Some((notify_addr, notify_multiplier))) =
         (common_addr, device_addr, notify_addr)
     {
+        // FIXME this is explicitly allowed by the virtio specification to happen
         assert!(
             notify_multiplier != 0,
             "virtio-core::device_probe: device uses the same Queue Notify addresses for all queues"

virtio-core/src/spec/mod.rs

@@ -47,6 +47,8 @@ bitflags::bitflags! {
 mod split_virtqueue;
 pub use split_virtqueue::*;
 
+// FIXME add [2.8 Packed Virtqueues](https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-720008)
+
 mod transport_pci;
 pub use transport_pci::*;