plasma-desktop: include CheckFunctionExists/CheckIncludeFiles
ConfigureChecks.cmake calls check_function_exists() and check_include_files() without including the modules that define them: ConfigureChecks.cmake:14: Unknown CMake command "check_function_exists" Upstream gets away with it because a native KDE configure has already pulled those modules in transitively by that point; that does not happen here. CMake documents both as requiring an explicit include(), so adding them is what upstream should have done rather than a workaround.
This commit is contained in:
@@ -88,6 +88,19 @@ done
|
||||
# Shared with plasma-workspace: the script brace-matches each block and keeps a
|
||||
# trailing `else` outside the guard, since wrapping a whole if/else-if chain
|
||||
# yields invalid C++. Idempotent.
|
||||
# ConfigureChecks.cmake calls check_function_exists() and check_include_files()
|
||||
# without including the modules that define them:
|
||||
# ConfigureChecks.cmake:14: Unknown CMake command "check_function_exists"
|
||||
# Upstream gets away with it because something earlier in a native KDE configure
|
||||
# has already pulled CheckFunctionExists/CheckIncludeFiles in transitively; that
|
||||
# does not happen here. Adding the includes is what upstream should have done --
|
||||
# CMake documents both as requiring an explicit include().
|
||||
# Idempotent: guarded on the text not already being present.
|
||||
if ! grep -q '^include(CheckFunctionExists)' "${COOKBOOK_SOURCE}/ConfigureChecks.cmake"; then
|
||||
sed -i '1i include(CheckFunctionExists)\ninclude(CheckIncludeFiles)' \
|
||||
"${COOKBOOK_SOURCE}/ConfigureChecks.cmake"
|
||||
fi
|
||||
|
||||
# ConfigureChecks.cmake:7 double-prefixes the XKB path when cross-compiling.
|
||||
# It does
|
||||
# pkg_get_variable(XKBDIR xkeyboard-config xkb_base)
|
||||
|
||||
Reference in New Issue
Block a user