minor code cleanups

src/header/stdio/mod.rs

@@ -578,10 +578,9 @@ pub unsafe extern "C" fn fopen(filename: *const c_char, mode: *const c_char) ->
 
     helpers::_fdopen(fd, unsafe { CStr::from_ptr(mode) })
         .map(Box::into_raw)
-        .map_err(|err| {
+        .inspect_err(|err| {
             // TODO: guard type
             if let Ok(()) = Sys::close(fd) {}; // TODO handle error
-            err
         })
         .or_errno_null_mut()
 }

src/header/stdio/printf.rs

@@ -610,9 +610,8 @@ impl<'a, T: c_str::Kind> Iterator for PrintfIter<'a, T> {
         self.format = first_percent.split_first().expect("must be %").1;
 
         let mut peekahead = self.format;
-        let index = pop_index(&mut peekahead).map(|i| {
+        let index = pop_index(&mut peekahead).inspect(|i| {
             self.format = peekahead;
-            i
         });
 
         // Flags:

src/header/wchar/mod.rs

@@ -130,11 +130,11 @@ pub unsafe extern "C" fn fgetws(ws: *mut wchar_t, n: c_int, stream: *mut FILE) -
     }
     // NUL-terminate result
     unsafe { *ws.add(i) = 0 };
-    return if i == 0 || unsafe { ferror(&raw mut *stream) != 0 } {
+    if i == 0 || unsafe { ferror(&raw mut *stream) != 0 } {
         core::ptr::null_mut()
     } else {
         ws
-    };
+    }
 }
 
 /// See <https://pubs.opengroup.org/onlinepubs/9799919799/functions/fputwc.html>.

src/ld_so/linker.rs

@@ -1024,14 +1024,11 @@ impl Linker {
             })?;
 
             if !shm_exists {
-                let _ = Sys::open(shm_path, fcntl::O_CREAT | fcntl::O_RDWR, 0o600)
-                    .map(|fd| Sys::close(fd));
-            } else {
-                if let Ok(shm_fd) = Sys::open(shm_path, fcntl::O_RDWR, 0o600) {
-                    let _ = Sys::ftruncate(shm_fd, source_size as i64);
-                    let _ = Sys::write(shm_fd, file.data());
-                    let _ = Sys::close(shm_fd);
-                }
+                let _ = Sys::open(shm_path, fcntl::O_CREAT | fcntl::O_RDWR, 0o600).map(Sys::close);
+            } else if let Ok(shm_fd) = Sys::open(shm_path, fcntl::O_RDWR, 0o600) {
+                let _ = Sys::ftruncate(shm_fd, source_size as i64);
+                let _ = Sys::write(shm_fd, file.data());
+                let _ = Sys::close(shm_fd);
             }
 
             file