Merge branch 'disable-fail-tests' into 'master'

Disable fail tests, make aarch64 test optional

See merge request redox-os/relibc!1102

.gitlab-ci.yml

@@ -65,6 +65,8 @@ test:aarch64:
     stage: test
     needs: [aarch64]
     image: "redoxos/redoxer:aarch64"
+    # many issues that not exist in x86_64, and lack of interest to fix so far
+    allow_failure: true
     script:
         - timeout -s KILL 9m ./check.sh --arch=aarch64 --test
 

tests/Makefile

@@ -6,19 +6,38 @@ IS_REDOX?=0
 ifeq ($(IS_REDOX),1)
 FAILING_TESTS=
 else
-FAILING_TESTS=tls \
-	futimens \
-	mkfifo \
-	sigchld \
-	stdlib/ptsname \
-	sys_epoll/epollet \
-	sys_mman/fmap \
-	signals/pthread_kill-child \
-	unistd/isatty \
-	unistd/link \
-#	resource/getrusage
-#	time/times
-#   netdb/netdb
+# Wrong modified time
+FAILING_TESTS := futimens
+# Crash, mmap issue
+FAILING_TESTS += malloc/usable_size
+# Not a FIFO
+FAILING_TESTS += mkfifo
+# Waitpid had EINTR
+FAILING_TESTS += sigchld
+# not triggering ERANGE 
+FAILING_TESTS += stdlib/ptsname
+# Hang
+FAILING_TESTS += sys_epoll/epollet
+# Kernel hit todo!
+FAILING_TESTS += sys_mman/fmap
+# Hang
+FAILING_TESTS += sys_socket/unixpeername
+# Task failed successfully?
+FAILING_TESTS += signals/pthread_kill-child
+# Got EBADF
+FAILING_TESTS += unistd/isatty
+# Got EINVAL
+FAILING_TESTS += unistd/link
+# Signal kept unmasked
+FAILING_TESTS += sigqueue
+# Unwrap hit, written as TODO
+FAILING_TESTS += pthread/customstack
+# Returning garbage values
+FAILING_TESTS += sys_resource/getrusage
+# No times.h header
+#FAILING_TESTS += time/times
+# Outdated test
+#FAILING_TESTS += netdb/netdb
 
 endif
 
@@ -55,7 +74,6 @@ EXPECT_NAMES=\
 	locale/duplocale \
 	locale/newlocale \
 	locale/setlocale \
-	malloc/usable_size \
 	math \
 	regex \
 	select \
@@ -128,7 +146,6 @@ EXPECT_NAMES=\
 	strings \
 	sys_socket/recv \
 	sys_socket/recvfrom \
-	sys_socket/unixpeername \
 	sys_socket/unixrecv \
 	sys_socket/unixrecvfrom \
 	sys_socket/unixsocketpair \
@@ -148,6 +165,7 @@ EXPECT_NAMES=\
 	time/time \
 	time/timegm \
 	time/tzset \
+	tls \
 	unistd/access \
 	unistd/brk \
 	unistd/constants \
@@ -297,7 +315,6 @@ VARIED_NAMES=\
 	pthread/exit \
 	pthread/extjoin \
 	pthread/once \
-	pthread/customstack \
 	pthread/barrier \
 	pthread/rwlock_trylock \
 	pthread/rwlock_randtest \
@@ -311,7 +328,6 @@ VARIED_NAMES=\
 	grp/gr_iter \
 	waitpid \
 	waitpid_multiple \
-	sigqueue \
 	$(FAILING_TESTS)
 
 # Tests run with `expect` (require a .c file and an .exp file

tests/fcntl/open.c

@@ -179,6 +179,8 @@ int main(int argc, char* argv[]) {
         goto clean_opened_file;
     }
 
+// TODO: There is no special handling to O_PATH at kernel level
+#ifndef __redox__
     // Writing this buf should fail.
     const char buf[] = "Valencia peanuts";
     if (write(fd, buf, sizeof(buf)) != -1) {
@@ -189,6 +191,7 @@ int main(int argc, char* argv[]) {
         close(fd);
         goto clean_opened_file;
     }
+#endif
 
     // But fstat should succeed with O_PATH
     struct stat stat = {0};

tests/unistd/fchdir.c

@@ -6,7 +6,7 @@
 #include "test_helpers.h"
 
 int main(void) {
-    int fd = open("..", O_DIRECTORY);
+    int fd = open("/usr", O_DIRECTORY);
     ERROR_IF(open, fd, == -1);
     UNEXP_IF(open, fd, < 0);