vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
64 lines
1.8 KiB
Plaintext
64 lines
1.8 KiB
Plaintext
## Check that BOLT handles correctly folding functions with --icf=safe that are only referenced from a .rela.data section.
|
|
|
|
# REQUIRES: system-linux, asserts
|
|
# RUN: llvm-mc -filetype=obj -triple x86_64-unknown-linux %s -o %t1.o
|
|
# RUN: %clang %cflags %t1.o -o %t.exe -Wl,-q -no-pie
|
|
# RUN: llvm-bolt --no-threads %t.exe --icf -debug-only=bolt-icf -o %t.bolt 2>&1 | FileCheck --check-prefix=ICFCHECK %s
|
|
# RUN: llvm-bolt --no-threads %t.exe --icf=safe -debug-only=bolt-icf -o %t.bolt 2>&1 | FileCheck --check-prefix=SAFEICFCHECK %s
|
|
|
|
# ICFCHECK: ICF iteration 1
|
|
# ICFCHECK-NEXT: folding barAddFunc into fooAddFunc
|
|
|
|
# SAFEICFCHECK: skipping function with reference taken fooAddFunc
|
|
# SAFEICFCHECK-NEXT: skipping function with reference taken barAddFunc
|
|
# SAFEICFCHECK-NEXT: ICF iteration 1
|
|
|
|
## clang++ main.cpp
|
|
## Other functions removed for brevity.
|
|
## int main(int argc, char **argv) {
|
|
## const static int (*const funcGlobalBarAdd)(int, int) = barAddHdlper;
|
|
## const int (* const funcGlobalBarMul)(int, int) = fooGlobalFuncHelper;
|
|
## helper2(funcGlobalBarAdd, funcGlobalFooAdd, 3, 4)
|
|
## }
|
|
## Extra assembly removed.
|
|
|
|
.globl fooAddFunc
|
|
.type fooAddFunc,@function
|
|
fooAddFunc:
|
|
addl -8(%rbp), %eax
|
|
retq
|
|
.size fooAddFunc, .-fooAddFunc
|
|
|
|
.globl barAddFunc
|
|
.type barAddFunc,@function
|
|
barAddFunc:
|
|
addl -8(%rbp), %eax
|
|
retq
|
|
.size barAddFunc, .-barAddFunc
|
|
|
|
.globl helperFunc
|
|
.type helperFunc,@function
|
|
helperFunc:
|
|
retq
|
|
.size helperFunc, .-helperFunc
|
|
|
|
.globl main
|
|
.type main,@function
|
|
main:
|
|
movq localStaticVarBarAdd, %rdi
|
|
movq localStaticVarFooAdd, %rsi
|
|
callq helperFunc
|
|
retq
|
|
.size main, .-main
|
|
|
|
.type localStaticVarBarAdd,@object # @localStaticVarBarAdd
|
|
.data
|
|
localStaticVarBarAdd:
|
|
.quad barAddFunc
|
|
.size localStaticVarBarAdd, 8
|
|
|
|
.type localStaticVarFooAdd,@object # @localStaticVarFooAdd
|
|
localStaticVarFooAdd:
|
|
.quad fooAddFunc
|
|
.size localStaticVarFooAdd, 8
|