vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
62 lines
2.3 KiB
Objective-C
62 lines
2.3 KiB
Objective-C
// REQUIRES: asserts
|
|
// RUN: %clang_cc1 -x objective-c -emit-llvm -triple x86_64-apple-macosx10.10.0 -fsanitize=nullability-return,returns-nonnull-attribute,nullability-arg,nonnull-attribute %s -o - -w | FileCheck %s
|
|
|
|
// If both the annotation and the attribute are present, prefer the attribute,
|
|
// since it actually affects IRGen.
|
|
|
|
// CHECK-LABEL: define{{.*}} nonnull ptr @f1
|
|
__attribute__((returns_nonnull)) int *_Nonnull f1(int *_Nonnull p) {
|
|
// CHECK: entry:
|
|
// CHECK-NEXT: [[SLOC_PTR:%.*]] = alloca ptr
|
|
// CHECK-NEXT: [[ADDR:%.*]] = alloca ptr
|
|
// CHECK-NEXT: store ptr null, ptr [[SLOC_PTR]]
|
|
// CHECK-NEXT: store ptr [[P:%.*]], ptr [[ADDR]]
|
|
// CHECK-NEXT: store {{.*}} [[SLOC_PTR]]
|
|
// CHECK-NEXT: [[ARG:%.*]] = load ptr, ptr [[ADDR]]
|
|
// CHECK-NEXT: [[SLOC:%.*]] = load {{.*}} [[SLOC_PTR]]
|
|
// CHECK-NEXT: [[SLOC_NONNULL:%.*]] = icmp ne ptr [[SLOC]], null
|
|
// CHECK-NEXT: br i1 [[SLOC_NONNULL]], label %nullcheck
|
|
//
|
|
// CHECK: nullcheck:
|
|
// CHECK-NEXT: [[ICMP:%.*]] = icmp ne ptr [[ARG]], null, !nosanitize
|
|
// CHECK-NEXT: br i1 [[ICMP]], label %[[CONT:.+]], label %[[HANDLE:[^,]+]]
|
|
// CHECK: [[HANDLE]]:
|
|
// CHECK: call void @__ubsan_handle_nonnull_return
|
|
// CHECK-NEXT: unreachable, !nosanitize
|
|
// CHECK: [[CONT]]:
|
|
// CHECK-NEXT: br label %no.nullcheck
|
|
// CHECK: no.nullcheck:
|
|
// CHECK-NEXT: ret ptr [[ARG]]
|
|
return p;
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @f2
|
|
void f2(int *_Nonnull __attribute__((nonnull)) p) {}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @call_f2
|
|
void call_f2(void) {
|
|
// CHECK: call void @__ubsan_handle_nonnull_arg_abort
|
|
// CHECK-NOT: call void @__ubsan_handle_nonnull_arg_abort
|
|
f2((void *)0);
|
|
}
|
|
|
|
// If the return value isn't meant to be checked, make sure we don't check it.
|
|
// CHECK-LABEL: define{{.*}} ptr @f3
|
|
int *f3(int *p) {
|
|
// CHECK-NOT: return.sloc
|
|
// CHECK-NOT: call{{.*}}ubsan
|
|
return p;
|
|
}
|
|
|
|
// Check for a valid "return" source location, even when there is no return
|
|
// statement, to avoid accidentally calling the runtime.
|
|
|
|
// CHECK-LABEL: define{{.*}} nonnull ptr @f4
|
|
__attribute__((returns_nonnull)) int *f4(void) {
|
|
// CHECK: store ptr null, ptr [[SLOC_PTR:%.*]]
|
|
// CHECK: [[SLOC:%.*]] = load {{.*}} [[SLOC_PTR]]
|
|
// CHECK: [[SLOC_NONNULL:%.*]] = icmp ne ptr [[SLOC]], null
|
|
// CHECK: br i1 [[SLOC_NONNULL]], label %nullcheck
|
|
// CHECK: nullcheck:
|
|
}
|