vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
87 lines
3.3 KiB
C
87 lines
3.3 KiB
C
// RUN: %clang_analyze_cc1 %s -analyzer-checker=core.NullDereference -analyzer-output=text -verify
|
|
// RUN: %clang_analyze_cc1 %s -analyzer-checker=core.NullDereference -analyzer-output=plist -o %t
|
|
// RUN: %normalize_plist <%t | diff -ub %S/Inputs/expected-plists/conditional-path-notes.c.plist -
|
|
|
|
void testCondOp(int *p) {
|
|
int *x = p ? p : p;
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{'?' condition is false}}
|
|
// expected-note@-3 {{'x' initialized to a null pointer value}}
|
|
*x = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'x')}}
|
|
// expected-note@-1 {{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
void testCondProblem(int *p) {
|
|
if (p) return;
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
int x = *p ? 0 : 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-1 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
(void)x;
|
|
}
|
|
|
|
void testLHSProblem(int *p) {
|
|
int x = !p ? *p : 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{'?' condition is true}}
|
|
// expected-note@-3 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
(void)x;
|
|
}
|
|
|
|
void testRHSProblem(int *p) {
|
|
int x = p ? 1 : *p; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{'?' condition is false}}
|
|
// expected-note@-3 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
(void)x;
|
|
}
|
|
|
|
void testBinaryCondOp(int *p) {
|
|
int *x = p ?: p;
|
|
// expected-note@-1 {{'?' condition is false}}
|
|
// expected-note@-2 {{'x' initialized to a null pointer value}}
|
|
*x = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'x')}}
|
|
// expected-note@-1 {{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
void testBinaryLHSProblem(int *p) {
|
|
if (p) return;
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
int x = *p ?: 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-1 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
(void)x;
|
|
}
|
|
|
|
void testDiagnosableBranch(int a) {
|
|
if (a) {
|
|
// expected-note@-1 {{Assuming 'a' is not equal to 0}}
|
|
// expected-note@-2 {{Taking true branch}}
|
|
*(volatile int *)0 = 1; // expected-warning{{Dereference of null pointer}}
|
|
// expected-note@-1 {{Dereference of null pointer}}
|
|
}
|
|
}
|
|
|
|
void testDiagnosableBranchLogical(int a, int b) {
|
|
if (a && b) {
|
|
// expected-note@-1 {{Assuming 'a' is not equal to 0}}
|
|
// expected-note@-2 {{Left side of '&&' is true}}
|
|
// expected-note@-3 {{Assuming 'b' is not equal to 0}}
|
|
// expected-note@-4 {{Taking true branch}}
|
|
*(volatile int *)0 = 1; // expected-warning{{Dereference of null pointer}}
|
|
// expected-note@-1 {{Dereference of null pointer}}
|
|
}
|
|
}
|
|
|
|
void testNonDiagnosableBranchArithmetic(int a, int b) {
|
|
if (a - b) {
|
|
// expected-note@-1 {{Taking true branch}}
|
|
// expected-note@-2 {{Assuming the condition is true}}
|
|
*(volatile int *)0 = 1; // expected-warning{{Dereference of null pointer}}
|
|
// expected-note@-1 {{Dereference of null pointer}}
|
|
}
|
|
}
|
|
|