vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
287 lines
9.4 KiB
C++
287 lines
9.4 KiB
C++
//===- SemaSPIRV.cpp - Semantic Analysis for SPIRV constructs--------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
// This implements Semantic Analysis for SPIRV constructs.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Sema/SemaSPIRV.h"
|
|
#include "clang/Basic/TargetBuiltins.h"
|
|
#include "clang/Basic/TargetInfo.h"
|
|
#include "clang/Sema/Sema.h"
|
|
|
|
// SPIR-V enumerants. Enums have only the required entries, see SPIR-V specs for
|
|
// values.
|
|
// FIXME: either use the SPIRV-Headers or generate a custom header using the
|
|
// grammar (like done with MLIR).
|
|
namespace spirv {
|
|
enum class StorageClass : int {
|
|
Workgroup = 4,
|
|
CrossWorkgroup = 5,
|
|
Function = 7
|
|
};
|
|
}
|
|
|
|
namespace clang {
|
|
|
|
SemaSPIRV::SemaSPIRV(Sema &S) : SemaBase(S) {}
|
|
|
|
static bool CheckAllArgsHaveSameType(Sema *S, CallExpr *TheCall) {
|
|
assert(TheCall->getNumArgs() > 1);
|
|
QualType ArgTy0 = TheCall->getArg(0)->getType();
|
|
|
|
for (unsigned I = 1, N = TheCall->getNumArgs(); I < N; ++I) {
|
|
if (!S->getASTContext().hasSameUnqualifiedType(
|
|
ArgTy0, TheCall->getArg(I)->getType())) {
|
|
S->Diag(TheCall->getBeginLoc(), diag::err_vec_builtin_incompatible_vector)
|
|
<< TheCall->getDirectCallee() << /*useAllTerminology*/ true
|
|
<< SourceRange(TheCall->getArg(0)->getBeginLoc(),
|
|
TheCall->getArg(N - 1)->getEndLoc());
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static std::optional<int>
|
|
processConstant32BitIntArgument(Sema &SemaRef, CallExpr *Call, int Argument) {
|
|
ExprResult Arg =
|
|
SemaRef.DefaultFunctionArrayLvalueConversion(Call->getArg(Argument));
|
|
if (Arg.isInvalid())
|
|
return true;
|
|
Call->setArg(Argument, Arg.get());
|
|
|
|
const Expr *IntArg = Arg.get();
|
|
SmallVector<PartialDiagnosticAt, 8> Notes;
|
|
Expr::EvalResult Eval;
|
|
Eval.Diag = &Notes;
|
|
if ((!IntArg->EvaluateAsConstantExpr(Eval, SemaRef.getASTContext())) ||
|
|
!Eval.Val.isInt() || Eval.Val.getInt().getBitWidth() > 32) {
|
|
SemaRef.Diag(IntArg->getBeginLoc(), diag::err_spirv_enum_not_int)
|
|
<< 0 << IntArg->getSourceRange();
|
|
for (const PartialDiagnosticAt &PDiag : Notes)
|
|
SemaRef.Diag(PDiag.first, PDiag.second);
|
|
return true;
|
|
}
|
|
return {Eval.Val.getInt().getZExtValue()};
|
|
}
|
|
|
|
static bool checkGenericCastToPtr(Sema &SemaRef, CallExpr *Call) {
|
|
if (SemaRef.checkArgCount(Call, 2))
|
|
return true;
|
|
|
|
{
|
|
ExprResult Arg =
|
|
SemaRef.DefaultFunctionArrayLvalueConversion(Call->getArg(0));
|
|
if (Arg.isInvalid())
|
|
return true;
|
|
Call->setArg(0, Arg.get());
|
|
|
|
QualType Ty = Arg.get()->getType();
|
|
const auto *PtrTy = Ty->getAs<PointerType>();
|
|
auto AddressSpaceNotInGeneric = [&](LangAS AS) {
|
|
if (SemaRef.LangOpts.OpenCL)
|
|
return AS != LangAS::opencl_generic;
|
|
return AS != LangAS::Default;
|
|
};
|
|
if (!PtrTy ||
|
|
AddressSpaceNotInGeneric(PtrTy->getPointeeType().getAddressSpace())) {
|
|
SemaRef.Diag(Arg.get()->getBeginLoc(),
|
|
diag::err_spirv_builtin_generic_cast_invalid_arg)
|
|
<< Call->getSourceRange();
|
|
return true;
|
|
}
|
|
}
|
|
|
|
spirv::StorageClass StorageClass;
|
|
if (std::optional<int> SCInt =
|
|
processConstant32BitIntArgument(SemaRef, Call, 1);
|
|
SCInt.has_value()) {
|
|
StorageClass = static_cast<spirv::StorageClass>(SCInt.value());
|
|
if (StorageClass != spirv::StorageClass::CrossWorkgroup &&
|
|
StorageClass != spirv::StorageClass::Workgroup &&
|
|
StorageClass != spirv::StorageClass::Function) {
|
|
SemaRef.Diag(Call->getArg(1)->getBeginLoc(),
|
|
diag::err_spirv_enum_not_valid)
|
|
<< 0 << Call->getArg(1)->getSourceRange();
|
|
return true;
|
|
}
|
|
} else {
|
|
return true;
|
|
}
|
|
auto RT = Call->getArg(0)->getType();
|
|
RT = RT->getPointeeType();
|
|
auto Qual = RT.getQualifiers();
|
|
LangAS AddrSpace;
|
|
switch (StorageClass) {
|
|
case spirv::StorageClass::CrossWorkgroup:
|
|
AddrSpace =
|
|
SemaRef.LangOpts.isSYCL() ? LangAS::sycl_global : LangAS::opencl_global;
|
|
break;
|
|
case spirv::StorageClass::Workgroup:
|
|
AddrSpace =
|
|
SemaRef.LangOpts.isSYCL() ? LangAS::sycl_local : LangAS::opencl_local;
|
|
break;
|
|
case spirv::StorageClass::Function:
|
|
AddrSpace = SemaRef.LangOpts.isSYCL() ? LangAS::sycl_private
|
|
: LangAS::opencl_private;
|
|
break;
|
|
}
|
|
Qual.setAddressSpace(AddrSpace);
|
|
Call->setType(SemaRef.getASTContext().getPointerType(
|
|
SemaRef.getASTContext().getQualifiedType(RT.getUnqualifiedType(), Qual)));
|
|
|
|
return false;
|
|
}
|
|
|
|
bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI,
|
|
unsigned BuiltinID,
|
|
CallExpr *TheCall) {
|
|
if (BuiltinID >= SPIRV::FirstVKBuiltin && BuiltinID <= SPIRV::LastVKBuiltin &&
|
|
TI.getTriple().getArch() != llvm::Triple::spirv) {
|
|
SemaRef.Diag(TheCall->getBeginLoc(), diag::err_spirv_invalid_target) << 0;
|
|
return true;
|
|
}
|
|
if (BuiltinID >= SPIRV::FirstCLBuiltin && BuiltinID <= SPIRV::LastTSBuiltin &&
|
|
TI.getTriple().getArch() != llvm::Triple::spirv32 &&
|
|
TI.getTriple().getArch() != llvm::Triple::spirv64) {
|
|
SemaRef.Diag(TheCall->getBeginLoc(), diag::err_spirv_invalid_target) << 1;
|
|
return true;
|
|
}
|
|
|
|
switch (BuiltinID) {
|
|
case SPIRV::BI__builtin_spirv_distance: {
|
|
if (SemaRef.checkArgCount(TheCall, 2))
|
|
return true;
|
|
|
|
ExprResult A = TheCall->getArg(0);
|
|
QualType ArgTyA = A.get()->getType();
|
|
auto *VTyA = ArgTyA->getAs<VectorType>();
|
|
if (VTyA == nullptr) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(),
|
|
diag::err_typecheck_convert_incompatible)
|
|
<< ArgTyA
|
|
<< SemaRef.Context.getVectorType(ArgTyA, 2, VectorKind::Generic) << 1
|
|
<< 0 << 0;
|
|
return true;
|
|
}
|
|
|
|
ExprResult B = TheCall->getArg(1);
|
|
QualType ArgTyB = B.get()->getType();
|
|
auto *VTyB = ArgTyB->getAs<VectorType>();
|
|
if (VTyB == nullptr) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(),
|
|
diag::err_typecheck_convert_incompatible)
|
|
<< ArgTyB
|
|
<< SemaRef.Context.getVectorType(ArgTyB, 2, VectorKind::Generic) << 1
|
|
<< 0 << 0;
|
|
return true;
|
|
}
|
|
|
|
QualType RetTy = VTyA->getElementType();
|
|
TheCall->setType(RetTy);
|
|
break;
|
|
}
|
|
case SPIRV::BI__builtin_spirv_length: {
|
|
if (SemaRef.checkArgCount(TheCall, 1))
|
|
return true;
|
|
ExprResult A = TheCall->getArg(0);
|
|
QualType ArgTyA = A.get()->getType();
|
|
auto *VTy = ArgTyA->getAs<VectorType>();
|
|
if (VTy == nullptr) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(),
|
|
diag::err_typecheck_convert_incompatible)
|
|
<< ArgTyA
|
|
<< SemaRef.Context.getVectorType(ArgTyA, 2, VectorKind::Generic) << 1
|
|
<< 0 << 0;
|
|
return true;
|
|
}
|
|
QualType RetTy = VTy->getElementType();
|
|
TheCall->setType(RetTy);
|
|
break;
|
|
}
|
|
case SPIRV::BI__builtin_spirv_reflect: {
|
|
if (SemaRef.checkArgCount(TheCall, 2))
|
|
return true;
|
|
|
|
ExprResult A = TheCall->getArg(0);
|
|
QualType ArgTyA = A.get()->getType();
|
|
auto *VTyA = ArgTyA->getAs<VectorType>();
|
|
if (VTyA == nullptr) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(),
|
|
diag::err_typecheck_convert_incompatible)
|
|
<< ArgTyA
|
|
<< SemaRef.Context.getVectorType(ArgTyA, 2, VectorKind::Generic) << 1
|
|
<< 0 << 0;
|
|
return true;
|
|
}
|
|
|
|
ExprResult B = TheCall->getArg(1);
|
|
QualType ArgTyB = B.get()->getType();
|
|
auto *VTyB = ArgTyB->getAs<VectorType>();
|
|
if (VTyB == nullptr) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(),
|
|
diag::err_typecheck_convert_incompatible)
|
|
<< ArgTyB
|
|
<< SemaRef.Context.getVectorType(ArgTyB, 2, VectorKind::Generic) << 1
|
|
<< 0 << 0;
|
|
return true;
|
|
}
|
|
|
|
QualType RetTy = ArgTyA;
|
|
TheCall->setType(RetTy);
|
|
break;
|
|
}
|
|
case SPIRV::BI__builtin_spirv_smoothstep: {
|
|
if (SemaRef.checkArgCount(TheCall, 3))
|
|
return true;
|
|
|
|
// Check if first argument has floating representation
|
|
ExprResult A = TheCall->getArg(0);
|
|
QualType ArgTyA = A.get()->getType();
|
|
if (!ArgTyA->hasFloatingRepresentation()) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(), diag::err_builtin_invalid_arg_type)
|
|
<< /* ordinal */ 1 << /* scalar or vector */ 5 << /* no int */ 0
|
|
<< /* fp */ 1 << ArgTyA;
|
|
return true;
|
|
}
|
|
|
|
if (CheckAllArgsHaveSameType(&SemaRef, TheCall))
|
|
return true;
|
|
|
|
QualType RetTy = ArgTyA;
|
|
TheCall->setType(RetTy);
|
|
break;
|
|
}
|
|
case SPIRV::BI__builtin_spirv_faceforward: {
|
|
if (SemaRef.checkArgCount(TheCall, 3))
|
|
return true;
|
|
|
|
// Check if first argument has floating representation
|
|
ExprResult A = TheCall->getArg(0);
|
|
QualType ArgTyA = A.get()->getType();
|
|
if (!ArgTyA->hasFloatingRepresentation()) {
|
|
SemaRef.Diag(A.get()->getBeginLoc(), diag::err_builtin_invalid_arg_type)
|
|
<< /* ordinal */ 1 << /* scalar or vector */ 5 << /* no int */ 0
|
|
<< /* fp */ 1 << ArgTyA;
|
|
return true;
|
|
}
|
|
|
|
if (CheckAllArgsHaveSameType(&SemaRef, TheCall))
|
|
return true;
|
|
|
|
QualType RetTy = ArgTyA;
|
|
TheCall->setType(RetTy);
|
|
break;
|
|
}
|
|
case SPIRV::BI__builtin_spirv_generic_cast_to_ptr_explicit: {
|
|
return checkGenericCastToPtr(SemaRef, TheCall);
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
} // namespace clang
|