vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
79 lines
2.7 KiB
C++
79 lines
2.7 KiB
C++
//===- bolt/RuntimeLibs/HugifyRuntimeLibrary.cpp - Hugify RT Library ------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements the HugifyRuntimeLibrary class.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "bolt/RuntimeLibs/HugifyRuntimeLibrary.h"
|
|
#include "bolt/Core/BinaryContext.h"
|
|
#include "bolt/Core/Linker.h"
|
|
#include "llvm/MC/MCStreamer.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
|
|
using namespace llvm;
|
|
using namespace bolt;
|
|
|
|
namespace opts {
|
|
|
|
extern cl::OptionCategory BoltOptCategory;
|
|
|
|
extern cl::opt<bool> HotText;
|
|
|
|
cl::opt<bool>
|
|
Hugify("hugify",
|
|
cl::desc("Automatically put hot code on 2MB page(s) (hugify) at "
|
|
"runtime. No manual call to hugify is needed in the binary "
|
|
"(which is what --hot-text relies on)."),
|
|
cl::cat(BoltOptCategory));
|
|
|
|
static cl::opt<std::string>
|
|
RuntimeHugifyLib("runtime-hugify-lib",
|
|
cl::desc("specify path of the runtime hugify library"),
|
|
cl::init("libbolt_rt_hugify.a"), cl::cat(BoltOptCategory));
|
|
|
|
} // namespace opts
|
|
|
|
void HugifyRuntimeLibrary::adjustCommandLineOptions(
|
|
const BinaryContext &BC) const {
|
|
if (opts::HotText) {
|
|
errs()
|
|
<< "BOLT-ERROR: -hot-text should be applied to binaries with "
|
|
"pre-compiled manual hugify support, while -hugify will add hugify "
|
|
"support automatically. These two options cannot both be present.\n";
|
|
exit(1);
|
|
}
|
|
// After the check, we set HotText to be true because automated hugify support
|
|
// relies on it.
|
|
opts::HotText = true;
|
|
if (!BC.StartFunctionAddress) {
|
|
errs() << "BOLT-ERROR: hugify runtime libraries require a known entry "
|
|
"point of "
|
|
"the input binary\n";
|
|
exit(1);
|
|
}
|
|
}
|
|
|
|
void HugifyRuntimeLibrary::link(BinaryContext &BC, StringRef ToolPath,
|
|
BOLTLinker &Linker,
|
|
BOLTLinker::SectionsMapper MapSections) {
|
|
|
|
std::string LibPath = getLibPath(ToolPath, opts::RuntimeHugifyLib);
|
|
loadLibrary(LibPath, Linker, MapSections);
|
|
|
|
assert(!RuntimeStartAddress &&
|
|
"We don't currently support linking multiple runtime libraries");
|
|
auto StartSymInfo = Linker.lookupSymbolInfo("__bolt_hugify_self");
|
|
if (!StartSymInfo) {
|
|
errs() << "BOLT-ERROR: hugify library does not define __bolt_hugify_self: "
|
|
<< LibPath << "\n";
|
|
exit(1);
|
|
}
|
|
RuntimeStartAddress = StartSymInfo->Address;
|
|
}
|