vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
48 lines
1.5 KiB
YAML
48 lines
1.5 KiB
YAML
name: "Check for private emails used in PRs"
|
|
|
|
on:
|
|
pull_request:
|
|
types:
|
|
- opened
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
validate_email:
|
|
runs-on: ubuntu-24.04
|
|
if: github.repository == 'llvm/llvm-project'
|
|
steps:
|
|
- name: Fetch LLVM sources
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
|
|
- name: Extract author email
|
|
id: author
|
|
run: |
|
|
git log -1
|
|
echo "EMAIL=$(git show -s --format='%ae' HEAD~0)" >> $GITHUB_OUTPUT
|
|
# Create empty comment file
|
|
echo "[]" > comments
|
|
|
|
- name: Validate author email
|
|
if: ${{ endsWith(steps.author.outputs.EMAIL, 'noreply.github.com') }}
|
|
env:
|
|
COMMENT: >-
|
|
⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.<br/>
|
|
Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account.<br/>
|
|
See [LLVM Developer Policy](https://llvm.org/docs/DeveloperPolicy.html#email-addresses) and
|
|
[LLVM Discourse](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it) for more information.
|
|
run: |
|
|
cat << EOF > comments
|
|
[{"body" : "$COMMENT"}]
|
|
EOF
|
|
|
|
- uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 #v4.3.0
|
|
if: always()
|
|
with:
|
|
name: workflow-args
|
|
path: |
|
|
comments
|