Files
RedBear-OS/tests/mkfifo.c
T
Anhad Singh cdb4843164 fix(tests): fix UB in mk{fifo,nod,nodat}
Memory chunk is allocated with `malloc` and used as the `dest` buffer
for `strncat`. The `dest` argument in `strncat` has to be NUL terminated,
however it was not.

This commit fixes this issue in mk{fifo,nod,noat}.c.

Almost all dynamic tests pass now.

Signed-off-by: Anhad Singh <andypython@protonmail.com>
2024-11-26 16:56:05 +11:00

47 lines
1.1 KiB
C

#include <fcntl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/statvfs.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <stdio.h>
int main(void) {
char temp[] = "/tmp/stattest-XXXXXX";
const char file[] = "/mkfifo_fifo";
int len = sizeof(temp) + sizeof(file);
char* path = malloc(len * sizeof(char));
path[0] = '\0';
if (path == NULL) {
fprintf(stderr, "Could not allocate: %s\n", strerror(errno));
exit(1);
}
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
path = strncat(path, mktemp(temp), sizeof(temp));
#pragma GCC diagnostic pop
path = strncat(path, file, sizeof(file));
if (mkdir(temp, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH) != 0) {
fprintf(stderr, "mkdir %s: %s\n", temp, strerror(errno));
exit(1);
}
if (mkfifo(path, S_IRUSR) == -1) {
fprintf(stderr, "mkfifo %s: %s\n", path, strerror(errno));
exit(1);
}
struct stat sb;
if (stat(path, &sb) != 0) {
fprintf(stderr, "stat: %s\n", strerror(errno));
exit(1);
}
if (!(sb.st_mode & S_IFIFO)) {
fprintf(stderr, "Not a FIFO: %d\n", sb.st_mode);
exit(1);
}
}