vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
95 lines
4.2 KiB
C++
95 lines
4.2 KiB
C++
// RUN: %clang_cc1 -triple x86_64-unknown-linux -flto -flto-unit -fvirtual-function-elimination -fwhole-program-vtables -emit-llvm -o - %s | FileCheck %s
|
|
// RUN: %clang -target x86_64-unknown-linux -flto -fvirtual-function-elimination -fno-virtual-function-elimination -fwhole-program-vtables -S -emit-llvm -o - %s | FileCheck %s -check-prefix=NOVFE
|
|
|
|
struct __attribute__((visibility("default"))) A {
|
|
virtual void foo();
|
|
};
|
|
|
|
void test_1(A *p) {
|
|
// A has default visibility, so no need for type.checked.load.
|
|
// CHECK-LABEL: define{{.*}} void @_Z6test_1P1A
|
|
// NOVFE-LABEL: define dso_local void @_Z6test_1P1A
|
|
// CHECK: [[FN_PTR_ADDR:%.+]] = getelementptr inbounds ptr, ptr {{%.+}}, i64 0
|
|
// NOVFE: [[FN_PTR_ADDR:%.+]] = getelementptr inbounds ptr, ptr {{%.+}}, i64 0
|
|
// CHECK: [[FN_PTR:%.+]] = load ptr, ptr [[FN_PTR_ADDR]]
|
|
// NOVFE: [[FN_PTR:%.+]] = load ptr, ptr [[FN_PTR_ADDR]]
|
|
// CHECK: call void [[FN_PTR]](
|
|
// NOVFE: call void [[FN_PTR]](
|
|
p->foo();
|
|
}
|
|
|
|
|
|
struct __attribute__((visibility("hidden"))) [[clang::lto_visibility_public]] B {
|
|
virtual void foo();
|
|
};
|
|
|
|
void test_2(B *p) {
|
|
// B has public LTO visibility, so no need for type.checked.load.
|
|
// CHECK-LABEL: define{{.*}} void @_Z6test_2P1B
|
|
// NOVFE-LABEL: define dso_local void @_Z6test_2P1B
|
|
// CHECK: [[FN_PTR_ADDR:%.+]] = getelementptr inbounds ptr, ptr {{%.+}}, i64 0
|
|
// NOVFE: [[FN_PTR_ADDR:%.+]] = getelementptr inbounds ptr, ptr {{%.+}}, i64 0
|
|
// CHECK: [[FN_PTR:%.+]] = load ptr, ptr [[FN_PTR_ADDR]]
|
|
// NOVFE: [[FN_PTR:%.+]] = load ptr, ptr [[FN_PTR_ADDR]]
|
|
// CHECK: call void [[FN_PTR]](
|
|
// NOVFE: call void [[FN_PTR]](
|
|
p->foo();
|
|
}
|
|
|
|
|
|
struct __attribute__((visibility("hidden"))) C {
|
|
virtual void foo();
|
|
virtual void bar();
|
|
};
|
|
|
|
void test_3(C *p) {
|
|
// C has hidden visibility, so we generate type.checked.load to allow VFE.
|
|
// CHECK-LABEL: define{{.*}} void @_Z6test_3P1C
|
|
// NOVFE-LABEL: define dso_local void @_Z6test_3P1C
|
|
// CHECK: [[LOAD:%.+]] = call { ptr, i1 } @llvm.type.checked.load(ptr {{%.+}}, i32 0, metadata !"_ZTS1C")
|
|
// NOVFE: call i1 @llvm.type.test(ptr {{%.+}}, metadata !"_ZTS1C")
|
|
// CHECK: [[FN_PTR:%.+]] = extractvalue { ptr, i1 } [[LOAD]], 0
|
|
// NOVFE: [[FN_PTR:%.+]] = load ptr, ptr {{%.+}}, align 8
|
|
// CHECK: call void [[FN_PTR]](
|
|
// NOVFE: call void [[FN_PTR]](
|
|
p->foo();
|
|
}
|
|
|
|
void test_4(C *p) {
|
|
// When using type.checked.load, we pass the vtable offset to the intrinsic,
|
|
// rather than adding it to the pointer with a GEP.
|
|
// CHECK-LABEL: define{{.*}} void @_Z6test_4P1C
|
|
// NOVFE-LABEL: define dso_local void @_Z6test_4P1C
|
|
// CHECK: [[LOAD:%.+]] = call { ptr, i1 } @llvm.type.checked.load(ptr {{%.+}}, i32 8, metadata !"_ZTS1C")
|
|
// NOVFE: call i1 @llvm.type.test(ptr {{%.+}}, metadata !"_ZTS1C")
|
|
// CHECK: [[FN_PTR:%.+]] = extractvalue { ptr, i1 } [[LOAD]], 0
|
|
// NOVFE: [[FN_PTR:%.+]] = load ptr, ptr {{%.+}}, align 8
|
|
// CHECK: call void [[FN_PTR]](
|
|
// NOVFE: call void [[FN_PTR]](
|
|
p->bar();
|
|
}
|
|
|
|
void test_5(C *p, void (C::*q)(void)) {
|
|
// We also use type.checked.load for the virtual side of member function
|
|
// pointer calls. We use a GEP to calculate the address to load from and pass
|
|
// 0 as the offset to the intrinsic, because we know that the load must be
|
|
// from exactly the point marked by one of the function-type metadatas (in
|
|
// this case "_ZTSM1CFvvE.virtual"). If we passed the offset from the member
|
|
// function pointer to the intrinsic, this information would be lost. No
|
|
// codegen changes on the non-virtual side.
|
|
// CHECK-LABEL: define{{.*}} void @_Z6test_5P1CMS_FvvE(
|
|
// NOVFE-LABEL: define dso_local void @_Z6test_5P1CMS_FvvE(
|
|
// CHECK: [[FN_PTR_ADDR:%.+]] = getelementptr i8, ptr %vtable, i64 {{%.+}}
|
|
// CHECK: [[LOAD:%.+]] = call { ptr, i1 } @llvm.type.checked.load(ptr [[FN_PTR_ADDR]], i32 0, metadata !"_ZTSM1CFvvE.virtual")
|
|
// NOVFE-NOT: call { ptr, i1 } @llvm.type.checked.load(ptr {{%.+}}, i32 0, metadata !"_ZTSM1CFvvE.virtual")
|
|
// NOVFE: call i1 @llvm.type.test(ptr {{%.+}}, metadata !"_ZTSM1CFvvE.virtual")
|
|
// CHECK: [[FN_PTR:%.+]] = extractvalue { ptr, i1 } [[LOAD]], 0
|
|
// NOVFE: [[FN_PTR:%.+]] = load ptr, ptr {{%.+}}, align 8
|
|
|
|
// CHECK: [[PHI:%.+]] = phi ptr [ [[FN_PTR]], {{.*}} ]
|
|
// NOVFE: [[PHI:%.+]] = phi ptr [ [[FN_PTR]], {{.*}} ]
|
|
// CHECK: call void [[PHI]](
|
|
// NOVFE: call void [[PHI]](
|
|
(p->*q)();
|
|
}
|