vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
74 lines
2.3 KiB
C++
74 lines
2.3 KiB
C++
// RUN: %clang_cc1 -fpass-by-value-is-noalias -triple arm64-apple-iphoneos -emit-llvm -disable-llvm-optzns %s -o - 2>&1 | FileCheck --check-prefix=WITH_NOALIAS %s
|
|
// RUN: %clang_cc1 -triple arm64-apple-iphoneos -emit-llvm -disable-llvm-optzns %s -o - 2>&1 | FileCheck --check-prefix=NO_NOALIAS %s
|
|
|
|
// A trivial struct large enough so it is not passed in registers on ARM64.
|
|
struct Foo {
|
|
int a;
|
|
int b;
|
|
int c;
|
|
int d;
|
|
int e;
|
|
int f;
|
|
};
|
|
|
|
// Make sure noalias is added to indirect arguments with trivially copyable types
|
|
// if -fpass-by-value-is-noalias is provided.
|
|
|
|
// WITH_NOALIAS: define{{.*}} void @_Z4take3Foo(ptr noalias noundef %arg)
|
|
// NO_NOALIAS: define{{.*}} void @_Z4take3Foo(ptr noundef %arg)
|
|
void take(Foo arg) {}
|
|
|
|
int G;
|
|
|
|
// NonTrivial is not trivially-copyable, because it has a non-trivial copy
|
|
// constructor.
|
|
struct NonTrivial {
|
|
int a;
|
|
int b;
|
|
int c;
|
|
int d;
|
|
int e;
|
|
int f;
|
|
|
|
NonTrivial(const NonTrivial &Other) {
|
|
a = G + 10 + Other.a;
|
|
}
|
|
};
|
|
|
|
// Make sure noalias is not added to indirect arguments that are not trivially
|
|
// copyable even if -fpass-by-value-is-noalias is provided.
|
|
|
|
// WITH_NOALIAS: define{{.*}} void @_Z4take10NonTrivial(ptr noundef %arg)
|
|
// NO_NOALIAS: define{{.*}} void @_Z4take10NonTrivial(ptr noundef %arg)
|
|
void take(NonTrivial arg) {}
|
|
|
|
// Escape examples. Pointers to the objects passed to take() may escape, depending on whether a temporary copy is created or not (e.g. due to NRVO).
|
|
struct A {
|
|
A(A **where) : data{"hello world 1"} {
|
|
*where = this; //Escaped pointer 1 (proposed UB?)
|
|
}
|
|
|
|
A() : data{"hello world 2"} {}
|
|
|
|
char data[32];
|
|
};
|
|
A *p;
|
|
|
|
// WITH_NOALIAS: define{{.*}} void @_Z4take1A(ptr noalias noundef %arg)
|
|
// NO_NOALIAS: define{{.*}} void @_Z4take1A(ptr noundef %arg)
|
|
void take(A arg) {}
|
|
|
|
// WITH_NOALIAS: define{{.*}} void @_Z7CreateAPP1A(ptr dead_on_unwind noalias writable sret(%struct.A) align 1 %agg.result, ptr noundef %where)
|
|
// NO_NOALIAS: define{{.*}} void @_Z7CreateAPP1A(ptr dead_on_unwind noalias writable sret(%struct.A) align 1 %agg.result, ptr noundef %where)
|
|
A CreateA(A **where) {
|
|
A justlikethis;
|
|
*where = &justlikethis; //Escaped pointer 2 (should also be UB, then)
|
|
return justlikethis;
|
|
}
|
|
|
|
// elsewhere, perhaps compiled by a smarter compiler that doesn't make a copy here
|
|
void test() {
|
|
take({&p}); // 1
|
|
take(CreateA(&p)); // 2
|
|
}
|