vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
63 lines
1.3 KiB
C++
63 lines
1.3 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.API -verify %s
|
|
extern "C" {
|
|
#ifndef O_RDONLY
|
|
#define O_RDONLY 0
|
|
#endif
|
|
|
|
#ifndef NULL
|
|
#define NULL ((void*) 0)
|
|
#endif
|
|
|
|
int open(const char *, int, ...);
|
|
int close(int fildes);
|
|
|
|
} // extern "C"
|
|
|
|
namespace MyNameSpace {
|
|
int open(const char *a, int b, int c, int d);
|
|
}
|
|
|
|
void unix_open(const char *path) {
|
|
int fd;
|
|
fd = open(path, O_RDONLY); // no-warning
|
|
if (fd > -1)
|
|
close(fd);
|
|
}
|
|
|
|
void unix_open_misuse(const char *path) {
|
|
int fd;
|
|
int mode = 0x0;
|
|
fd = open(path, O_RDONLY, mode, NULL); // expected-warning{{Call to 'open' with more than 3 arguments}}
|
|
if (fd > -1)
|
|
close(fd);
|
|
}
|
|
|
|
// Don't treat open() in namespaces as the POSIX open()
|
|
void namespaced_open(const char *path) {
|
|
MyNameSpace::open("Hi", 2, 3, 4); // no-warning
|
|
|
|
using namespace MyNameSpace;
|
|
|
|
open("Hi", 2, 3, 4); // no-warning
|
|
|
|
int fd;
|
|
int mode = 0x0;
|
|
fd = ::open(path, O_RDONLY, mode, NULL); // expected-warning{{Call to 'open' with more than 3 arguments}}
|
|
if (fd > -1)
|
|
close(fd);
|
|
}
|
|
|
|
class MyClass {
|
|
public:
|
|
static int open(const char *a, int b, int c, int d);
|
|
|
|
int open(int a, int, int c, int d);
|
|
};
|
|
|
|
void class_qualified_open() {
|
|
MyClass::open("Hi", 2, 3, 4); // no-warning
|
|
|
|
MyClass mc;
|
|
mc.open(1, 2, 3, 4); // no-warning
|
|
}
|