vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
63 lines
2.1 KiB
C++
63 lines
2.1 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix,alpha.unix.cstring,debug.ExprInspection -verify %s
|
|
|
|
// Test functions that are called "memcpy" but aren't the memcpy
|
|
// we're looking for. Unfortunately, this test cannot be put into
|
|
// a namespace. The out-of-class weird memcpy needs to be recognized
|
|
// as a normal C function for the test to make sense.
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
void *memcpy(void *, const void *, size_t);
|
|
size_t strlen(const char *s);
|
|
|
|
int sprintf(char *str, const char *format, ...);
|
|
int snprintf(char *str, size_t size, const char *format, ...);
|
|
|
|
void clang_analyzer_warnIfReached();
|
|
|
|
struct S {
|
|
static S s1, s2;
|
|
|
|
// A weird overload within the class that accepts a structure reference
|
|
// instead of a pointer.
|
|
void memcpy(void *, const S &, size_t);
|
|
void test_in_class_weird_memcpy() {
|
|
memcpy(this, s2, 1); // no-crash
|
|
}
|
|
};
|
|
|
|
// A similarly weird overload outside of the class.
|
|
void *memcpy(void *, const S &, size_t);
|
|
|
|
void test_out_of_class_weird_memcpy() {
|
|
memcpy(&S::s1, S::s2, 1); // no-crash
|
|
}
|
|
|
|
template<typename... Args>
|
|
void log(const char* fmt, const Args&... args) {
|
|
char buf[100] = {};
|
|
auto f = snprintf;
|
|
auto g = sprintf;
|
|
int n = 0;
|
|
n += f(buf, 99, fmt, args...); // no-crash: The CalleeDecl is a VarDecl, but it's okay.
|
|
n += g(buf, fmt, args...); // no-crash: Same.
|
|
(void)n;
|
|
clang_analyzer_warnIfReached(); // expected-warning {{REACHABLE}}
|
|
}
|
|
|
|
void test_gh_74269_no_crash() {
|
|
log("%d", 1);
|
|
}
|
|
|
|
struct TestNotNullTerm {
|
|
void test1() {
|
|
TestNotNullTerm * const &x = this;
|
|
strlen((char *)&x); // expected-warning{{Argument to string length function is not a null-terminated string}}
|
|
}
|
|
};
|
|
|
|
void test_notcstring_tempobject() {
|
|
// FIXME: This warning from cstring.NotNullTerminated is a false positive.
|
|
// Handling of similar cases is not perfect in other cstring checkers.
|
|
// The fix would be a larger change in CStringChecker and affect multiple checkers.
|
|
strlen((char[]){'a', 0}); // expected-warning{{Argument to string length function is a C++ temp object of type char[2], which is not a null-terminated string}}
|
|
}
|