cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
71 lines
2.3 KiB
Objective-C
71 lines
2.3 KiB
Objective-C
// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -fblocks -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=plist-multi-file -fblocks -Wno-objc-root-class %s -o %t
|
|
// RUN: %normalize_plist <%t | diff -ub %S/Inputs/expected-plists/null-deref-path-notes.m.plist -
|
|
|
|
@interface Root {
|
|
@public
|
|
int uniqueID;
|
|
}
|
|
- (id)initWithID:(int)newID;
|
|
- (void)refreshID;
|
|
@end
|
|
|
|
int testNull(Root *obj) {
|
|
if (obj) return 0;
|
|
// expected-note@-1 {{Assuming 'obj' is nil}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
int *x = &obj->uniqueID; // expected-note{{'x' initialized to a null pointer value}}
|
|
return *x; // expected-warning{{Dereference of null pointer (loaded from variable 'x')}} expected-note{{Dereference of null pointer (loaded from variable 'x')}}
|
|
}
|
|
|
|
|
|
@interface Subclass : Root
|
|
@end
|
|
|
|
@implementation Subclass
|
|
- (id)initWithID:(int)newID {
|
|
self = [super initWithID:newID]; // expected-note{{Value assigned to 'self'}}
|
|
if (self) return self;
|
|
// expected-note@-1 {{Assuming 'self' is nil}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
uniqueID = newID; // expected-warning{{Access to instance variable 'uniqueID' results in a dereference of a null pointer (loaded from variable 'self')}} expected-note{{Access to instance variable 'uniqueID' results in a dereference of a null pointer (loaded from variable 'self')}}
|
|
return self;
|
|
}
|
|
|
|
@end
|
|
|
|
void repeatedStores(int coin) {
|
|
int *p = 0;
|
|
if (coin) {
|
|
// expected-note@-1 {{Assuming 'coin' is 0}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
extern int *getPointer(void);
|
|
p = getPointer();
|
|
} else {
|
|
p = 0; // expected-note {{Null pointer value stored to 'p'}}
|
|
}
|
|
|
|
*p = 1; // expected-warning{{Dereference of null pointer}} expected-note{{Dereference of null pointer}}
|
|
}
|
|
|
|
@interface WithArrayPtr
|
|
- (void) useArray;
|
|
@end
|
|
|
|
@implementation WithArrayPtr {
|
|
@public int *p;
|
|
}
|
|
- (void)useArray {
|
|
p[1] = 2; // expected-warning{{Array access (via ivar 'p') results in a null pointer dereference}}
|
|
// expected-note@-1{{Array access (via ivar 'p') results in a null pointer dereference}}
|
|
}
|
|
@end
|
|
|
|
void testWithArrayPtr(WithArrayPtr *w) {
|
|
w->p = 0; // expected-note{{Null pointer value stored to 'p'}}
|
|
[w useArray]; // expected-note{{Calling 'useArray'}}
|
|
}
|
|
|