vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
167 lines
6.0 KiB
C
167 lines
6.0 KiB
C
// -fstrict-flex-arrays=2 means that only undefined or zero element arrays are considered as FAMs.
|
|
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c90 \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c99 \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c11 \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c17 \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++98 -x c++ \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++03 -x c++ \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++11 -x c++ \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++14 -x c++ \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++17 -x c++ \
|
|
// RUN: -fstrict-flex-arrays=2
|
|
|
|
// By default, -fstrict-flex-arrays=0, which means that even single element arrays are considered as FAMs.
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c17 \
|
|
// RUN: -DSINGLE_ELEMENT_FAMS
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-linux-gnu -analyzer-checker=core,unix,debug.ExprInspection %s -verify -std=c++17 -x c++ \
|
|
// RUN: -DSINGLE_ELEMENT_FAMS
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
size_t clang_analyzer_getExtent(void *);
|
|
void clang_analyzer_dump(size_t);
|
|
|
|
void *alloca(size_t size);
|
|
void *malloc(size_t size);
|
|
void free(void *ptr);
|
|
|
|
void test_incomplete_array_fam(void) {
|
|
typedef struct FAM {
|
|
char c;
|
|
int data[];
|
|
} FAM;
|
|
|
|
FAM fam;
|
|
clang_analyzer_dump(clang_analyzer_getExtent(&fam));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(fam.data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
|
|
FAM *p = (FAM *)alloca(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p->data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
|
|
FAM *q = (FAM *)malloc(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q->data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
free(q);
|
|
|
|
q = (FAM *)malloc(sizeof(FAM) + sizeof(int) * 2);
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q->data));
|
|
// expected-warning@-2 {{12 S64b}}
|
|
// expected-warning@-2 {{8 S64b}}
|
|
free(q);
|
|
|
|
typedef struct __attribute__((packed)) {
|
|
char c;
|
|
int data[];
|
|
} PackedFAM;
|
|
|
|
PackedFAM *t = (PackedFAM *)malloc(sizeof(PackedFAM) + sizeof(int) * 2);
|
|
clang_analyzer_dump(clang_analyzer_getExtent(t));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(t->data));
|
|
// expected-warning@-2 {{9 S64b}}
|
|
// expected-warning@-2 {{8 S64b}}
|
|
free(t);
|
|
}
|
|
|
|
void test_too_small_base(void) {
|
|
typedef struct FAM {
|
|
long c;
|
|
int data[];
|
|
} FAM;
|
|
short s = 0;
|
|
FAM *p = (FAM *) &s;
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p->data));
|
|
// expected-warning@-2 {{2 S64b}}
|
|
// expected-warning@-2 {{-6 S64b}}
|
|
}
|
|
|
|
void test_zero_length_array_fam(void) {
|
|
typedef struct FAM {
|
|
char c;
|
|
int data[0];
|
|
} FAM;
|
|
|
|
FAM fam;
|
|
clang_analyzer_dump(clang_analyzer_getExtent(&fam));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(fam.data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
|
|
FAM *p = (FAM *)alloca(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p->data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
|
|
FAM *q = (FAM *)malloc(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q->data));
|
|
// expected-warning@-2 {{4 S64b}}
|
|
// expected-warning@-2 {{0 S64b}}
|
|
free(q);
|
|
}
|
|
|
|
void test_single_element_array_possible_fam(void) {
|
|
typedef struct FAM {
|
|
char c;
|
|
int data[1];
|
|
} FAM;
|
|
|
|
#ifdef SINGLE_ELEMENT_FAMS
|
|
FAM likely_fam;
|
|
clang_analyzer_dump(clang_analyzer_getExtent(&likely_fam));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(likely_fam.data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
|
|
FAM *p = (FAM *)alloca(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p->data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
|
|
FAM *q = (FAM *)malloc(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q->data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
free(q);
|
|
#else
|
|
FAM likely_fam;
|
|
clang_analyzer_dump(clang_analyzer_getExtent(&likely_fam));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(likely_fam.data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
|
|
FAM *p = (FAM *)alloca(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(p->data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
|
|
FAM *q = (FAM *)malloc(sizeof(FAM));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q));
|
|
clang_analyzer_dump(clang_analyzer_getExtent(q->data));
|
|
// expected-warning@-2 {{8 S64b}}
|
|
// expected-warning@-2 {{4 S64b}}
|
|
free(q);
|
|
#endif
|
|
}
|