vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
50 lines
1.6 KiB
C
50 lines
1.6 KiB
C
// RUN: %clang_analyze_cc1 -verify -analyzer-output text %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-checker=unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=apiModeling.Errno \
|
|
// RUN: -analyzer-checker=unix.Errno \
|
|
// RUN: -analyzer-config unix.StdCLibraryFunctions:ModelPOSIX=true
|
|
|
|
#include "Inputs/errno_var.h"
|
|
|
|
int access(const char *path, int amode);
|
|
|
|
void clang_analyzer_warnIfReached();
|
|
|
|
void test1() {
|
|
access("path", 0);
|
|
access("path", 0);
|
|
// expected-note@-1{{Assuming that 'access' is successful; 'errno' becomes undefined after the call}}
|
|
if (errno != 0) {
|
|
// expected-warning@-1{{An undefined value may be read from 'errno'}}
|
|
// expected-note@-2{{An undefined value may be read from 'errno'}}
|
|
}
|
|
}
|
|
|
|
void test2() {
|
|
if (access("path", 0) == -1) {
|
|
// expected-note@-1{{Taking true branch}}
|
|
// Failure path.
|
|
if (errno != 0) {
|
|
// expected-note@-1{{'errno' is not equal to 0}}
|
|
// expected-note@-2{{Taking true branch}}
|
|
clang_analyzer_warnIfReached(); // expected-note {{REACHABLE}} expected-warning {{REACHABLE}}
|
|
} else {
|
|
clang_analyzer_warnIfReached(); // no-warning: We are on the failure path.
|
|
}
|
|
}
|
|
}
|
|
|
|
void test3() {
|
|
if (access("path", 0) != -1) {
|
|
// Success path.
|
|
// expected-note@-2{{Assuming that 'access' is successful; 'errno' becomes undefined after the call}}
|
|
// expected-note@-3{{Taking true branch}}
|
|
if (errno != 0) {
|
|
// expected-warning@-1{{An undefined value may be read from 'errno'}}
|
|
// expected-note@-2{{An undefined value may be read from 'errno'}}
|
|
}
|
|
}
|
|
}
|