vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
69 lines
2.0 KiB
C
69 lines
2.0 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=unix.Chroot -analyzer-output=text -verify %s
|
|
|
|
extern int chroot(const char* path);
|
|
extern int chdir(const char* path);
|
|
|
|
void foo(void) {
|
|
}
|
|
|
|
void f1(void) {
|
|
chroot("/usr/local"); // expected-note {{chroot called here}}
|
|
foo();
|
|
// expected-warning@-1 {{No call of chdir("/") immediately after chroot}}
|
|
// expected-note@-2 {{No call of chdir("/") immediately after chroot}}
|
|
}
|
|
|
|
void f2(void) {
|
|
chroot("/usr/local"); // root changed.
|
|
chdir("/"); // enter the jail.
|
|
foo(); // no-warning
|
|
}
|
|
|
|
void f3(void) {
|
|
chroot("/usr/local"); // expected-note {{chroot called here}}
|
|
chdir("../"); // change working directory, still out of jail.
|
|
foo();
|
|
// expected-warning@-1 {{No call of chdir("/") immediately after chroot}}
|
|
// expected-note@-2 {{No call of chdir("/") immediately after chroot}}
|
|
}
|
|
|
|
void f4(void) {
|
|
if (chroot("/usr/local") == 0) {
|
|
chdir("../"); // change working directory, still out of jail.
|
|
}
|
|
}
|
|
|
|
void f5(void) {
|
|
int v = chroot("/usr/local");
|
|
if (v == -1) {
|
|
foo(); // no warning, chroot failed
|
|
chdir("../"); // change working directory, still out of jail.
|
|
}
|
|
}
|
|
|
|
void f6(void) {
|
|
if (chroot("/usr/local") == -1) {
|
|
chdir("../"); // change working directory, still out of jail.
|
|
}
|
|
}
|
|
|
|
void f7(void) {
|
|
int v = chroot("/usr/local"); // expected-note {{chroot called here}}
|
|
if (v == -1) { // expected-note {{Taking false branch}}
|
|
foo(); // no warning, chroot failed
|
|
chdir("../"); // change working directory, still out of jail.
|
|
} else {
|
|
foo();
|
|
// expected-warning@-1 {{No call of chdir("/") immediately after chroot}}
|
|
// expected-note@-2 {{No call of chdir("/") immediately after chroot}}
|
|
}
|
|
}
|
|
|
|
void f8() {
|
|
chroot("/usr/local"); // expected-note {{chroot called here}}
|
|
chdir("/usr"); // This chdir was ineffective because it's not exactly `chdir("/")`.
|
|
foo();
|
|
// expected-warning@-1 {{No call of chdir("/") immediately after chroot}}
|
|
// expected-note@-2 {{No call of chdir("/") immediately after chroot}}
|
|
}
|