vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
99 lines
2.8 KiB
C
99 lines
2.8 KiB
C
// RUN: %clang_analyze_cc1 -verify %s \
|
|
// RUN: -analyzer-checker=alpha.unix.cstring.BufferOverlap
|
|
//
|
|
// RUN: %clang_analyze_cc1 -verify %s -DUSE_BUILTINS \
|
|
// RUN: -analyzer-checker=alpha.unix.cstring.BufferOverlap
|
|
//
|
|
// RUN: %clang_analyze_cc1 -verify %s -DVARIANT \
|
|
// RUN: -analyzer-checker=alpha.unix.cstring.BufferOverlap
|
|
//
|
|
// RUN: %clang_analyze_cc1 -verify %s -DVARIANT -DUSE_BUILTINS \
|
|
// RUN: -analyzer-checker=alpha.unix.cstring.BufferOverlap
|
|
|
|
// This provides us with four possible sprintf() definitions.
|
|
|
|
#ifdef USE_BUILTINS
|
|
#define BUILTIN(f) __builtin_##f
|
|
#else /* USE_BUILTINS */
|
|
#define BUILTIN(f) f
|
|
#endif /* USE_BUILTINS */
|
|
|
|
typedef typeof(sizeof(int)) size_t;
|
|
|
|
#ifdef VARIANT
|
|
|
|
#define __sprintf_chk BUILTIN(__sprintf_chk)
|
|
#define __snprintf_chk BUILTIN(__snprintf_chk)
|
|
int __sprintf_chk (char * __restrict str, int flag, size_t os,
|
|
const char * __restrict fmt, ...);
|
|
int __snprintf_chk (char * __restrict str, size_t len, int flag, size_t os,
|
|
const char * __restrict fmt, ...);
|
|
|
|
#define sprintf(str, ...) __sprintf_chk(str, 0, __builtin_object_size(str, 0), __VA_ARGS__)
|
|
#define snprintf(str, len, ...) __snprintf_chk(str, len, 0, __builtin_object_size(str, 0), __VA_ARGS__)
|
|
|
|
#else /* VARIANT */
|
|
|
|
#define sprintf BUILTIN(sprintf)
|
|
int sprintf(char *restrict buffer, const char *restrict format, ... );
|
|
int snprintf(char *restrict buffer, size_t bufsz,
|
|
const char *restrict format, ... );
|
|
#endif /* VARIANT */
|
|
|
|
void test_sprintf1() {
|
|
char a[4] = {0};
|
|
sprintf(a, "%d/%s", 1, a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_sprintf2() {
|
|
char a[4] = {0};
|
|
sprintf(a, "%s", a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_sprintf3() {
|
|
char a[4] = {0};
|
|
sprintf(a, "%s/%s", a, a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_sprintf4() {
|
|
char a[4] = {0};
|
|
sprintf(a, "%d", 42); // no-warning
|
|
}
|
|
|
|
void test_sprintf5() {
|
|
char a[4] = {0};
|
|
char b[4] = {0};
|
|
sprintf(a, "%s", b); // no-warning
|
|
}
|
|
|
|
void test_snprintf1() {
|
|
char a[4] = {0};
|
|
snprintf(a, sizeof(a), "%d/%s", 1, a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_snprintf2() {
|
|
char a[4] = {0};
|
|
snprintf(a+1, sizeof(a)-1, "%d/%s", 1, a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_snprintf3() {
|
|
char a[4] = {0};
|
|
snprintf(a, sizeof(a), "%s", a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_snprintf4() {
|
|
char a[4] = {0};
|
|
snprintf(a, sizeof(a), "%s/%s", a, a); // expected-warning{{Arguments must not be overlapping buffers}}
|
|
}
|
|
|
|
void test_snprintf5() {
|
|
char a[4] = {0};
|
|
snprintf(a, sizeof(a), "%d", 42); // no-warning
|
|
}
|
|
|
|
void test_snprintf6() {
|
|
char a[4] = {0};
|
|
char b[4] = {0};
|
|
snprintf(a, sizeof(a), "%s", b); // no-warning
|
|
}
|