vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
43 lines
1.0 KiB
C++
43 lines
1.0 KiB
C++
|
|
// RUN: %clang_analyze_cc1 \
|
|
// RUN: -analyzer-checker=unix.BlockInCriticalSection \
|
|
// RUN: -std=c++11 \
|
|
// RUN: -analyzer-output text \
|
|
// RUN: -verify %s
|
|
|
|
unsigned int sleep(unsigned int seconds) {return 0;}
|
|
namespace std {
|
|
namespace __detail {
|
|
class __mutex_base {
|
|
public:
|
|
void lock();
|
|
};
|
|
} // namespace __detail
|
|
|
|
class mutex : public __detail::__mutex_base{
|
|
public:
|
|
void unlock();
|
|
bool try_lock();
|
|
};
|
|
} // namespace std
|
|
|
|
void gh_99628() {
|
|
std::mutex m;
|
|
m.lock();
|
|
// expected-note@-1 {{Entering critical section here}}
|
|
sleep(10);
|
|
// expected-warning@-1 {{Call to blocking function 'sleep' inside of critical section}}
|
|
// expected-note@-2 {{Call to blocking function 'sleep' inside of critical section}}
|
|
m.unlock();
|
|
}
|
|
|
|
void no_false_positive_gh_104241() {
|
|
std::mutex m;
|
|
m.lock();
|
|
// If inheritance not handled properly, this unlock might not match the lock
|
|
// above because technically they act on different memory regions:
|
|
// __mutex_base and mutex.
|
|
m.unlock();
|
|
sleep(10); // no-warning
|
|
}
|