vasilito
cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
138 lines
2.8 KiB
C
138 lines
2.8 KiB
C
// RUN: %clang_analyze_cc1 -triple x86_64-unknown-linux %s -verify \
|
|
// RUN: -Wno-incompatible-library-redeclaration \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix.Malloc
|
|
|
|
#define __GFP_ZERO 0x8000
|
|
#define NULL ((void *)0)
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
|
|
void *kmalloc(size_t, int);
|
|
void kfree(void *);
|
|
|
|
struct test {
|
|
};
|
|
|
|
void foo(struct test *);
|
|
|
|
void test_zeroed(void) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = kmalloc(sizeof(*list) * 10, __GFP_ZERO);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i];
|
|
foo(t);
|
|
}
|
|
kfree(list); // no-warning
|
|
}
|
|
|
|
void test_nonzero(void) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = kmalloc(sizeof(*list) * 10, 0);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i]; // expected-warning{{uninitialized}}
|
|
foo(t);
|
|
}
|
|
kfree(list);
|
|
}
|
|
|
|
void test_indeterminate(int flags) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = kmalloc(sizeof(*list) * 10, flags);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i]; // expected-warning{{uninitialized}}
|
|
foo(t);
|
|
}
|
|
kfree(list);
|
|
}
|
|
|
|
typedef unsigned long long uint64_t;
|
|
|
|
struct malloc_type;
|
|
|
|
// 3 parameter malloc:
|
|
// https://www.freebsd.org/cgi/man.cgi?query=malloc&sektion=9
|
|
void *malloc(unsigned long size, struct malloc_type *mtp, int flags);
|
|
|
|
void test_3arg_malloc(struct malloc_type *mtp) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, __GFP_ZERO);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i];
|
|
foo(t);
|
|
}
|
|
kfree(list); // no-warning
|
|
}
|
|
|
|
void test_3arg_malloc_nonzero(struct malloc_type *mtp) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, 0);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i]; // expected-warning{{uninitialized}}
|
|
foo(t);
|
|
}
|
|
kfree(list);
|
|
}
|
|
|
|
void test_3arg_malloc_indeterminate(struct malloc_type *mtp, int flags) {
|
|
struct test **list, *t;
|
|
int i;
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, flags);
|
|
if (list == NULL)
|
|
return;
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
t = list[i]; // expected-warning{{uninitialized}}
|
|
foo(t);
|
|
}
|
|
kfree(list);
|
|
}
|
|
|
|
void test_3arg_malloc_leak(struct malloc_type *mtp, int flags) {
|
|
struct test **list;
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, flags);
|
|
if (list == NULL)
|
|
return;
|
|
} // expected-warning{{Potential leak of memory pointed to by 'list'}}
|
|
|
|
// kmalloc can return a constant value defined in ZERO_SIZE_PTR
|
|
// if a block of size 0 is requested
|
|
#define ZERO_SIZE_PTR ((void *)16)
|
|
|
|
void test_kfree_ZERO_SIZE_PTR(void) {
|
|
void *ptr = ZERO_SIZE_PTR;
|
|
kfree(ptr); // no warning about freeing this value
|
|
}
|
|
|
|
void test_kfree_other_constant_value(void) {
|
|
void *ptr = (void *)1;
|
|
kfree(ptr); // expected-warning{{Argument to 'kfree()' is a constant address (1)}}
|
|
}
|