Files
RedBear-OS/local/recipes/system/seatd/source/seatd/client.c
T
vasilito f31522130f fix: comprehensive boot warnings and exceptions — fixable silenced, unfixable diagnosed
Build system (5 gaps hardened):
- COOKBOOK_OFFLINE defaults to true (fork-mode)
- normalize_patch handles diff -ruN format
- New 'repo validate-patches' command (25/25 relibc patches)
- 14 patched Qt/Wayland/display recipes added to protected list
- relibc archive regenerated with current patch chain

Boot fixes (fixable):
- Full ISO EFI partition: 16 MiB → 1 MiB (matches mini, BIOS hardcoded 2 MiB offset)
- D-Bus system bus: absolute /usr/bin/dbus-daemon path (was skipped)
- redbear-sessiond: absolute /usr/bin/redbear-sessiond path (was skipped)
- daemon framework: silenced spurious INIT_NOTIFY warnings for oneshot_async services (P0-daemon-silence-init-notify.patch)
- udev-shim: demoted INIT_NOTIFY warning to INFO (expected for oneshot_async)
- relibc: comprehensive named semaphores (sem_open/close/unlink) replacing upstream todo!() stubs
- greeterd: Wayland socket timeout 15s → 30s (compositor DRM wait)
- greeter-ui: built and linked (header guard unification, sem_compat stubs removed)
- mc: un-ignored in both configs, fixed glib/libiconv/pcre2 transitive deps
- greeter config: removed stale keymapd dependency from display/greeter services
- prefix toolchain: relibc headers synced, _RELIBC_STDLIB_H guard unified

Unfixable (diagnosed, upstream):
- i2c-hidd: abort on no-I2C-hardware (QEMU) — process::exit → relibc abort
- kded6/greeter-ui: page fault 0x8 — Qt library null deref
- Thread panics fd != -1 — Rust std library on Redox
- DHCP timeout / eth0 MAC — QEMU user-mode networking
- hwrngd/thermald — no hardware RNG/thermal in VM
- live preload allocation — BIOS memory fragmentation, continues on demand
2026-05-05 20:20:37 +01:00

529 lines
13 KiB
C

#define _GNU_SOURCE
#include <assert.h>
#include <errno.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdlib.h>
#include <string.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <unistd.h>
#if defined(__FreeBSD__)
#include <sys/ucred.h>
#include <sys/un.h>
#endif
#if defined(__NetBSD__)
#include <sys/un.h>
#endif
#include "client.h"
#include "linked_list.h"
#include "log.h"
#include "poller.h"
#include "protocol.h"
#include "seat.h"
#include "server.h"
#include "terminal.h"
static int get_peer(int fd, pid_t *pid, uid_t *uid, gid_t *gid) {
#if defined(__linux__) || defined(__redox__)
struct ucred cred;
socklen_t len = sizeof cred;
if (getsockopt(fd, SOL_SOCKET, SO_PEERCRED, &cred, &len) == -1) {
return -1;
}
*pid = cred.pid;
*uid = cred.uid;
*gid = cred.gid;
return 0;
#elif defined(__NetBSD__)
struct unpcbid cred;
socklen_t len = sizeof cred;
if (getsockopt(fd, 0, LOCAL_PEEREID, &cred, &len) == -1) {
// assume builtin backend
if (errno == EINVAL) {
*pid = getpid();
*uid = getuid();
*gid = getgid();
return 0;
}
return -1;
}
*pid = cred.unp_pid;
*uid = cred.unp_euid;
*gid = cred.unp_egid;
return 0;
#elif defined(__FreeBSD__)
struct xucred cred;
socklen_t len = sizeof cred;
if (getsockopt(fd, 0, LOCAL_PEERCRED, &cred, &len) == -1) {
return -1;
}
#if __FreeBSD_version >= 1300030 || (__FreeBSD_version >= 1202506 && __FreeBSD_version < 1300000)
*pid = cred.cr_pid;
#else
*pid = -1;
#endif
*uid = cred.cr_uid;
*gid = cred.cr_ngroups > 0 ? cred.cr_groups[0] : (gid_t)-1;
return 0;
#else
#error Unsupported platform
#endif
}
struct client *client_create(struct server *server, int client_fd) {
uid_t uid;
gid_t gid;
pid_t pid;
if (get_peer(client_fd, &pid, &uid, &gid) == -1) {
return NULL;
}
struct client *client = calloc(1, sizeof(struct client));
if (client == NULL) {
return NULL;
}
client->uid = uid;
client->gid = gid;
client->pid = pid;
client->session = -1;
client->server = server;
client->connection.fd = client_fd;
client->state = CLIENT_NEW;
linked_list_init(&client->devices);
linked_list_insert(&server->idle_clients, &client->link);
return client;
}
void client_destroy(struct client *client) {
assert(client);
#ifdef LIBSEAT
// The built-in backend version of seatd should terminate once its only
// client disconnects.
client->server->running = false;
#endif
client->server = NULL;
if (client->connection.fd != -1) {
close(client->connection.fd);
client->connection.fd = -1;
}
if (client->seat != NULL) {
seat_remove_client(client);
}
linked_list_remove(&client->link);
if (client->event_source != NULL) {
event_source_fd_destroy(client->event_source);
client->event_source = NULL;
}
connection_close_fds(&client->connection);
assert(linked_list_empty(&client->devices));
free(client);
}
static int client_flush(struct client *client) {
int ret = connection_flush(&client->connection);
if (ret == -1 && errno == EAGAIN) {
event_source_fd_update(client->event_source, EVENT_READABLE | EVENT_WRITABLE);
} else if (ret == -1) {
return -1;
}
return 0;
}
static int client_send_error(struct client *client, int error_code) {
struct proto_server_error errmsg = {
.error_code = error_code,
};
struct proto_header errheader = {
.opcode = SERVER_ERROR,
.size = sizeof errmsg,
};
if (connection_put(&client->connection, &errheader, sizeof errheader) == -1 ||
connection_put(&client->connection, &errmsg, sizeof errmsg) == -1) {
log_errorf("Could not send error to client: %s", strerror(errno));
return -1;
}
return 0;
}
static char *client_get_seat_name(struct client *client) {
(void)client;
// TODO: Look up seat for session.
return "seat0";
}
static int handle_open_seat(struct client *client) {
char *seat_name = client_get_seat_name(client);
if (seat_name == NULL) {
log_error("Could not get name of target seat");
return -1;
}
struct seat *seat = server_get_seat(client->server, seat_name);
if (seat == NULL) {
log_errorf("Could not find seat named %s", seat_name);
return -1;
}
if (seat_add_client(seat, client) == -1) {
log_errorf("Could not add client to target seat: %s", strerror(errno));
return -1;
}
size_t seat_name_len = strlen(seat_name) + 1;
struct proto_server_seat_opened rmsg = {
.seat_name_len = (uint16_t)seat_name_len,
};
struct proto_header header = {
.opcode = SERVER_SEAT_OPENED,
.size = sizeof rmsg + seat_name_len,
};
if (connection_put(&client->connection, &header, sizeof header) == -1 ||
connection_put(&client->connection, &rmsg, sizeof rmsg) == -1 ||
connection_put(&client->connection, seat_name, seat_name_len) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
seat_open_client(seat, client);
return 0;
}
static int handle_close_seat(struct client *client) {
if (client->seat == NULL) {
log_error("Protocol error: no seat associated with client");
return -1;
}
seat_remove_client(client);
linked_list_insert(&client->server->idle_clients, &client->link);
struct proto_header header = {
.opcode = SERVER_SEAT_CLOSED,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int handle_open_device(struct client *client, char *path) {
if (client->seat == NULL) {
log_error("Protocol error: no seat associated with client");
return -1;
}
struct seat_device *device = seat_open_device(client, path);
if (device == NULL) {
log_errorf("Could not open device: %s", strerror(errno));
return client_send_error(client, errno);
}
int dupfd = dup(device->fd);
if (dupfd == -1) {
log_errorf("Could not dup fd: %s", strerror(errno));
seat_close_device(client, device);
return client_send_error(client, errno);
}
if (connection_put_fd(&client->connection, dupfd) == -1) {
log_errorf("Could not queue fd for sending: %s", strerror(errno));
return -1;
}
struct proto_server_device_opened msg = {
.device_id = device->device_id,
};
struct proto_header header = {
.opcode = SERVER_DEVICE_OPENED,
.size = sizeof msg,
};
if (connection_put(&client->connection, &header, sizeof header) == -1 ||
connection_put(&client->connection, &msg, sizeof msg) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int handle_close_device(struct client *client, int device_id) {
if (client->seat == NULL) {
log_error("Protocol error: no seat associated with client");
return -1;
}
struct seat_device *device = seat_find_device(client, device_id);
if (device == NULL) {
log_error("No such device");
return client_send_error(client, EBADF);
}
seat_close_device(client, device);
struct proto_header header = {
.opcode = SERVER_DEVICE_CLOSED,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int handle_switch_session(struct client *client, int session) {
if (client->seat == NULL) {
log_error("Protocol error: no seat associated with client");
return -1;
}
if (seat_set_next_session(client, session) == -1) {
return client_send_error(client, errno);
}
struct proto_header header = {
.opcode = SERVER_SESSION_SWITCHED,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int handle_disable_seat(struct client *client) {
if (client->seat == NULL) {
log_error("Protocol error: no seat associated with client");
return -1;
}
if (seat_ack_disable_client(client) == -1) {
return client_send_error(client, errno);
}
struct proto_header header = {
.opcode = SERVER_SEAT_DISABLED,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int handle_ping(struct client *client) {
struct proto_header header = {
.opcode = SERVER_PONG,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1) {
log_errorf("Could not write response: %s", strerror(errno));
return -1;
}
return 0;
}
static int client_handle_opcode(struct client *client, uint16_t opcode, size_t size) {
int res = 0;
switch (opcode) {
case CLIENT_OPEN_SEAT: {
if (size != 0) {
log_error("Protocol error: invalid open_seat message");
return -1;
}
res = handle_open_seat(client);
break;
}
case CLIENT_CLOSE_SEAT: {
if (size != 0) {
log_error("Protocol error: invalid close_seat message");
return -1;
}
res = handle_close_seat(client);
break;
}
case CLIENT_OPEN_DEVICE: {
char path[MAX_PATH_LEN];
struct proto_client_open_device msg;
if (sizeof msg > size || connection_get(&client->connection, &msg, sizeof msg) == -1) {
log_error("Protocol error: invalid open_device message");
return -1;
}
if (msg.path_len != size - sizeof msg) {
log_errorf("Protocol error: device path_len does not match remaining message size (%d != %zd)",
msg.path_len, size);
return -1;
}
if (msg.path_len > MAX_PATH_LEN) {
log_errorf("Protocol error: device path too long: (%d)", msg.path_len);
return -1;
}
if (connection_get(&client->connection, path, msg.path_len) == -1) {
log_error("Protocol error: invalid open_device message");
return -1;
}
if (msg.path_len == 0 || strnlen(path, msg.path_len) != (uint16_t)(msg.path_len - 1)) {
log_error("Protocol error: device path not null terminated");
return -1;
}
res = handle_open_device(client, path);
break;
}
case CLIENT_CLOSE_DEVICE: {
struct proto_client_close_device msg;
if (sizeof msg != size ||
connection_get(&client->connection, &msg, sizeof msg) == -1) {
log_error("Protocol error: invalid close_device message");
return -1;
}
res = handle_close_device(client, msg.device_id);
break;
}
case CLIENT_SWITCH_SESSION: {
struct proto_client_switch_session msg;
if (sizeof msg != size ||
connection_get(&client->connection, &msg, sizeof msg) == -1) {
log_error("Protocol error: invalid switch_session message");
return -1;
}
res = handle_switch_session(client, msg.session);
break;
}
case CLIENT_DISABLE_SEAT: {
if (size != 0) {
log_error("Protocol error: invalid disable_seat message");
return -1;
}
res = handle_disable_seat(client);
break;
}
case CLIENT_PING: {
if (size != 0) {
log_error("Protocol error: invalid ping message");
return -1;
}
res = handle_ping(client);
break;
}
default:
log_errorf("Protocol error: unknown opcode: %d", opcode);
res = -1;
break;
}
if (res != -1) {
res = client_flush(client);
}
return res;
}
int client_send_disable_seat(struct client *client) {
struct proto_header header = {
.opcode = SERVER_DISABLE_SEAT,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1 ||
connection_flush(&client->connection) == -1) {
log_errorf("Could not send event: %s", strerror(errno));
return -1;
}
return 0;
}
int client_send_enable_seat(struct client *client) {
struct proto_header header = {
.opcode = SERVER_ENABLE_SEAT,
.size = 0,
};
if (connection_put(&client->connection, &header, sizeof header) == -1 ||
connection_flush(&client->connection) == -1) {
log_errorf("Could not send event: %s", strerror(errno));
return -1;
}
return 0;
}
int client_handle_connection(int fd, uint32_t mask, void *data) {
(void)fd;
struct client *client = data;
if (mask & EVENT_ERROR) {
log_error("Connection error");
goto fail;
}
if (mask & EVENT_HANGUP) {
log_info("Client disconnected");
goto fail;
}
if (mask & EVENT_WRITABLE) {
int len = connection_flush(&client->connection);
if (len == -1 && errno != EAGAIN) {
log_errorf("Could not flush client connection: %s", strerror(errno));
goto fail;
} else if (len >= 0) {
event_source_fd_update(client->event_source, EVENT_READABLE);
}
}
if (mask & EVENT_READABLE) {
int len = connection_read(&client->connection);
if (len == -1 && errno != EAGAIN) {
log_errorf("Could not read client connection: %s", strerror(errno));
goto fail;
}
if (len == 0) {
// https://man.netbsd.org/poll.2
// Sockets produce POLLIN rather than POLLHUP when the remote end is closed.
#if defined(__NetBSD__)
log_info("Client disconnected");
#else
log_error("Could not read client connection: zero-length read");
#endif
goto fail;
}
struct proto_header header;
while (connection_get(&client->connection, &header, sizeof header) != -1) {
if (connection_pending(&client->connection) < header.size) {
connection_restore(&client->connection, sizeof header);
break;
}
if (client_handle_opcode(client, header.opcode, header.size) == -1) {
goto fail;
}
}
}
return 0;
fail:
client_destroy(client);
return -1;
}