cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
330 lines
12 KiB
C++
330 lines
12 KiB
C++
//===- MachineBlockFrequencyInfo.cpp - MBB Frequency Analysis -------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Loops should be simplified before this analysis.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
|
|
#include "llvm/ADT/DenseMap.h"
|
|
#include "llvm/ADT/iterator.h"
|
|
#include "llvm/Analysis/BlockFrequencyInfoImpl.h"
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
|
#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineLoopInfo.h"
|
|
#include "llvm/InitializePasses.h"
|
|
#include "llvm/Pass.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
#include "llvm/Support/GraphWriter.h"
|
|
#include <optional>
|
|
#include <string>
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "machine-block-freq"
|
|
|
|
namespace llvm {
|
|
static cl::opt<GVDAGType> ViewMachineBlockFreqPropagationDAG(
|
|
"view-machine-block-freq-propagation-dags", cl::Hidden,
|
|
cl::desc("Pop up a window to show a dag displaying how machine block "
|
|
"frequencies propagate through the CFG."),
|
|
cl::values(clEnumValN(GVDT_None, "none", "do not display graphs."),
|
|
clEnumValN(GVDT_Fraction, "fraction",
|
|
"display a graph using the "
|
|
"fractional block frequency representation."),
|
|
clEnumValN(GVDT_Integer, "integer",
|
|
"display a graph using the raw "
|
|
"integer fractional block frequency representation."),
|
|
clEnumValN(GVDT_Count, "count", "display a graph using the real "
|
|
"profile count if available.")));
|
|
|
|
// Similar option above, but used to control BFI display only after MBP pass
|
|
cl::opt<GVDAGType> ViewBlockLayoutWithBFI(
|
|
"view-block-layout-with-bfi", cl::Hidden,
|
|
cl::desc(
|
|
"Pop up a window to show a dag displaying MBP layout and associated "
|
|
"block frequencies of the CFG."),
|
|
cl::values(clEnumValN(GVDT_None, "none", "do not display graphs."),
|
|
clEnumValN(GVDT_Fraction, "fraction",
|
|
"display a graph using the "
|
|
"fractional block frequency representation."),
|
|
clEnumValN(GVDT_Integer, "integer",
|
|
"display a graph using the raw "
|
|
"integer fractional block frequency representation."),
|
|
clEnumValN(GVDT_Count, "count",
|
|
"display a graph using the real "
|
|
"profile count if available.")));
|
|
|
|
// Command line option to specify the name of the function for CFG dump
|
|
// Defined in Analysis/BlockFrequencyInfo.cpp: -view-bfi-func-name=
|
|
extern cl::opt<std::string> ViewBlockFreqFuncName;
|
|
|
|
// Command line option to specify hot frequency threshold.
|
|
// Defined in Analysis/BlockFrequencyInfo.cpp: -view-hot-freq-perc=
|
|
extern cl::opt<unsigned> ViewHotFreqPercent;
|
|
|
|
static cl::opt<bool> PrintMachineBlockFreq(
|
|
"print-machine-bfi", cl::init(false), cl::Hidden,
|
|
cl::desc("Print the machine block frequency info."));
|
|
|
|
// Command line option to specify the name of the function for block frequency
|
|
// dump. Defined in Analysis/BlockFrequencyInfo.cpp.
|
|
extern cl::opt<std::string> PrintBFIFuncName;
|
|
} // namespace llvm
|
|
|
|
static GVDAGType getGVDT() {
|
|
if (ViewBlockLayoutWithBFI != GVDT_None)
|
|
return ViewBlockLayoutWithBFI;
|
|
|
|
return ViewMachineBlockFreqPropagationDAG;
|
|
}
|
|
|
|
namespace llvm {
|
|
|
|
template <> struct GraphTraits<MachineBlockFrequencyInfo *> {
|
|
using NodeRef = const MachineBasicBlock *;
|
|
using ChildIteratorType = MachineBasicBlock::const_succ_iterator;
|
|
using nodes_iterator = pointer_iterator<MachineFunction::const_iterator>;
|
|
|
|
static NodeRef getEntryNode(const MachineBlockFrequencyInfo *G) {
|
|
return &G->getFunction()->front();
|
|
}
|
|
|
|
static ChildIteratorType child_begin(const NodeRef N) {
|
|
return N->succ_begin();
|
|
}
|
|
|
|
static ChildIteratorType child_end(const NodeRef N) { return N->succ_end(); }
|
|
|
|
static nodes_iterator nodes_begin(const MachineBlockFrequencyInfo *G) {
|
|
return nodes_iterator(G->getFunction()->begin());
|
|
}
|
|
|
|
static nodes_iterator nodes_end(const MachineBlockFrequencyInfo *G) {
|
|
return nodes_iterator(G->getFunction()->end());
|
|
}
|
|
};
|
|
|
|
using MBFIDOTGraphTraitsBase =
|
|
BFIDOTGraphTraitsBase<MachineBlockFrequencyInfo,
|
|
MachineBranchProbabilityInfo>;
|
|
|
|
template <>
|
|
struct DOTGraphTraits<MachineBlockFrequencyInfo *>
|
|
: public MBFIDOTGraphTraitsBase {
|
|
const MachineFunction *CurFunc = nullptr;
|
|
DenseMap<const MachineBasicBlock *, int> LayoutOrderMap;
|
|
|
|
explicit DOTGraphTraits(bool isSimple = false)
|
|
: MBFIDOTGraphTraitsBase(isSimple) {}
|
|
|
|
std::string getNodeLabel(const MachineBasicBlock *Node,
|
|
const MachineBlockFrequencyInfo *Graph) {
|
|
int layout_order = -1;
|
|
// Attach additional ordering information if 'isSimple' is false.
|
|
if (!isSimple()) {
|
|
const MachineFunction *F = Node->getParent();
|
|
if (!CurFunc || F != CurFunc) {
|
|
if (CurFunc)
|
|
LayoutOrderMap.clear();
|
|
|
|
CurFunc = F;
|
|
int O = 0;
|
|
for (auto MBI = F->begin(); MBI != F->end(); ++MBI, ++O) {
|
|
LayoutOrderMap[&*MBI] = O;
|
|
}
|
|
}
|
|
layout_order = LayoutOrderMap[Node];
|
|
}
|
|
return MBFIDOTGraphTraitsBase::getNodeLabel(Node, Graph, getGVDT(),
|
|
layout_order);
|
|
}
|
|
|
|
std::string getNodeAttributes(const MachineBasicBlock *Node,
|
|
const MachineBlockFrequencyInfo *Graph) {
|
|
return MBFIDOTGraphTraitsBase::getNodeAttributes(Node, Graph,
|
|
ViewHotFreqPercent);
|
|
}
|
|
|
|
std::string getEdgeAttributes(const MachineBasicBlock *Node, EdgeIter EI,
|
|
const MachineBlockFrequencyInfo *MBFI) {
|
|
return MBFIDOTGraphTraitsBase::getEdgeAttributes(
|
|
Node, EI, MBFI, MBFI->getMBPI(), ViewHotFreqPercent);
|
|
}
|
|
};
|
|
|
|
} // end namespace llvm
|
|
|
|
AnalysisKey MachineBlockFrequencyAnalysis::Key;
|
|
|
|
MachineBlockFrequencyAnalysis::Result
|
|
MachineBlockFrequencyAnalysis::run(MachineFunction &MF,
|
|
MachineFunctionAnalysisManager &MFAM) {
|
|
auto &MBPI = MFAM.getResult<MachineBranchProbabilityAnalysis>(MF);
|
|
auto &MLI = MFAM.getResult<MachineLoopAnalysis>(MF);
|
|
return Result(MF, MBPI, MLI);
|
|
}
|
|
|
|
PreservedAnalyses
|
|
MachineBlockFrequencyPrinterPass::run(MachineFunction &MF,
|
|
MachineFunctionAnalysisManager &MFAM) {
|
|
auto &MBFI = MFAM.getResult<MachineBlockFrequencyAnalysis>(MF);
|
|
OS << "Machine block frequency for machine function: " << MF.getName()
|
|
<< '\n';
|
|
MBFI.print(OS);
|
|
return PreservedAnalyses::all();
|
|
}
|
|
|
|
INITIALIZE_PASS_BEGIN(MachineBlockFrequencyInfoWrapperPass, DEBUG_TYPE,
|
|
"Machine Block Frequency Analysis", true, true)
|
|
INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfoWrapperPass)
|
|
INITIALIZE_PASS_DEPENDENCY(MachineLoopInfoWrapperPass)
|
|
INITIALIZE_PASS_END(MachineBlockFrequencyInfoWrapperPass, DEBUG_TYPE,
|
|
"Machine Block Frequency Analysis", true, true)
|
|
|
|
char MachineBlockFrequencyInfoWrapperPass::ID = 0;
|
|
|
|
MachineBlockFrequencyInfoWrapperPass::MachineBlockFrequencyInfoWrapperPass()
|
|
: MachineFunctionPass(ID) {
|
|
initializeMachineBlockFrequencyInfoWrapperPassPass(
|
|
*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
MachineBlockFrequencyInfo::MachineBlockFrequencyInfo() = default;
|
|
|
|
MachineBlockFrequencyInfo::MachineBlockFrequencyInfo(
|
|
MachineBlockFrequencyInfo &&) = default;
|
|
|
|
MachineBlockFrequencyInfo::MachineBlockFrequencyInfo(
|
|
MachineFunction &F, MachineBranchProbabilityInfo &MBPI,
|
|
MachineLoopInfo &MLI) {
|
|
calculate(F, MBPI, MLI);
|
|
}
|
|
|
|
MachineBlockFrequencyInfo::~MachineBlockFrequencyInfo() = default;
|
|
|
|
bool MachineBlockFrequencyInfo::invalidate(
|
|
MachineFunction &MF, const PreservedAnalyses &PA,
|
|
MachineFunctionAnalysisManager::Invalidator &) {
|
|
// Check whether the analysis, all analyses on machine functions, or the
|
|
// machine function's CFG have been preserved.
|
|
auto PAC = PA.getChecker<MachineBlockFrequencyAnalysis>();
|
|
return !PAC.preserved() &&
|
|
!PAC.preservedSet<AllAnalysesOn<MachineFunction>>() &&
|
|
!PAC.preservedSet<CFGAnalyses>();
|
|
}
|
|
|
|
void MachineBlockFrequencyInfoWrapperPass::getAnalysisUsage(
|
|
AnalysisUsage &AU) const {
|
|
AU.addRequired<MachineBranchProbabilityInfoWrapperPass>();
|
|
AU.addRequired<MachineLoopInfoWrapperPass>();
|
|
AU.setPreservesAll();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
void MachineBlockFrequencyInfo::calculate(
|
|
const MachineFunction &F, const MachineBranchProbabilityInfo &MBPI,
|
|
const MachineLoopInfo &MLI) {
|
|
if (!MBFI)
|
|
MBFI.reset(new ImplType);
|
|
MBFI->calculate(F, MBPI, MLI);
|
|
if (ViewMachineBlockFreqPropagationDAG != GVDT_None &&
|
|
(ViewBlockFreqFuncName.empty() || F.getName() == ViewBlockFreqFuncName)) {
|
|
view("MachineBlockFrequencyDAGS." + F.getName());
|
|
}
|
|
if (PrintMachineBlockFreq &&
|
|
(PrintBFIFuncName.empty() || F.getName() == PrintBFIFuncName)) {
|
|
MBFI->print(dbgs());
|
|
}
|
|
}
|
|
|
|
bool MachineBlockFrequencyInfoWrapperPass::runOnMachineFunction(
|
|
MachineFunction &F) {
|
|
MachineBranchProbabilityInfo &MBPI =
|
|
getAnalysis<MachineBranchProbabilityInfoWrapperPass>().getMBPI();
|
|
MachineLoopInfo &MLI = getAnalysis<MachineLoopInfoWrapperPass>().getLI();
|
|
MBFI.calculate(F, MBPI, MLI);
|
|
return false;
|
|
}
|
|
|
|
void MachineBlockFrequencyInfo::print(raw_ostream &OS) { MBFI->print(OS); }
|
|
|
|
void MachineBlockFrequencyInfo::releaseMemory() { MBFI.reset(); }
|
|
|
|
/// Pop up a ghostview window with the current block frequency propagation
|
|
/// rendered using dot.
|
|
void MachineBlockFrequencyInfo::view(const Twine &Name, bool isSimple) const {
|
|
// This code is only for debugging.
|
|
ViewGraph(const_cast<MachineBlockFrequencyInfo *>(this), Name, isSimple);
|
|
}
|
|
|
|
BlockFrequency
|
|
MachineBlockFrequencyInfo::getBlockFreq(const MachineBasicBlock *MBB) const {
|
|
return MBFI ? MBFI->getBlockFreq(MBB) : BlockFrequency(0);
|
|
}
|
|
|
|
std::optional<uint64_t> MachineBlockFrequencyInfo::getBlockProfileCount(
|
|
const MachineBasicBlock *MBB) const {
|
|
if (!MBFI)
|
|
return std::nullopt;
|
|
|
|
const Function &F = MBFI->getFunction()->getFunction();
|
|
return MBFI->getBlockProfileCount(F, MBB);
|
|
}
|
|
|
|
std::optional<uint64_t>
|
|
MachineBlockFrequencyInfo::getProfileCountFromFreq(BlockFrequency Freq) const {
|
|
if (!MBFI)
|
|
return std::nullopt;
|
|
|
|
const Function &F = MBFI->getFunction()->getFunction();
|
|
return MBFI->getProfileCountFromFreq(F, Freq);
|
|
}
|
|
|
|
bool MachineBlockFrequencyInfo::isIrrLoopHeader(
|
|
const MachineBasicBlock *MBB) const {
|
|
assert(MBFI && "Expected analysis to be available");
|
|
return MBFI->isIrrLoopHeader(MBB);
|
|
}
|
|
|
|
void MachineBlockFrequencyInfo::onEdgeSplit(
|
|
const MachineBasicBlock &NewPredecessor,
|
|
const MachineBasicBlock &NewSuccessor,
|
|
const MachineBranchProbabilityInfo &MBPI) {
|
|
assert(MBFI && "Expected analysis to be available");
|
|
auto NewSuccFreq = MBFI->getBlockFreq(&NewPredecessor) *
|
|
MBPI.getEdgeProbability(&NewPredecessor, &NewSuccessor);
|
|
|
|
MBFI->setBlockFreq(&NewSuccessor, NewSuccFreq);
|
|
}
|
|
|
|
const MachineFunction *MachineBlockFrequencyInfo::getFunction() const {
|
|
return MBFI ? MBFI->getFunction() : nullptr;
|
|
}
|
|
|
|
const MachineBranchProbabilityInfo *MachineBlockFrequencyInfo::getMBPI() const {
|
|
return MBFI ? &MBFI->getBPI() : nullptr;
|
|
}
|
|
|
|
BlockFrequency MachineBlockFrequencyInfo::getEntryFreq() const {
|
|
return MBFI ? MBFI->getEntryFreq() : BlockFrequency(0);
|
|
}
|
|
|
|
Printable llvm::printBlockFreq(const MachineBlockFrequencyInfo &MBFI,
|
|
BlockFrequency Freq) {
|
|
return Printable([&MBFI, Freq](raw_ostream &OS) {
|
|
printRelativeBlockFreq(OS, MBFI.getEntryFreq(), Freq);
|
|
});
|
|
}
|
|
|
|
Printable llvm::printBlockFreq(const MachineBlockFrequencyInfo &MBFI,
|
|
const MachineBasicBlock &MBB) {
|
|
return printBlockFreq(MBFI, MBFI.getBlockFreq(&MBB));
|
|
}
|