cb424d7448
verify-patch-sanity.py validates every active recipe .patch has internally- consistent hunk line counts — catching the 'malformed patch at line N' failure at commit/CI/preflight time instead of hours into a cook. This cycle hit that class three times (qtwaylandscanner, sddm, xwayland), each only discovered when cookbook tried to apply the patch. Running it across the repo found 29 latent malformed patches (validated against GNU patch: e.g. relibc/P3-sysv-ipc reproduces 'malformed patch at line 22'). They were harmless only because they sit in vendored recipes (baked, not re- applied) — but would fail on any version-bump re-derivation. --fix recounts the hunk headers (body untouched) and repaired all 29. Wired into build-preflight.sh (Phase 1.0D) and redbear-ci.yml, with a unit test (test-patch-sanity.sh). Skips archived/legacy trees and unvalidatable formats (empty placeholders, bare-@@ git hunks).
130 lines
4.9 KiB
C++
130 lines
4.9 KiB
C++
//===-- lib/Semantics/check-select-rank.cpp -------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "check-select-rank.h"
|
|
#include "flang/Common/idioms.h"
|
|
#include "flang/Parser/message.h"
|
|
#include "flang/Parser/tools.h"
|
|
#include "flang/Semantics/tools.h"
|
|
#include "flang/Support/Fortran.h"
|
|
#include <list>
|
|
#include <optional>
|
|
#include <set>
|
|
#include <tuple>
|
|
#include <variant>
|
|
|
|
namespace Fortran::semantics {
|
|
|
|
void SelectRankConstructChecker::Leave(
|
|
const parser::SelectRankConstruct &selectRankConstruct) {
|
|
const auto &selectRankStmt{
|
|
std::get<parser::Statement<parser::SelectRankStmt>>(
|
|
selectRankConstruct.t)};
|
|
const auto &selectRankStmtSel{
|
|
std::get<parser::Selector>(selectRankStmt.statement.t)};
|
|
|
|
// R1149 select-rank-stmt checks
|
|
const Symbol *saveSelSymbol{nullptr};
|
|
if (const auto selExpr{GetExprFromSelector(selectRankStmtSel)}) {
|
|
if (const Symbol * sel{evaluate::UnwrapWholeSymbolDataRef(*selExpr)}) {
|
|
if (!evaluate::IsAssumedRank(*sel)) { // C1150
|
|
context_.Say(parser::FindSourceLocation(selectRankStmtSel),
|
|
"Selector '%s' is not an assumed-rank array variable"_err_en_US,
|
|
sel->name().ToString());
|
|
} else {
|
|
saveSelSymbol = sel;
|
|
}
|
|
} else {
|
|
context_.Say(parser::FindSourceLocation(selectRankStmtSel),
|
|
"Selector '%s' is not an assumed-rank array variable"_err_en_US,
|
|
parser::FindSourceLocation(selectRankStmtSel).ToString());
|
|
}
|
|
}
|
|
|
|
// R1150 select-rank-case-stmt checks
|
|
auto &rankCaseList{std::get<std::list<parser::SelectRankConstruct::RankCase>>(
|
|
selectRankConstruct.t)};
|
|
bool defaultRankFound{false};
|
|
bool starRankFound{false};
|
|
parser::CharBlock prevLocDefault;
|
|
parser::CharBlock prevLocStar;
|
|
std::optional<parser::CharBlock> caseForRank[common::maxRank + 1];
|
|
|
|
for (const auto &rankCase : rankCaseList) {
|
|
const auto &rankCaseStmt{
|
|
std::get<parser::Statement<parser::SelectRankCaseStmt>>(rankCase.t)};
|
|
const auto &rank{
|
|
std::get<parser::SelectRankCaseStmt::Rank>(rankCaseStmt.statement.t)};
|
|
common::visit(
|
|
common::visitors{
|
|
[&](const parser::Default &) { // C1153
|
|
if (!defaultRankFound) {
|
|
defaultRankFound = true;
|
|
prevLocDefault = rankCaseStmt.source;
|
|
} else {
|
|
context_
|
|
.Say(rankCaseStmt.source,
|
|
"Not more than one of the selectors of SELECT RANK "
|
|
"statement may be DEFAULT"_err_en_US)
|
|
.Attach(prevLocDefault, "Previous use"_en_US);
|
|
}
|
|
},
|
|
[&](const parser::Star &) { // C1153
|
|
if (!starRankFound) {
|
|
starRankFound = true;
|
|
prevLocStar = rankCaseStmt.source;
|
|
} else {
|
|
context_
|
|
.Say(rankCaseStmt.source,
|
|
"Not more than one of the selectors of SELECT RANK "
|
|
"statement may be '*'"_err_en_US)
|
|
.Attach(prevLocStar, "Previous use"_en_US);
|
|
}
|
|
if (saveSelSymbol &&
|
|
IsAllocatableOrPointer(*saveSelSymbol)) { // F'2023 C1160
|
|
context_.Say(rankCaseStmt.source,
|
|
"RANK (*) cannot be used when selector is "
|
|
"POINTER or ALLOCATABLE"_err_en_US);
|
|
}
|
|
},
|
|
[&](const parser::ScalarIntConstantExpr &init) {
|
|
if (auto val{GetIntValue(init)}) {
|
|
// If value is in valid range, then only show
|
|
// value repeat error, else stack smashing occurs
|
|
if (*val < 0 || *val > common::maxRank) { // C1151
|
|
context_.Say(rankCaseStmt.source,
|
|
"The value of the selector must be "
|
|
"between zero and %d"_err_en_US,
|
|
common::maxRank);
|
|
|
|
} else {
|
|
if (!caseForRank[*val].has_value()) {
|
|
caseForRank[*val] = rankCaseStmt.source;
|
|
} else {
|
|
auto prevloc{caseForRank[*val].value()};
|
|
context_
|
|
.Say(rankCaseStmt.source,
|
|
"Same rank value (%d) not allowed more than once"_err_en_US,
|
|
*val)
|
|
.Attach(prevloc, "Previous use"_en_US);
|
|
}
|
|
}
|
|
}
|
|
},
|
|
},
|
|
rank.u);
|
|
}
|
|
}
|
|
|
|
const SomeExpr *SelectRankConstructChecker::GetExprFromSelector(
|
|
const parser::Selector &selector) {
|
|
return common::visit([](const auto &x) { return GetExpr(x); }, selector.u);
|
|
}
|
|
|
|
} // namespace Fortran::semantics
|