Commit Graph

4 Commits

Author SHA1 Message Date
vasilito dd6dd99cea round 16: log authd child.wait exit status + dnsd send_to failures
Round 16 audit follow-up. Three small fixes:

1. local/recipes/system/redbear-authd/source/src/main.rs:328 — the
   validation-mode spawn-reaper thread did 'let _ = child.wait();'
   silently dropping the session child's exit status. Replaced with
   'match' that eprintln-logs both successful exit status and wait
   failure (with errno). Operators can now see when the session
   child exits abnormally in validation mode.

2. local/recipes/system/redbear-dnsd/source/src/main.rs:111 — the
   loopback DNS responder did 'let _ = socket.send_to(&reply, &src);'
   silently. Replaced with 'if let Err(e) = socket.send_to(...)' that
   eprintln-logs the failure with the source peer address. Previously
   DNS clients could fail to receive a valid reply with no visible
   error.

3. local/docs/SUPERSEDED-DOC-LOG.md — appended Round 16 entries
   documenting the authd/dnsd fixes plus the Round-16 audit findings
   that did not require code changes (acpi-rs AML 41 panics classified
   as internal-invariant, pcid panics already have messages, all stale
   CONFIG refs already retired, USB-daemon let _ = is in host-only test
   paths, sessiond can_* for sleep is honest stub, Mesa CS ioctl
   numbers verified no drift).

3 files changed, +27/-2.
2026-07-27 22:10:34 +09:00
vasilito 7a5b5963c4 round 16: log R15 entries in SUPERSEDED-DOC-LOG + document sessiond sleep TODO
Round 16 audit follow-up. Two small but useful additions:

1. local/docs/SUPERSEDED-DOC-LOG.md — appended R15 entries:
   greeter/netctl/hotplugd let-underscore-to-logged (5682072e58),
   acmd setrens security fix (883e8147ec), README null+8 contradiction
   reconciliation, and the redbear-live.iso stale-reference fix.

2. local/recipes/system/redbear-sessiond/source/src/manager.rs —
   the can_hibernate / can_hybrid_sleep / can_suspend_then_hibernate
   / can_sleep functions all return hardcoded 'na'. Documented the
   integration plan in a block comment above them: when the
   /scheme/sys/sleep and /scheme/sys/hybrid_sleep schemes exist
   in the Redox kernel, replace these with fs::metadata() probes
   matching the kstop_writable() pattern used by
   can_power_off/can_reboot/can_suspend. No code change yet —
   just the docstring pointing the next maintainer at the pattern.

Without this comment, a future maintainer reading the four
hardcoded 'na' returns would not know about the kstop_writable
probe pattern that enables the matching sleep capabilities.

2 files changed, +32/-5.
2026-07-27 22:03:19 +09:00
vasilito 8fbc113d9f round 14: remove LD_PRELOAD stub + firmware-loader + scheme daemons expect chains + SUPERSEDED-DOC-LOG R11-14
Round 14 audit cleanup. Six coordinated fixes across seven files
plus a documentation log update:

1. local/recipes/system/redbear-wayland-guard/ — REMOVED entirely.
   The directory contained only source/wayland_guard.c — an LD_PRELOAD
   interposer stub for three wl_proxy_* functions — with NO recipe.toml.
   This violated local/AGENTS.md STUB AND WORKAROUND POLICY ('No LD_PRELOAD
   tricks'). The correct null-guard fix lives in libwayland upstream per
   QT6-WAYLAND-NULL8-DIAGNOSIS.md (already covered by Mesa win compat).

2. recipes/system/redbear-wayland-guard — broken symlink cleaned up.

3. local/recipes/AGENTS.md — catalog entry for redbear-wayland-guard was
   wrong (claimed 'Rust' but the code was C LD_PRELOAD). Replaced with
   REMOVED note explaining the policy violation and the correct fix
   location in libwayland.

4. local/recipes/system/firmware-loader/source/src/main.rs — converted
   9 .expect() calls in the daemon init path (Socket::create, scheme_root,
   create_this_scheme_fd, syscall::call_wo notify, setrens, next_request,
   write_response) to Result propagation. get_init_notify_fd() and
   notify_scheme_ready() now return Result; run_daemon() returns Result and
   main() matches on Err to log+exit(1) cleanly. The daemon was
   crashing the entire firmware-delivery subsystem on any init failure;
   now init can fall back or restart the daemon.

5. local/recipes/system/{redbear-keymapd,redbear-ime,redbear-accessibility}/
   source/src/main.rs — three scheme daemons used the same
   Socket::create().expect() + register_sync_scheme().expect() pattern.
   Replaced all six .expect() calls with match expressions that
   log_msg('ERROR', ...) and process::exit(1). Same pattern.

6. local/docs/NETWORKING-AND-DRIVERS-SYSTEMATIC-ASSESSMENT-2026-07-27.md —
   struck through 5 references to the now-removed redbear-wayland-guard
   (line 65 missing-daemons list, line 344 table row, line 397
   implementation list, line 414 source-list, line 797 P3-8 backlog).

7. local/docs/SUPERSEDED-DOC-LOG.md — appended a 'Rounds 11-14 Source-Level
   Supersessions' table logging every lie-grade fix and stale-doc
   strike from this session. Mirrors the original deletion-log style for
   consistency, and gives operators a single place to see what was
   resolved and where. Documents the emerging pattern: lie-grade code in
   Red Bear concentrates in (a) relibc panic-site catch-alls (addressed
   rounds 9-10), (b) scheme daemon init paths using .expect() instead of
   Result (rounds 11-14), (c) Mesa DRM/Wayland stubbing (rounds 12;
   remaining work tracked in 3D-DESKTOP-COMPREHENSIVE-PLAN.md).

Not committed in this commit (operator's parallel work, to be
committed by them):
- driver-manager/* (N-tier edits)
- redbear-sessiond/manager.rs (can_* probe refinements)
- redbear-statusnotifierwatcher/* (recipe + source)
- redbear-dbus-services/* (dbus service cleanup)
- redox-driver-core/manager.rs (test-only)
- Mesa redox_drm_cs.c (CS submit fix)

7 files changed in this commit + 2 deletions.
2026-07-27 21:27:39 +09:00
vasilito 9e317d9f6e local/docs: commit first-round audit + superseded-doc-log
The first-round assessment (NETWORKING-AND-DRIVERS-SYSTEMATIC-
ASSESSMENT-2026-07-27.md) was never committed to the parent 0.3.1
branch. It captures the docs audit that preceded the code audit
(now at NETWORKING-AND-DRIVERS-CODE-ASSESSMENT-2026-07-27.md).
Both files live in the repo as the docs and code halves of the
audit series.

SUPERSEDED-DOC-LOG.md is the change-log file referenced from
local/docs/legacy-obsolete-2026-07-25/SUPERSEDED.md. Previously
untracked; this commit makes it visible to the doc audit trail.
2026-07-27 18:34:25 +09:00