RedBear-OS

Author SHA1 Message Date

Author	SHA1	Message	Date
kellito	827895d32f	build: rewrite C-7 KF6 sed migration script + add 13 tests The C-7 KF6 sed migration script shipped in commit `ae749ffb2` was a stub with three structural problems that made it unrunnable: 1. Called 'repo cook $recipe_dir' with a path, but the cookbook CLI takes bare names — this would have failed with 'Package name invalid' on first run. 2. Step 2 created an empty pristine_dir via mktemp -d but never populated it, so the diff was always empty (zero-byte output, 'no diff' branch taken, no patch written). 3. Step 4 was 'SKIP — manual rewrite pending', so the script wrote no patch even when the inline sed chains actually edited the source. Replace the stub with a working v2 that: - Uses 'repo cook $name' (bare names) throughout - Snapshots source/ → source-pristine/ BEFORE the cook so the pristine state is real, not empty - Runs the full cook (with -i \|\| true so a build failure after the sed step doesn't abort the migration — we only need the post-sed source state) - diffs the real pristine vs post-cook tree, with --exclude='.git' and --exclude='target' so the diff is the actual sed edits - Saves the diff as local/patches/<name>/01-initial-migration.patch with a header explaining provenance and the cookbook_apply_patches invocation the recipe should use - Cleans up source-pristine/ + runs 'repo unfetch $name' so the next migration run starts from a clean slate Add a --dry-run mode that lists candidates without fetching, for safe CI / smoke testing. Add --recipe=<name> and --limit=N for targeted runs. Add --help. Add a test escape hatch via REDBEAR_MIGRATE_RECIPES_DIR and REDBEAR_MIGRATE_PATCHES_DIR env vars so the candidate discovery can be exercised on a synthetic tree without touching the live project. Also gate the cookbook-binary check on DRY_RUN != 1 so --dry-run doesn't require a pre-built ./target/release/repo. 13 unit tests in local/scripts/tests/test_migrate_kf6_seds.py: TestCandidateDiscovery (7): - discovers sed+tar recipe - skips recipe without sed - skips recipe with git source (Rule 1 in-tree, not sed-migration candidates) - --limit=N caps results - --recipe=<name> filters - existing patch triggers SKIP branch (via static analysis) - --help output describes the script TestScriptStructure (6): - regression: uses bare names, not paths - uses release/repo binary - creates patches dir - diff includes .git/target excludes - unfetches after capture - idempotent SKIP when patch exists Test count: 86/86 → 99/99 (all in <1s). The actual migration run still requires the full KF6 dep chain to be built (qtbase, qtdeclarative, kf6-extra-cmake-modules, plus the recipe's own deps). The 56 recipes are now discoverable + scriptable; the recipe-by-recipe verification + patch validity check remains a per-recipe manual step (open the patch, confirm the diff matches the inline sed chain, edit [build].script to call cookbook_apply_patches, re-cook, byte-compare stage.pkgar).	2026-06-12 15:37:58 +03:00
kellito	ae749ffb23	build: ship build-system hardening arc (5 of 10 improvements) The v6.0 build-system hardening arc lands 5 of the 10 improvements proposed in local/docs/BUILD-SYSTEM-IMPROVEMENTS.md. All scripts have unit tests (62 -> 86, all pass in <1s) and the new 'lint-recipe' Gitea Actions job runs on every PR. Per-recipe audit & lint scripts (catch R1/R2 violations BEFORE cook): * audit-patch-idempotency.py — verifies external patches in local/patches/ still apply against the upstream pinned rev. Caught 1 real bug on first run: libdrm/02-redox-dispatch.patch hunk at xf86drm.c:321 no longer matches libdrm-2.4.125. * audit-kf6-deps.py — fetches upstream, scans for find_package(KF6Xxx REQUIRED), compares to recipe deps. Catches missing + dead dependencies in every kf6-* and qt* recipe. * classify-cook-failure.py — 17-rule cook-failure classifier. 10-30s diagnosis vs 5-10min manual. exit code is intentionally inverted (0=novel failure, 1=known fix) for CI signal. * lint-recipe.py — 7-rule recipe lint: R1-NO-PATCH-FILE, R1-PATH-SOURCE, R2-INLINE-SED, R2-PATCHES-DIR-UNUSED, NO-LEGACY-MAKE, R1-LEGACY-APPLY-PATCHES, DEP-NOT-FOUND. 1.1s for 171 recipes (down from 60s+ in v1 via recipe-index precomputation). Strict mode promotes warnings to errors. Build-system convenience: * repair-cook.sh — incremental-build optimizer. Equivalent to 'repo cook <pkg>' but with a fast-path that skips configure when CMakeCache.txt is newer than source AND external patches haven't changed. 30-60s vs 5-10min on KF6 recipes. make repair.<pkg> / make clean-repair.<pkg> targets. * migrate-kf6-seds-to-patches.sh — migration skeleton for converting 56 inline 'sed -i' chains across the KF6 recipes to durable external patches in local/patches/<name>/. Gitea Actions (host-execution, no Docker): * .gitea/workflows/build-system.yml — 8-job pipeline: unit-tests, lint-offline, lint-network (nightly), lint-recipe (NEW), lint-docs, build-mini, build-full, smoke (QEMU boot). * .gitea/RUNNER-SETUP.md — one-time Manjaro/Arch host setup. Build script hardening: * build-redbear.sh — when a low-level source (relibc, kernel, base, bootloader, installer) is newer than its pkgar, clean build/ and sysroot/ across all recipes too. Low-level package changes leave autotools packages (pcre2, gettext, libiconv, ...) with stale configure/libtool scripts referencing the old runtime, causing 'libtool version mismatch' and 'not a valid libtool object' errors. Cleaning forces re-configuration; stage/ and source/ are preserved so the cookbook skips unchanged packages that don't use autotools. * Makefile — wire lint-cook-failure, lint-cook-failure-explain, lint-recipe, lint-recipe.%, lint-recipe.strict, lint-recipe.%.strict, repair.%, clean-repair.%, test-lint-scripts[-quiet]. Replace the legacy 'validate-patches' target with a deprecation notice pointing at validate-sources. Documentation: * BUILD-SYSTEM-IMPROVEMENTS.md — mark #2 and #5 DONE; full implementation notes; updated Make-targets table. * BUILD-SYSTEM-V6-HARDENING-POSTMORTEM.md (NEW) — 226-line durable record of the 8-session arc: 32 findings categorized, 5 P0 audit-script bugs fixed, 6 over-broad multi-pattern rules discovered + fixed, test coverage 86/86 in <1s, 7/10 improvements DONE. * SCRIPT-BEHAVIOR-MATRIX.md — apply-patches.sh row marked LEGACY/ARCHIVED; build-redbear.sh row no longer claims to call it. * boot-logs/README.md (NEW) — frozen-evidence policy: 'do not edit' rule for REDBEAR-FULL-BOOT--RESULTS.md files. libdrm/02-redox-dispatch.patch.README (NEW) — 8-step regen procedure for the broken hunk. Cleanup: * local/cache/README.md deleted (1-line placeholder). * legacy 'make validate-patches' target removed. Per build-system improvement #5: lint-recipe.py's first run on the live tree surfaced 1 broken-patch reference (redbear-sessiond), 1 dangling cookbook_apply_patches call (tc), 19 sed -i calls in sddm (warning — cookbook_apply_patches present, drop-x11.py migration in progress), 4 sed -i calls in qt6-wayland-smoke (uncovers the same bug class the libwayland fix prevented).	2026-06-12 13:37:39 +03:00

kellito

827895d32f

build: rewrite C-7 KF6 sed migration script + add 13 tests

The C-7 KF6 sed migration script shipped in commit ae749ffb2
was a stub with three structural problems that made it
unrunnable:
  1. Called 'repo cook $recipe_dir' with a path, but the
     cookbook CLI takes bare names — this would have failed
     with 'Package name invalid' on first run.
  2. Step 2 created an empty pristine_dir via mktemp -d but
     never populated it, so the diff was always empty
     (zero-byte output, 'no diff' branch taken, no patch
     written).
  3. Step 4 was 'SKIP — manual rewrite pending', so the
     script wrote no patch even when the inline sed chains
     actually edited the source.

Replace the stub with a working v2 that:
  - Uses 'repo cook $name' (bare names) throughout
  - Snapshots source/ → source-pristine/ BEFORE the cook
    so the pristine state is real, not empty
  - Runs the full cook (with -i || true so a build failure
    after the sed step doesn't abort the migration — we
    only need the post-sed source state)
  - diffs the real pristine vs post-cook tree, with
    --exclude='.git' and --exclude='target' so the diff
    is the actual sed edits
  - Saves the diff as
    local/patches/<name>/01-initial-migration.patch with
    a header explaining provenance and the cookbook_apply_patches
    invocation the recipe should use
  - Cleans up source-pristine/ + runs 'repo unfetch $name' so
    the next migration run starts from a clean slate

Add a --dry-run mode that lists candidates without fetching,
for safe CI / smoke testing. Add --recipe=<name> and
--limit=N for targeted runs. Add --help.

Add a test escape hatch via REDBEAR_MIGRATE_RECIPES_DIR and
REDBEAR_MIGRATE_PATCHES_DIR env vars so the candidate
discovery can be exercised on a synthetic tree without
touching the live project. Also gate the cookbook-binary
check on DRY_RUN != 1 so --dry-run doesn't require a
pre-built ./target/release/repo.

13 unit tests in local/scripts/tests/test_migrate_kf6_seds.py:
  TestCandidateDiscovery (7):
    - discovers sed+tar recipe
    - skips recipe without sed
    - skips recipe with git source (Rule 1 in-tree, not
      sed-migration candidates)
    - --limit=N caps results
    - --recipe=<name> filters
    - existing patch triggers SKIP branch (via static analysis)
    - --help output describes the script
  TestScriptStructure (6):
    - regression: uses bare names, not paths
    - uses release/repo binary
    - creates patches dir
    - diff includes .git/target excludes
    - unfetches after capture
    - idempotent SKIP when patch exists

Test count: 86/86 → 99/99 (all in <1s).

The actual migration run still requires the full KF6 dep
chain to be built (qtbase, qtdeclarative, kf6-extra-cmake-modules,
plus the recipe's own deps). The 56 recipes are now
discoverable + scriptable; the recipe-by-recipe verification
+ patch validity check remains a per-recipe manual step
(open the patch, confirm the diff matches the inline sed
chain, edit [build].script to call cookbook_apply_patches,
re-cook, byte-compare stage.pkgar).

2026-06-12 15:37:58 +03:00

kellito

ae749ffb23

build: ship build-system hardening arc (5 of 10 improvements)

The v6.0 build-system hardening arc lands 5 of the 10 improvements
proposed in local/docs/BUILD-SYSTEM-IMPROVEMENTS.md. All scripts
have unit tests (62 -> 86, all pass in <1s) and the new 'lint-recipe'
Gitea Actions job runs on every PR.

Per-recipe audit & lint scripts (catch R1/R2 violations BEFORE cook):
  * audit-patch-idempotency.py  — verifies external patches in
    local/patches/ still apply against the upstream pinned rev.
    Caught 1 real bug on first run: libdrm/02-redox-dispatch.patch
    hunk at xf86drm.c:321 no longer matches libdrm-2.4.125.
  * audit-kf6-deps.py           — fetches upstream, scans for
    find_package(KF6Xxx REQUIRED), compares to recipe deps. Catches
    missing + dead dependencies in every kf6-* and qt* recipe.
  * classify-cook-failure.py    — 17-rule cook-failure classifier.
    10-30s diagnosis vs 5-10min manual. exit code is intentionally
    inverted (0=novel failure, 1=known fix) for CI signal.
  * lint-recipe.py              — 7-rule recipe lint: R1-NO-PATCH-FILE,
    R1-PATH-SOURCE, R2-INLINE-SED, R2-PATCHES-DIR-UNUSED,
    NO-LEGACY-MAKE, R1-LEGACY-APPLY-PATCHES, DEP-NOT-FOUND.
    1.1s for 171 recipes (down from 60s+ in v1 via recipe-index
    precomputation). Strict mode promotes warnings to errors.

Build-system convenience:
  * repair-cook.sh              — incremental-build optimizer.
    Equivalent to 'repo cook <pkg>' but with a fast-path that
    skips configure when CMakeCache.txt is newer than source AND
    external patches haven't changed. 30-60s vs 5-10min on KF6
    recipes. make repair.<pkg> / make clean-repair.<pkg> targets.
  * migrate-kf6-seds-to-patches.sh — migration skeleton for
    converting 56 inline 'sed -i' chains across the KF6 recipes
    to durable external patches in local/patches/<name>/.

Gitea Actions (host-execution, no Docker):
  * .gitea/workflows/build-system.yml — 8-job pipeline:
    unit-tests, lint-offline, lint-network (nightly),
    lint-recipe (NEW), lint-docs, build-mini, build-full,
    smoke (QEMU boot).
  * .gitea/RUNNER-SETUP.md — one-time Manjaro/Arch host setup.

Build script hardening:
  * build-redbear.sh            — when a low-level source (relibc,
    kernel, base, bootloader, installer) is newer than its pkgar,
    clean build/ and sysroot/ across all recipes too. Low-level
    package changes leave autotools packages (pcre2, gettext,
    libiconv, ...) with stale configure/libtool scripts referencing
    the old runtime, causing 'libtool version mismatch' and
    'not a valid libtool object' errors. Cleaning forces
    re-configuration; stage/ and source/ are preserved so the
    cookbook skips unchanged packages that don't use autotools.
  * Makefile                    — wire lint-cook-failure,
    lint-cook-failure-explain, lint-recipe, lint-recipe.%,
    lint-recipe.strict, lint-recipe.%.strict, repair.%,
    clean-repair.%, test-lint-scripts[-quiet]. Replace the
    legacy 'validate-patches' target with a deprecation notice
    pointing at validate-sources.

Documentation:
  * BUILD-SYSTEM-IMPROVEMENTS.md   — mark #2 and #5 DONE; full
    implementation notes; updated Make-targets table.
  * BUILD-SYSTEM-V6-HARDENING-POSTMORTEM.md (NEW) — 226-line durable
    record of the 8-session arc: 32 findings categorized, 5 P0
    audit-script bugs fixed, 6 over-broad multi-pattern rules
    discovered + fixed, test coverage 86/86 in <1s, 7/10
    improvements DONE.
  * SCRIPT-BEHAVIOR-MATRIX.md   — apply-patches.sh row marked
    LEGACY/ARCHIVED; build-redbear.sh row no longer claims to
    call it.
  * boot-logs/README.md (NEW)   — frozen-evidence policy:
    'do not edit' rule for REDBEAR-FULL-BOOT-*-RESULTS.md files.
  * libdrm/02-redox-dispatch.patch.README (NEW) — 8-step regen
    procedure for the broken hunk.

Cleanup:
  * local/cache/README.md deleted (1-line placeholder).
  * legacy 'make validate-patches' target removed.

Per build-system improvement #5: lint-recipe.py's first run on
the live tree surfaced 1 broken-patch reference (redbear-sessiond),
1 dangling cookbook_apply_patches call (tc), 19 sed -i calls in
sddm (warning — cookbook_apply_patches present, drop-x11.py
migration in progress), 4 sed -i calls in qt6-wayland-smoke
(uncovers the same bug class the libwayland fix prevented).

2026-06-12 13:37:39 +03:00

2 Commits