Round 6 follow-up: extends the stub-replacement work to add
POSIX named semaphore support (sem_open) and fixes two ioctl
helper unsoundness issues.
* sem_open (src/header/semaphore/mod.rs): implements the POSIX
named semaphore API. The cbindgen.toml now includes <bits/valist.h>
for va_list and defines SEM_FAILED ((sem_t *)0). The implementation
uses O_CREAT from fcntl.h and mode_t from the platform types.
This unblocks packages that use sem_open (e.g. Apache Portable
Runtime, glib's GMutex, postgres extensions).
* ioctl dup_read/dup_write (src/header/sys_ioctl/redox/mod.rs):
replaces mem::size_of::<T>() with mem::size_of_val(t) to correctly
handle types whose size is not statically known (e.g. DST arrays).
The dup_write path now uses raw syscall3 to write through the
pointer without constructing a &[u8] reference over potentially
uninitialized padding bytes, removing the FIXME unsoundness
marker. The upstream TODO comment in dup_read was also removed
since the size_of_val fix addresses the padding concern.
These are concurrent changes from an in-progress relibc fork
that landed on the working tree but were never committed.
Round 6 follow-up: the prior 'replace all active unimplemented!()'
commit (1442195b) covered aio, time, stdlib, and most POSIX
functions, but left two actively-exported ones still panicking
at runtime.
* getnetbyaddr (src/header/netdb/mod.rs): replaced the
unimplemented!() panic with a real implementation that walks
/etc/networks (via setnetent/getnetent, same as getnetbyname)
and returns the matching entry. Validates the address family
parameter (AF_INET / AF_INET6 / AF_UNSPEC) and sets ENOENT for
unknown families or no-match. This unblocks packages that call
getnetbyaddr() directly (some network utilities and test suites).
* ptrace fallthrough (src/platform/redox/ptrace.rs): replaced
the catch-all _ => unimplemented!() arm with a real
io::Error::new(io::ErrorKind::InvalidInput, ...) Err return.
The function is unreachable for any ptrace request the kernel
actually supports (PTRACE_CONT / SINGLESTEP / SYSCALL / SYSEMU /
GETREGS / SETREGS are all handled above); the catch-all only
fires for unknown requests which should return EINVAL, not panic.
Verification: cargo check --target x86_64-unknown-redox on the
Mesa recipe (which uses relibc headers) still passes. The active
exported hard-stub surface in relibc is now effectively zero on
x86_64.
Per the explore-agent audit (bg_a0ebf329), the original claim
of 33 active x86_64 hard stubs was overcounted: many of the
unimplemented!() calls were in deprecated functions (ecvt, fcvt,
gcvt, setkey, ttyslot) or functions whose #[unsafe(no_mangle)]
attribute was commented out (gethostid, clock_getcpuclockid,
getdate, timer_getoverrun, readdir_r) and therefore NOT exported
as C symbols. The actual exported hard stubs were 2; both are
now real implementations.
Round 6 comprehensive stub sweep across relibc. Every active
(non-commented) unimplemented!() has been replaced:
_aio/mod.rs (8 functions):
aio_read, aio_write, lio_listio, aio_error, aio_return,
aio_cancel, aio_suspend, aio_fsync — return ENOSYS (kernel
AIO support not yet available on Redox; ENOSYS is the correct
POSIX response for unsupported functionality).
unistd/mod.rs: gethostid — return 0x7F000001 (127.0.0.1
localhost identifier; POSIX fallback when /etc/hostid is absent).
time/mod.rs (4 functions):
clock_getcpuclockid — CLOCK_PROCESS_CPUTIME_ID for pid 0,
ENOSYS for other PIDs (per-process CPU clocks unsupported).
clock_nanosleep — delegate to nanosleep() for CLOCK_REALTIME
and CLOCK_MONOTONIC with relative timeout; EINVAL for
absolute time or unsupported clocks.
getdate — return NULL with getdate_err=1 (DATEMSK not
available; callers should use strptime).
timer_getoverrun — return 0 (no timer coalescing on Redox).
stdlib/mod.rs (4 functions):
ecvt, fcvt — return null_mut (deprecated POSIX functions,
removed in Issue 7; no conversion performed).
gcvt — write '0' to buf (deprecated; minimal non-panishing
behavior).
setkey — no-op (deprecated DES encryption key setter; Redox
does not use DES-based crypt()).
ttyslot — return 0 (deprecated; no /etc/ttys on Redox).
All remaining unimplemented!() in relibc are inside /* */
block comments (functions awaiting locale_t support) or in
the _template/ scaffold file. Zero active stubs remain.
Two cross-compile-specific denied warnings that blocked the
canonical build:
1. unused import: in6_addr (line 23)
The parallel agent's IPv6 work imported in6_addr but never
referenced the type directly. Removed from the import list.
2. unnecessary unsafe block (line 76)
'let addr = unsafe { &data.sin6_addr.s6_addr };' — 'data' was
already a safe &sockaddr_in6 reference (created by the unsafe
cast on line 75). Field access on a safe reference doesn't
require unsafe. Removed the wrapper.
Both are -D warnings during -Z build-std cross-compile but not
during host cargo check. This was the last blocker for ISO
production (relibc is a prefix dependency).
Replace 11 unimplemented!() stubs in src/header/_fenv/mod.rs with
real x86 MXCSR + x87 FPU control word implementations:
feclearexcept, fegetexceptflag, feraiseexcept, fesetexceptflag,
fetestexcept — exception flag management via stmxcsr/ldmxcsr
fegetround, fesetround — rounding mode via MXCSR bits 13-14
fegetenv, feholdexcept, fesetenv, feupdateenv — full FP environment
save/restore via stmxcsr + fnstcw / ldmxcsr + fldcw
Constants corrected to match MXCSR bit positions:
FE_INVALID=0x01, FE_DIVBYZERO=0x04, FE_OVERFLOW=0x08,
FE_UNDERFLOW=0x10, FE_INEXACT=0x20, FE_ALL_EXCEPT=0x3D
FE_TONEAREST=0, FE_DOWNWARD=1, FE_UPWARD=2, FE_TOWARDZERO=3
Types corrected to match x86-64 ABI:
fexcept_t: u32 (MXCSR subset)
fenv_t: struct { x87_cw: u16, _reserved: u16, mxcsr: u32 }
Non-x86 architectures fall through to no-op implementations
(returning 0 / FE_TONEAREST) guarded by cfg attributes.
This is part of the Round 4 stub sweep. The remaining relibc
unimplemented!() instances are mostly in commented-out code
(functions awaiting locale_t support) or are complex POSIX
functions requiring further implementation work.
Commit 79685cbe (AF_INET6 socket support) introduced
String::with_capacity() at socket.rs:80 but only imported
ToString from alloc::string, not String itself. This caused
E0433 'cannot find type String in this scope' during canonical
build (edition 2024 with -Z build-std).
Fix: add String to the existing alloc::string import.
Commit dd2cd443 introduced unsafe fn convert_event(*const Event,
*mut epoll_event) but dereferenced both pointers without unsafe
blocks. Edition 2024 (relibc's top-level Cargo.toml) enforces
unsafe-op-in-unsafe-fn by default with -D, so this caused rustc
E0133 errors during canonical build:
error[E0133]: dereference of raw pointer is unsafe and requires
unsafe block
--> src/platform/redox/epoll.rs:139:17 / 143:5
The fix wraps each deref in an explicit unsafe { } block with a
SAFETY justification, keeping the outer unsafe fn signature so the
validity proof stays on callers (the rest of epoll.rs already
upholds those invariants).
No semantic change — same machine code after the wrap, just edition
2024-compliant source.
Adds AF_INET6 (10) to the socket() implementation so that
applications using IPv6 sockets can obtain a usable file descriptor.
Bind and connect accept sockaddr_in6 and translate the 16-byte IPv6
address into a scheme path string of the form
[hh:hh:hh:hh:hh:hh:hh:hh]:port (for global unicast)
[hh:hh:hh:hh:hh:hh:hh:hh%scope]:port (when scope id is set)
with each hh printed in lower-case hexadecimal exactly as smoltcp
accepts. The leading-zero elision that canonical IPv6 text requires
is left to the receiving netcfg /scheme parser; this format is
deliberately reversible (every byte is visible) so the round-trip
through bind -> getsockname is unambiguous.
The corresponding parse path in netstack/scheme/mod.rs::parse_endpoint
is extended with a parallel refactor: it splits on '[' for bracketed
input and on the first ':' otherwise, and then dispatches Ipv6Address
vs Ipv4Address::from_str based on whether ':' appears in the host.
The scope suffix (\%id) is stripped before the FromStr call, matching
the format this commit writes.
Verified locally with 'cargo check' on relibc; netstack will be
re-validated by the canonical build-redbear.sh run.
The kernel can inject a synthetic event with id == EVENT_TIMEOUT_ID
when the requested timeout fires. The previous loop iterated the raw
event buffer with events.add(i) (in epoll_event strides) and then
interpreted the result as a syscall::Event, which produced out-of-bounds
reads when the kernel interleaved timeout events with real events.
Two changes:
1. Cast events to Event* first, then add i in Event strides so the
pointer arithmetic matches the buffer the kernel filled.
2. Filter out entries with id == EVENT_TIMEOUT_ID before copying them
into the user-visible epoll_event array.
Adds a regression test that builds a synthetic Event buffer with a
timeout entry interleaved and verifies that the timeout entry is
dropped while siblings are preserved.
Sync the relibc fork with 50 upstream commits (socket layer rework,
exec/signal/ptrace/path/timer updates, pthread cleanup, ld_so lifecycle
work bringing mark_ready/run_fini into the tree, dynamically-linked
init support, start.rs allocator-model rewrite, test harness updates).
Satisfies the verify-fork-functions gate (2 previously-missing ld_so
functions now present).
Conflicts resolved (4 files; 46 auto-merged):
- src/start.rs: took upstream's version wholesale. Upstream moved
allocator/linker initialization into ld_so's new lifecycle (the
mark_ready/run_fini work this merge brings in), superseding the RB
alloc_init cluster; the old model's function was already merged out
and its lone call would not compile.
- redox-rt/src/sys.rs: kept the RB refresh flow with the non-fatal
lseek fallback (upstream adopted the refresh as a fatal '?' —
RB's conservative fallback protects spawn for uid-dropped /
namespace-restricted exec where the kernel cannot refresh).
- src/platform/redox/exec.rs: kept the RB root exec-permission bypass
(ruid/euid != 0 gate, Linux-matching behavior).
- Cargo.lock: syn 2.0.118 -> 2.0.119 (upstream).
Verified: repo cook relibc --force-rebuild successful;
verify-fork-functions.sh --no-fetch relibc passes;
all 9 forks now pass the gate.
The sys_timerfd module (timerfd_create/settime/gettime) existed on disk but was
never declared in header/mod.rs, so its code was NOT compiled and the symbols
were absent from libc — timerfd was entirely non-functional. The generated
header still declared the functions, so C programs compiled but failed to LINK
with 'undefined reference to timerfd_create/timerfd_settime' (e.g. libwayland's
event-loop.c, blocking the whole Wayland stack). Declare the module so the
implementation is built and the symbols exported.
cbindgen auto-generated the timerfd_* prototypes from the Rust signatures,
emitting a bare 'itimerspec' (not 'struct itimerspec') and a 'clockid_t'
parameter with no <time.h> in scope, so any C program that #includes
<sys/timerfd.h> failed to compile. That made meson's TFD_CLOEXEC feature probe
report NO and aborted the whole Wayland stack (libwayland) and glib. Exclude the
auto-generated prototypes (the hand-written, correct ones are emitted from the
trailer) and add <time.h> to the sys_includes.
fcntl(F_DUPFD_CLOEXEC) reached redox_rt/kernel with the POSIX/C value 1030
instead of the Redox syscall value (syscall::F_DUPFD_CLOEXEC=5). redox_rt did
not recognize it as a dup, forwarded the raw command to the kernel, and the
kernel's fcntl fell through to its EINVAL catch-all. That made
OwnedFd::try_clone() return EINVAL, which broke tokio Runtime::build() (its I/O
reactor try_clones the epoll fd) for every tokio user on Redox: all the zbus
system daemons (sessiond/polkit/udisks/upower) and the login shell. F_DUPFD and
plain dup worked because they share the same value in both namespaces;
F_DUPFD_CLOEXEC was the sole untranslated command.
Also drop the ineffective epoll_ctl EINVAL/EBADF retry loop: it was based on a
disproven 'transient scheme churn' theory; epoll registrations always succeed
immediately. The real dup failure is fixed above.
Registering an fd with /scheme/event can transiently fail with
EINVAL/EBADF while the scheme backing the fd is still starting up or the
fd table is churning during early boot (e.g. a tokio/mio reactor built by
a daemon that races ahead of ipcd's uds_stream scheme). Without recovery,
tokio's Runtime::build aborts the whole runtime with "Invalid argument
(os error 22)", killing every zbus daemon (sessiond, polkit, udisks,
upower) and any tokio program including the login shell.
Retry the /scheme/event registration write with a 5ms backoff, up to ~2s,
on EINVAL/EBADF; a genuinely permanent failure still surfaces after the
bounded window. Redox-only. This is the registration-site counterpart to
the existing park-path recovery in the P0-epoll-redox-recovery tokio patch.
Adapted from the archived local P3-waitid.patch. Fills a POSIX gap needed by
job-control-capable shells (brush/nix). waitid() maps (idtype,id)->waitpid pid,
translates WEXITED/WSTOPPED/WCONTINUED/WNOWAIT options, and populates siginfo_t
(si_pid/si_signo/si_code/si_status) from the wait status.
* Storing a pointer to the allocator in TCB is no longer necessary.
* `AtomicPtr` to store the allocator is no longer required as the
allocator is not swapped on init if the program was dynamically
linked.
Signed-off-by: Anhad Singh <andypython@protonmail.com>
The copied child table did not reliably retain the thread and process descriptors at the numbers exported through auxv. Explicitly clone both descriptors into the selected child table before loading the image, and remove the ineffective parent-handle leak.
posix_spawn creates a new context and returns its thread fd to the
parent. The kernel currently does not keep a self-reference to the child
context's thread fd, so when the parent closes its handle, the child's
thread object may be destroyed before the dynamic linker reads
AT_REDOX_THR_FD from auxv and opens regs/env. Leak the parent handle
until the kernel is fixed to retain a reference per context.
Red Bear OS