From fbdd6e36e0bad67f602f19d88ddc7739c62f1b0f Mon Sep 17 00:00:00 2001 From: vasilito Date: Fri, 24 Jul 2026 23:38:09 +0900 Subject: [PATCH] docs: correct v4.1 AER-dispatch phrasing in driver-manager plan MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Self-review found the v4.1 update's AER row claimed 'Driver::on_error → RecoveryAction on bound devices is now end-to-end rather than discarded.' That is misleading: DriverConfig does not override Driver::on_error (the trait method keeps its default Ok(Handled) impl), so the trait callback is never invoked. The v4.1 fix wires manager-level auto-dispatch (AER event → route_to_driver → dispatch_recovery), not driver-level on_error IPC. The driver-IPC item remains open. Reword the row to say manager-level dispatch and note that Driver::on_error IPC is a separate item. --- local/docs/DRIVER-MANAGER-MIGRATION-PLAN.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local/docs/DRIVER-MANAGER-MIGRATION-PLAN.md b/local/docs/DRIVER-MANAGER-MIGRATION-PLAN.md index 45df7752c9..0908669e46 100644 --- a/local/docs/DRIVER-MANAGER-MIGRATION-PLAN.md +++ b/local/docs/DRIVER-MANAGER-MIGRATION-PLAN.md @@ -91,7 +91,7 @@ declared open, and adds a driver-by-driver audit. Commit `31bbe2fa12`. | P3 item (v4.0) | v4.1 resolution | |---|---| | Quirk lifecycle phases (`phase = "early"|"enable"`) | Driver probe consults `QuirkPhase::Early` before channel open; gates `WRONG_CLASS` / `BROKEN_BRIDGE` → `NotSupported`. PM phases remain out of scope (plan § P3). | -| AER recovery dispatch to bound drivers | Auto-dispatch wired: `unified_events::Aer` → `route_to_driver` → `dispatch_recovery` (shared with `/recover` scheme endpoint). `RecoveryAction::Handled`/`Fatal` are no-ops; `ResetDevice`/`RescanBus` execute. | +| AER recovery dispatch to bound drivers | Manager-level auto-dispatch wired: `unified_events::Aer` → `route_to_driver` → `dispatch_recovery` (shared with `/recover` scheme endpoint). `RecoveryAction::Handled`/`Fatal` are no-ops; `ResetDevice`/`RescanBus` execute. **Not** the `Driver::on_error` trait callback (which `DriverConfig` does not override) — that's a separate driver-IPC item, still open. | | Per-vendor firmware packaging | `fetch-firmware.sh` already supports `--vendor {amd,intel} --subset {all,rdna,dmc,wifi,bluetooth}`; the linux-firmware-split per-vendor recipe split is a packaging decision deferred to C4 (no correctness gap). | Plus an honest-absence fix in `redox-driver-core::modern_technology`: