From f9b96f871b1659cf6a9eff339758a19f616ef306 Mon Sep 17 00:00:00 2001 From: vasilito Date: Thu, 9 Jul 2026 21:26:06 +0300 Subject: [PATCH] =?UTF-8?q?kf6-solid:=20fix=20final=20#error=20stub=20?= =?UTF-8?q?=E2=80=94=20SATA/IDE=20bus=20detection=20on=20Redox?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The fourth and final #error stub in udisksstoragedrive.cpp was in the bus() function's ATA SATA-vs-IDE detection block. On non-Linux platforms without udev, this fell through to #error. Fix: add Q_OS_REDOX guard returning Solid::StorageDrive::Sata. Redox doesn't have IDE on modern machines; all ata-connected drives return Solid::StorageDrive::Sata. The ConnectionBus from UDisks2 D-Bus is sufficient for the bus type detection upstream. All 4 KF6Solid #error stubs are now resolved: - isHotpluggable() → Q_OS_REDOX: returns isRemovable() - bus() udevBus → Q_OS_REDOX: uses ConnectionBus from device - bus() ATA → Q_OS_REDOX: defaults to Sata - isAppendable() → Q_OS_REDOX: returns false (no optical) --- .../src/solid/devices/backends/udisks2/udisksstoragedrive.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/local/recipes/kde/kf6-solid/source/src/solid/devices/backends/udisks2/udisksstoragedrive.cpp b/local/recipes/kde/kf6-solid/source/src/solid/devices/backends/udisks2/udisksstoragedrive.cpp index 429f99a620..6e898dd36d 100644 --- a/local/recipes/kde/kf6-solid/source/src/solid/devices/backends/udisks2/udisksstoragedrive.cpp +++ b/local/recipes/kde/kf6-solid/source/src/solid/devices/backends/udisks2/udisksstoragedrive.cpp @@ -122,6 +122,10 @@ Solid::StorageDrive::Bus StorageDrive::bus() const } else { // parallel (classical) ATA return Solid::StorageDrive::Ide; } +#elif defined(Q_OS_REDOX) + // On Redox, ConnectionBus from UDisks2 is sufficient; default to SATA + // for ata-connected drives since Redox doesn't have IDE on modern machines. + return Solid::StorageDrive::Sata; #else #error Implement this or stub this out for your platform #endif