From ecdcefba69f8b073ecb9d2b26607a29894ae8932 Mon Sep 17 00:00:00 2001 From: bjorn3 <17426603+bjorn3@users.noreply.github.com> Date: Tue, 23 Jan 2024 15:45:44 +0100 Subject: [PATCH] Clarify message_address argument names --- pcid/src/pci/msi.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pcid/src/pci/msi.rs b/pcid/src/pci/msi.rs index a92351151a..96ab83e915 100644 --- a/pcid/src/pci/msi.rs +++ b/pcid/src/pci/msi.rs @@ -352,11 +352,11 @@ pub mod x86_64 { } // TODO: should the reserved field be preserved? - pub const fn message_address(destination_id: u8, rh: bool, dm: bool) -> u32 { + pub const fn message_address(destination_id: u8, redirect_hint: bool, dest_mode_logical: bool) -> u32 { 0xFEE0_0000u32 | ((destination_id as u32) << 12) - | ((rh as u32) << 3) - | ((dm as u32) << 2) + | ((redirect_hint as u32) << 3) + | ((dest_mode_logical as u32) << 2) } pub const fn message_data(trigger_mode: TriggerMode, level_trigger_mode: LevelTriggerMode, delivery_mode: DeliveryMode, vector: u8) -> u32 { ((trigger_mode as u32) << 15)