diff --git a/local/docs/3D-DESKTOP-COMPREHENSIVE-PLAN.md b/local/docs/3D-DESKTOP-COMPREHENSIVE-PLAN.md index 84394bd66b..b352175393 100644 --- a/local/docs/3D-DESKTOP-COMPREHENSIVE-PLAN.md +++ b/local/docs/3D-DESKTOP-COMPREHENSIVE-PLAN.md @@ -1156,8 +1156,8 @@ Per `bg_3239014a` audit. **All deletions require backup to | File | Issue | Fix | |------|-------|-----| -| `config/redbear-wifi-experimental.toml` line 9 | `include = ["redbear-minimal.toml"]` — typo. File doesn't exist | Replace `minimal` with `mini` | -| `config/redbear-bluetooth-experimental.toml` line 10 | Same typo | Same fix | +| `config/redbear-wifi-experimental.toml` line 9 | ~~`include = ["redbear-minimal.toml"]` — typo~~ ✅ FIXED 2026-07-27 — now `include = ["redbear-mini.toml"]` | Done | +| `config/redbear-bluetooth-experimental.toml` line 10 | ~~Same typo~~ ✅ FIXED 2026-07-27 — same | Done | | `config/redbear-device-services.toml` | 1,137 lines with ~14x duplication of 4 firmware-fallback TOML blobs | Deduplicate to ~200 lines | --- diff --git a/local/docs/NETWORKING-AND-DRIVERS-CODE-ASSESSMENT-2026-07-27.md b/local/docs/NETWORKING-AND-DRIVERS-CODE-ASSESSMENT-2026-07-27.md index c95ada08cd..97334370a0 100644 --- a/local/docs/NETWORKING-AND-DRIVERS-CODE-ASSESSMENT-2026-07-27.md +++ b/local/docs/NETWORKING-AND-DRIVERS-CODE-ASSESSMENT-2026-07-27.md @@ -82,7 +82,7 @@ This is the canonical **CODE-focused** systematic assessment of every networking 14. ~~**CRITICAL: Two config files reference non-existent `redbear-minimal.toml`**~~ — **RESOLVED 2026-07-27**: `redbear-wifi-experimental.toml:9` and `redbear-bluetooth-experimental.toml:10` now both read `include = ["redbear-mini.toml"]`. See 3D-DESKTOP-COMPREHENSIVE-PLAN.md § config-table for the post-fix state. -15. **CRITICAL: `redbear-passwd/recipe.toml` has no `[source]` section** — cookbook cannot find source code. +15. ~~**CRITICAL: `redbear-passwd/recipe.toml` has no `[source]` section**~~ — **RESOLVED 2026-07-27** (commit a9e1c34e27): `[source] path = "source"` added. ### 1.2 Critical Path Hierarchy @@ -108,8 +108,8 @@ P1 — Error Handling & FFI Safety (1-2 weeks) P2 — Test Coverage & Build Configuration (2-3 weeks) ├── Add unit tests for TCP scheme, Router, EthernetLink, BufferPool ├── Add tests for STP, SLAAC, DHCP, NIC drivers -├── Fix redbear-wifi-experimental.toml / redbear-bluetooth-experimental.toml include path -├── Add [source] section to redbear-passwd/recipe.toml +├── ~~Fix redbear-wifi-experimental.toml / redbear-bluetooth-experimental.toml include path~~ ✅ RESOLVED 2026-07-27 +├── ~~Add [source] section to redbear-passwd/recipe.toml~~ ✅ RESOLVED 2026-07-27 ├── Fix recipe.toml version mismatches (0.1.0 → 0.3.1) └── Fix dhcpd Cargo.toml version 0.0.0 ``` @@ -509,10 +509,10 @@ include = ["redbear-mini.toml"] **File:** `config/redbear-bluetooth-experimental.toml:10` Same fix: `include = ["redbear-mini.toml", "redbear-bluetooth-services.toml"]`. -#### Finding 19 — CRITICAL: redbear-passwd recipe.toml missing [source] +#### Finding 19 — ~~CRITICAL: redbear-passwd recipe.toml missing [source]~~ **RESOLVED 2026-07-27** **File:** `local/recipes/system/redbear-passwd/recipe.toml` -**Defect:** No `path = "source"`. Cookbook can't find source. -**Fix:** Add `[source] path = "source"`. +**Original defect:** No `path = "source"`. Cookbook couldn't find source. +**Fix applied:** `[source] path = "source"` added (commit a9e1c34e27). #### Finding 32 — CRITICAL: redbear-device-services.toml has 14× firmware fallback duplication **File:** `config/redbear-device-services.toml` (~1137 lines) @@ -715,8 +715,8 @@ See also §7 of previous docs-assessment. - **WifiCtlScheme: Key handle 0o200** (privacy) - **redbear-dnsd: Arc> for shared cache** (correctness) - **openssh recipe: implement IPv6 properly** (no IPv4-only sed) -- **redbear-passwd recipe: add [source]** (build) -- **Config files: fix redbear-minimal.toml → redbear-mini.toml** (build) +- ~~**redbear-passwd recipe: add [source]**~~ ✅ RESOLVED 2026-07-27 +- ~~**Config files: fix redbear-minimal.toml → redbear-mini.toml**~~ ✅ RESOLVED 2026-07-27 --- @@ -756,9 +756,9 @@ See also §7 of previous docs-assessment. | P0-9 | firmware-loader expect→match | firmware-loader | CRITICAL | 2 hours | | P0-10 | btctl remove .exists() pre-check | btctl | CRITICAL | 15 min | | P0-11 | WifiCtlScheme Key handle 0o200 | wifictl | CRITICAL | 5 min | -| P0-12 | Fix redbear-wifi-experimental.toml include | config | CRITICAL | 1 min | -| P0-13 | Fix redbear-bluetooth-experimental.toml include | config | CRITICAL | 1 min | -| P0-14 | Add [source] to redbear-passwd recipe.toml | config | CRITICAL | 5 min | +| P0-12 | ~~Fix redbear-wifi-experimental.toml include~~ ✅ RESOLVED 2026-07-27 | config | — | — | +| P0-13 | ~~Fix redbear-bluetooth-experimental.toml include~~ ✅ RESOLVED 2026-07-27 | config | — | — | +| P0-14 | ~~Add [source] to redbear-passwd recipe.toml~~ ✅ RESOLVED 2026-07-27 | config | — | — | | P0-15 | Add bounds checks to e1000d/rtl8139d/rtl8168d MMIO | drivers | HIGH | 1 hour | | P0-16 | Replace panic! on failed BAR lookup | drivers | HIGH | 1 hour | | P0-17 | dnsd unsafe mut → AtomicU16 | dnsd | CRITICAL | 1 hour | @@ -920,7 +920,7 @@ A P0/P1/P2/P3 item is **signed off** when: | C-20 | `local/recipes/system/redbear-dnsd/source/src/main.rs:83-125` | Loopback listener has no shared cache | | C-21 | ~~`config/redbear-wifi-experimental.toml:9`~~ | **RESOLVED** — now `include = ["redbear-mini.toml"]` | | C-22 | ~~`config/redbear-bluetooth-experimental.toml:10`~~ | **RESOLVED** — same | -| C-23 | `local/recipes/system/redbear-passwd/recipe.toml` | Missing [source] section entirely | +| C-23 | ~~`local/recipes/system/redbear-passwd/recipe.toml`~~ | ~~Missing [source] section entirely~~ ✅ RESOLVED 2026-07-27 | | C-24 | `config/redbear-device-services.toml:1-1137` | Firmware fallback blocks duplicated ~14 times | ### 11.2 HIGH Findings Index (Top 30)