Update hardware utilities and USB validation

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
2026-04-17 00:04:08 +01:00
parent 054acba072
commit d20d44df15
7 changed files with 583 additions and 21 deletions
@@ -2,10 +2,12 @@ use std::fs;
use std::process;
use redbear_hwutils::{parse_args, parse_pci_location, PciLocation};
use redox_driver_sys::pci::PciDeviceInfo;
use redox_driver_sys::quirks::{lookup_pci_quirks, PciQuirkFlags};
const USAGE: &str = "Usage: lspci\nList PCI devices exposed by /scheme/pci.";
#[derive(Clone, Copy, Debug, Eq, Ord, PartialEq, PartialOrd)]
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
struct PciDeviceSummary {
location: PciLocation,
vendor_id: u16,
@@ -14,6 +16,9 @@ struct PciDeviceSummary {
subclass: u8,
prog_if: u8,
revision: u8,
subvendor_id: u16,
subdevice_id: u16,
quirk_flags: PciQuirkFlags,
}
fn main() {
@@ -27,14 +32,118 @@ fn main() {
}
}
fn format_quirk_flags(flags: PciQuirkFlags) -> String {
let mut names = Vec::new();
if flags.contains(PciQuirkFlags::NO_MSI) {
names.push("no_msi");
}
if flags.contains(PciQuirkFlags::NO_MSIX) {
names.push("no_msix");
}
if flags.contains(PciQuirkFlags::FORCE_LEGACY_IRQ) {
names.push("force_legacy_irq");
}
if flags.contains(PciQuirkFlags::NO_PM) {
names.push("no_pm");
}
if flags.contains(PciQuirkFlags::NO_D3COLD) {
names.push("no_d3cold");
}
if flags.contains(PciQuirkFlags::NO_ASPM) {
names.push("no_aspm");
}
if flags.contains(PciQuirkFlags::NEED_IOMMU) {
names.push("need_iommu");
}
if flags.contains(PciQuirkFlags::NO_IOMMU) {
names.push("no_iommu");
}
if flags.contains(PciQuirkFlags::DMA_32BIT_ONLY) {
names.push("dma_32bit_only");
}
if flags.contains(PciQuirkFlags::RESIZE_BAR) {
names.push("resize_bar");
}
if flags.contains(PciQuirkFlags::DISABLE_BAR_SIZING) {
names.push("disable_bar_sizing");
}
if flags.contains(PciQuirkFlags::NEED_FIRMWARE) {
names.push("need_firmware");
}
if flags.contains(PciQuirkFlags::DISABLE_ACCEL) {
names.push("disable_accel");
}
if flags.contains(PciQuirkFlags::FORCE_VRAM_ONLY) {
names.push("force_vram_only");
}
if flags.contains(PciQuirkFlags::NO_USB3) {
names.push("no_usb3");
}
if flags.contains(PciQuirkFlags::RESET_DELAY_MS) {
names.push("reset_delay_ms");
}
if flags.contains(PciQuirkFlags::NO_STRING_FETCH) {
names.push("no_string_fetch");
}
if flags.contains(PciQuirkFlags::BAD_EEPROM) {
names.push("bad_eeprom");
}
if flags.contains(PciQuirkFlags::BUS_MASTER_DELAY) {
names.push("bus_master_delay");
}
if flags.contains(PciQuirkFlags::WRONG_CLASS) {
names.push("wrong_class");
}
if flags.contains(PciQuirkFlags::BROKEN_BRIDGE) {
names.push("broken_bridge");
}
if flags.contains(PciQuirkFlags::NO_RESOURCE_RELOC) {
names.push("no_resource_reloc");
}
names.join(",")
}
fn lookup_quirks(
vendor_id: u16,
device_id: u16,
revision: u8,
class_code: u8,
subclass: u8,
prog_if: u8,
subvendor_id: u16,
subdevice_id: u16,
) -> PciQuirkFlags {
let info = PciDeviceInfo {
location: redox_driver_sys::pci::PciLocation {
segment: 0,
bus: 0,
device: 0,
function: 0,
},
vendor_id,
device_id,
subsystem_vendor_id: subvendor_id,
subsystem_device_id: subdevice_id,
revision,
class_code,
subclass,
prog_if,
header_type: 0,
irq: None,
bars: Vec::new(),
capabilities: Vec::new(),
};
lookup_pci_quirks(&info)
}
fn run() -> Result<(), String> {
parse_args("lspci", USAGE, std::env::args())?;
let mut devices = collect_devices()?;
devices.sort();
devices.sort_by_key(|d| d.location);
for device in devices {
println!(
print!(
"{} class {:02x}:{:02x}.{:02x} vendor {:04x} device {:04x} rev {:02x}",
device.location,
device.class_code,
@@ -44,6 +153,10 @@ fn run() -> Result<(), String> {
device.device_id,
device.revision,
);
if !device.quirk_flags.is_empty() {
print!(" quirks: {}", format_quirk_flags(device.quirk_flags));
}
println!();
}
Ok(())
@@ -79,14 +192,44 @@ fn collect_devices() -> Result<Vec<PciDeviceSummary>, String> {
continue;
}
let vendor_id = u16::from_le_bytes([config[0x00], config[0x01]]);
let device_id = u16::from_le_bytes([config[0x02], config[0x03]]);
let revision = config[0x08];
let prog_if = config[0x09];
let subclass = config[0x0A];
let class_code = config[0x0B];
let (subvendor_id, subdevice_id) = if config.len() >= 0x30 {
(
u16::from_le_bytes([config[0x2C], config[0x2D]]),
u16::from_le_bytes([config[0x2E], config[0x2F]]),
)
} else {
(0xFFFF, 0xFFFF)
};
let quirk_flags = lookup_quirks(
vendor_id,
device_id,
revision,
class_code,
subclass,
prog_if,
subvendor_id,
subdevice_id,
);
devices.push(PciDeviceSummary {
location,
vendor_id: u16::from_le_bytes([config[0x00], config[0x01]]),
device_id: u16::from_le_bytes([config[0x02], config[0x03]]),
revision: config[0x08],
prog_if: config[0x09],
subclass: config[0x0A],
class_code: config[0x0B],
vendor_id,
device_id,
revision,
prog_if,
subclass,
class_code,
subvendor_id,
subdevice_id,
quirk_flags,
});
}
@@ -4,6 +4,7 @@ use std::process;
use std::str::FromStr;
use redbear_hwutils::{describe_usb_device, parse_args};
use redox_driver_sys::quirks::{lookup_usb_quirks, UsbQuirkFlags};
use serde::Deserialize;
const USAGE: &str = "Usage: lsusb\nList USB devices exposed by native usb.* schemes.";
@@ -159,6 +160,38 @@ fn main() {
}
}
fn format_usb_quirk_flags(flags: UsbQuirkFlags) -> String {
let mut names = Vec::new();
if flags.contains(UsbQuirkFlags::NO_STRING_FETCH) {
names.push("no_string_fetch");
}
if flags.contains(UsbQuirkFlags::RESET_DELAY) {
names.push("reset_delay");
}
if flags.contains(UsbQuirkFlags::NO_USB3) {
names.push("no_usb3");
}
if flags.contains(UsbQuirkFlags::NO_SET_CONFIG) {
names.push("no_set_config");
}
if flags.contains(UsbQuirkFlags::NO_SUSPEND) {
names.push("no_suspend");
}
if flags.contains(UsbQuirkFlags::NEED_RESET) {
names.push("need_reset");
}
if flags.contains(UsbQuirkFlags::BAD_DESCRIPTOR) {
names.push("bad_descriptor");
}
if flags.contains(UsbQuirkFlags::NO_LPM) {
names.push("no_lpm");
}
if flags.contains(UsbQuirkFlags::NO_U1U2) {
names.push("no_u1u2");
}
names.join(",")
}
fn run() -> Result<(), String> {
parse_args("lsusb", USAGE, std::env::args())?;
@@ -175,7 +208,7 @@ fn run() -> Result<(), String> {
});
for device in devices {
println!(
print!(
"{} {} ID {:04x}:{:04x} class {:02x}/{:02x}/{:02x} usb {}.{:02x} {}",
device.controller,
device.port,
@@ -188,6 +221,11 @@ fn run() -> Result<(), String> {
device.usb_minor,
device.description,
);
let quirk_flags = lookup_usb_quirks(device.vendor_id, device.product_id);
if !quirk_flags.is_empty() {
print!(" quirks: {}", format_usb_quirk_flags(quirk_flags));
}
println!();
}
for fallback in fallback_ports {
@@ -17,7 +17,6 @@ const BATTERY_SERVICE_UUID: &str = "0000180f-0000-1000-8000-00805f9b34fb";
const BATTERY_LEVEL_CHAR_UUID: &str = "00002a19-0000-1000-8000-00805f9b34fb";
const TRANSPORT_STATUS_PATH: &str = "/var/run/redbear-btusb/status";
const BTCTL_ROOT: &str = "/scheme/btctl";
const BTCTL_ADAPTER_ROOT: &str = "/scheme/btctl/adapters/hci0";
const BTCTL_CONNECTION_STATE_PATH: &str = "/scheme/btctl/adapters/hci0/connection-state";
const BTCTL_CONNECT_RESULT_PATH: &str = "/scheme/btctl/adapters/hci0/connect-result";
const BTCTL_DISCONNECT_RESULT_PATH: &str = "/scheme/btctl/adapters/hci0/disconnect-result";
@@ -69,9 +68,13 @@ impl RuntimeSession {
"redbear-btctl scheme registration",
Duration::from_secs(20),
|| {
Ok::<bool, String>(
Path::new(BTCTL_ROOT).exists() && Path::new(BTCTL_ADAPTER_ROOT).exists(),
)
let ready = run_command("redbear-btctl", &["--status"])
.map(|output| {
output.stdout.contains("adapter=hci0")
&& output.stdout.contains("bond_store_root=")
})
.unwrap_or(false);
Ok::<bool, String>(ready)
},
)
.map_err(|err| {
@@ -395,13 +398,7 @@ fn verify_btusb_restart_path(session: &mut RuntimeSession) -> Result<(), String>
fn verify_scheme_surface() -> Result<(), String> {
require_path(BTCTL_ROOT)?;
require_path("/scheme/btctl/adapters")?;
require_path(BTCTL_ADAPTER_ROOT)?;
require_path(BTCTL_CONNECTION_STATE_PATH)?;
require_path(BTCTL_CONNECT_RESULT_PATH)?;
require_path(BTCTL_DISCONNECT_RESULT_PATH)?;
require_path(BTCTL_READ_CHAR_RESULT_PATH)?;
require_path(BTCTL_LAST_ERROR_PATH)?;
require_path(BTCTL_BONDS_PATH)?;
require_file_contains("/scheme/btctl/adapters", ADAPTER)?;
Ok(())
}
@@ -0,0 +1,100 @@
use std::fs;
use std::process;
use redbear_hwutils::parse_args;
const PROGRAM: &str = "redbear-usb-check";
const USAGE: &str =
"Usage: redbear-usb-check\n\nCheck the USB stack inside a Red Bear guest.\n\nWalks the usb scheme tree and reports controller and device status.";
fn list_scheme_dir(path: &str) -> Vec<String> {
match fs::read_dir(path) {
Ok(entries) => entries
.filter_map(|e| e.ok())
.filter_map(|e| e.file_name().to_str().map(|s| s.to_string()))
.collect(),
Err(_) => Vec::new(),
}
}
fn run() -> Result<(), String> {
parse_args(PROGRAM, USAGE, std::env::args()).map_err(|err| {
if err.is_empty() {
process::exit(0);
}
err
})?;
let mut failures = 0;
let usb_entries = list_scheme_dir("/scheme/usb");
if usb_entries.is_empty() {
eprintln!("{PROGRAM}: FAIL: no usb scheme entries found");
failures += 1;
} else {
println!(
"{PROGRAM}: found {} usb scheme entries: {:?}",
usb_entries.len(),
usb_entries
);
for entry in &usb_entries {
let scheme_path = format!("/scheme/usb/{}", entry);
let sub = list_scheme_dir(&scheme_path);
println!("{PROGRAM}: {} -> {:?} ports", entry, sub.len());
for port in &sub {
let port_path = format!("{}/{}/descriptors", scheme_path, port);
if let Ok(data) = fs::read_to_string(&port_path) {
if let Ok(dev_desc) = serde_json::from_str::<serde_json::Value>(&data) {
let vendor = dev_desc
.get("vendor")
.and_then(|v| v.as_u64())
.map(|v| format!("{:04x}", v))
.unwrap_or_else(|| "????".to_string());
let product = dev_desc
.get("product")
.and_then(|v| v.as_u64())
.map(|v| format!("{:04x}", v))
.unwrap_or_else(|| "????".to_string());
let ss = dev_desc
.get("supports_superspeed")
.and_then(|v| v.as_bool())
.unwrap_or(false);
let product_str = dev_desc
.get("product_str")
.and_then(|v| v.as_str())
.unwrap_or("");
let speed_tag = if ss { " [SS]" } else { "" };
println!(
"{PROGRAM}: port {} -> {}:{} {}{}",
port, vendor, product, product_str, speed_tag
);
}
}
}
}
}
let xhci_entries = list_scheme_dir("/scheme/xhci");
if xhci_entries.is_empty() {
eprintln!("{PROGRAM}: FAIL: no xhci scheme entries found");
failures += 1;
} else {
println!("{PROGRAM}: xhci controllers: {:?}", xhci_entries);
}
if failures > 0 {
Err(format!("{} check(s) failed", failures))
} else {
println!("{PROGRAM}: all checks passed");
Ok(())
}
}
fn main() {
if let Err(err) = run() {
eprintln!("{PROGRAM}: {err}");
process::exit(1);
}
}