From c46d5dea7ada8e02e1a28348ac2448b42d9d0e06 Mon Sep 17 00:00:00 2001
From: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Date: Thu, 18 Dec 2025 21:12:19 +0100
Subject: [PATCH] drivers/graphics/fbbootlogd: Reduce flickering while
 scrolling

---
 drivers/graphics/fbbootlogd/src/scheme.rs   | 15 ++++++-----
 drivers/graphics/graphics-ipc/src/common.rs | 29 +++++++++++++++++++++
 2 files changed, 37 insertions(+), 7 deletions(-)

diff --git a/drivers/graphics/fbbootlogd/src/scheme.rs b/drivers/graphics/fbbootlogd/src/scheme.rs
index 832c511d76..ff0108e46c 100644
--- a/drivers/graphics/fbbootlogd/src/scheme.rs
+++ b/drivers/graphics/fbbootlogd/src/scheme.rs
@@ -4,7 +4,7 @@ use std::collections::VecDeque;
 use console_draw::{TextScreen, V2DisplayMap};
 use drm::buffer::Buffer;
 use drm::control::Device;
-use graphics_ipc::v2::V2GraphicsHandle;
+use graphics_ipc::v2::{Damage, V2GraphicsHandle};
 use inputd::ConsumerHandle;
 use orbclient::{Event, EventOption};
 use redox_scheme::scheme::SchemeSync;
@@ -127,6 +127,8 @@ impl FbbootlogScheme {
         let mut i = self.scrollback_offset;
         self.text_screen
             .write(map, b"\x1B[1;1H\x1B[2J", &mut VecDeque::new());
+
+        let mut total_damage = Damage::NONE;
         while i < buffer_len {
             let mut damage =
                 self.text_screen
@@ -136,17 +138,16 @@ impl FbbootlogScheme {
             if i == buffer_len || yd + spare_lines * 16 > map.fb.size().1 as usize {
                 // render until end of screen
                 damage.height = map.fb.size().1 - damage.y;
-                map.display_handle
-                    .update_plane(0, u32::from(map.fb.handle()), damage)
-                    .unwrap();
+                total_damage = total_damage.merge(damage);
                 self.is_scrollback = i < buffer_len;
                 break;
             } else {
-                map.display_handle
-                    .update_plane(0, u32::from(map.fb.handle()), damage)
-                    .unwrap();
+                total_damage = total_damage.merge(damage);
             }
         }
+        map.display_handle
+            .update_plane(0, u32::from(map.fb.handle()), total_damage)
+            .unwrap();
     }
 
     fn handle_resize(map: &mut V2DisplayMap, text_screen: &mut TextScreen) {
diff --git a/drivers/graphics/graphics-ipc/src/common.rs b/drivers/graphics/graphics-ipc/src/common.rs
index 27138151d5..ca5dc48392 100644
--- a/drivers/graphics/graphics-ipc/src/common.rs
+++ b/drivers/graphics/graphics-ipc/src/common.rs
@@ -13,6 +13,35 @@ pub struct Damage {
 }
 
 impl Damage {
+    pub const NONE: Self = Damage {
+        x: 0,
+        y: 0,
+        width: 0,
+        height: 0,
+    };
+
+    pub fn merge(self, other: Self) -> Self {
+        if self.width == 0 || self.height == 0 {
+            return other;
+        }
+
+        if other.width == 0 || other.height == 0 {
+            return self;
+        }
+
+        let x = cmp::min(self.x, other.x);
+        let y = cmp::min(self.y, other.y);
+        let x2 = cmp::max(self.x + self.width, other.x + other.width);
+        let y2 = cmp::max(self.y + self.height, other.y + other.height);
+
+        Damage {
+            x,
+            y,
+            width: x2 - x,
+            height: y2 - y,
+        }
+    }
+
     #[must_use]
     pub fn clip(mut self, width: u32, height: u32) -> Self {
         // Clip damage