From b0d7b6135e2b77998f742a23e66d704e650e81c4 Mon Sep 17 00:00:00 2001 From: bjorn3 <17426603+bjorn3@users.noreply.github.com> Date: Thu, 14 May 2026 16:08:21 +0200 Subject: [PATCH] Restore some FIXMEs --- drivers/graphics/vesad/src/scheme.rs | 2 +- drivers/graphics/virtio-gpud/src/scheme.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/graphics/vesad/src/scheme.rs b/drivers/graphics/vesad/src/scheme.rs index 55b4b9994c..7276ef4ad6 100644 --- a/drivers/graphics/vesad/src/scheme.rs +++ b/drivers/graphics/vesad/src/scheme.rs @@ -149,7 +149,7 @@ impl GraphicsAdapter for FbAdapter { if let Some(buffer) = buffer { buffer.buffer.sync(framebuffer, damage) } else { - let onscreen_ptr = framebuffer.onscreen as *mut u32; + let onscreen_ptr = framebuffer.onscreen as *mut u32; // FIXME use as_mut_ptr once stable for row in 0..framebuffer.height { unsafe { ptr::write_bytes( diff --git a/drivers/graphics/virtio-gpud/src/scheme.rs b/drivers/graphics/virtio-gpud/src/scheme.rs index f970c970ca..f3d0aed693 100644 --- a/drivers/graphics/virtio-gpud/src/scheme.rs +++ b/drivers/graphics/virtio-gpud/src/scheme.rs @@ -450,7 +450,6 @@ impl<'a> GraphicsAdapter for VirtGpuAdapter<'a> { let crtc = objects.get_crtc(crtc_id).unwrap().lock().unwrap(); let mut plane = plane.lock().unwrap(); - // fb_id now in plane state let framebuffer = new_plane_state .fb_id .map(|fb_id| objects.get_framebuffer(fb_id)) @@ -494,6 +493,7 @@ impl<'a> GraphicsAdapter for VirtGpuAdapter<'a> { let header = self.send_request(req).await.unwrap(); assert_eq!(header.ty, CommandTy::RespOkNodata); + // FIXME once we support resizing we also need to check that the current and target size match if self.displays[display_id as usize].active_resource != Some(framebuffer.buffer.id) { let scanout_request = Dma::new(SetScanout::new(