From adb40dd0c0a2b1cf24a6daceef0ee387c78794b0 Mon Sep 17 00:00:00 2001 From: vasilito Date: Sat, 1 Aug 2026 16:38:16 +0300 Subject: [PATCH] =?UTF-8?q?kde:=20kf6-kcrash=20+=20plasma-desktop=20?= =?UTF-8?q?=E2=80=94=20Qt6Test=20optional,=20grp.h=20for=20setgroups?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - qtbase builds with FEATURE_testlib=OFF (no Qt6Test module), but kf6-kcrash and plasma-desktop find_package(Qt6Test REQUIRED) unconditionally though it's only used by autotests (BUILD_TESTING=OFF). Drop REQUIRED (kde-cli-tools/kwin already used QUIET). - kcrash.cpp uses setgroups() to drop supplementary groups in the crash-handler child; on glibc it comes via +_GNU_SOURCE, but relibc declares it in (which it does provide) — add the include. --- local/recipes/kde/kf6-kcrash/source/CMakeLists.txt | 2 +- local/recipes/kde/kf6-kcrash/source/src/kcrash.cpp | 1 + local/recipes/kde/plasma-desktop/source/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/local/recipes/kde/kf6-kcrash/source/CMakeLists.txt b/local/recipes/kde/kf6-kcrash/source/CMakeLists.txt index 75172b7157..7f64452550 100644 --- a/local/recipes/kde/kf6-kcrash/source/CMakeLists.txt +++ b/local/recipes/kde/kf6-kcrash/source/CMakeLists.txt @@ -34,7 +34,7 @@ if(WITH_X11) find_package(X11 REQUIRED) set(HAVE_X11 TRUE) endif() -find_package(Qt6Test ${REQUIRED_QT_VERSION} CONFIG REQUIRED) +find_package(Qt6Test ${REQUIRED_QT_VERSION} CONFIG) include(ECMGenerateExportHeader) include(ECMSetupVersion) include(ECMGenerateHeaders) diff --git a/local/recipes/kde/kf6-kcrash/source/src/kcrash.cpp b/local/recipes/kde/kf6-kcrash/source/src/kcrash.cpp index bcd69791f7..85a9f70c6b 100644 --- a/local/recipes/kde/kf6-kcrash/source/src/kcrash.cpp +++ b/local/recipes/kde/kf6-kcrash/source/src/kcrash.cpp @@ -24,6 +24,7 @@ #include #ifndef Q_OS_WIN #include +#include // setgroups() — on glibc it comes via +_GNU_SOURCE; relibc declares it in #include #include #else diff --git a/local/recipes/kde/plasma-desktop/source/CMakeLists.txt b/local/recipes/kde/plasma-desktop/source/CMakeLists.txt index 23598b0ee6..fa3b35829d 100644 --- a/local/recipes/kde/plasma-desktop/source/CMakeLists.txt +++ b/local/recipes/kde/plasma-desktop/source/CMakeLists.txt @@ -96,7 +96,7 @@ find_package(PlasmaActivities ${PROJECT_DEP_VERSION} REQUIRED) find_package(PlasmaActivitiesStats ${PROJECT_DEP_VERSION} REQUIRED) if(BUILD_TESTING) - find_package(Qt6Test ${QT_MIN_VERSION} CONFIG REQUIRED) + find_package(Qt6Test ${QT_MIN_VERSION} CONFIG) include(ECMAddTests) endif()