From 98c43529e7ab68246d101b6640b8dbf4d344abb4 Mon Sep 17 00:00:00 2001
From: Red Bear OS <build@redbearos.org>
Date: Wed, 8 Jul 2026 16:38:48 +0300
Subject: [PATCH] cleanup: fix unused variable + unnecessary mut warnings (7
 total)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- router/mod.rs: 4x |mut b| → |b| (&mut [u8] is already mutable)
- scheme/icmp.rs: handle_recvmsg stub params → _file, _how, _flags
- scheme/ip.rs: handle_recvmsg stub params → _file, _how, _flags
- scheme/socket.rs: get_sock_opt default + msg_send ctx → _ prefixed
- scheme/tun.rs: loop name → _name
---
 netstack/src/router/mod.rs    | 8 ++++----
 netstack/src/scheme/icmp.rs   | 6 +++---
 netstack/src/scheme/ip.rs     | 6 +++---
 netstack/src/scheme/socket.rs | 8 ++++----
 netstack/src/scheme/tun.rs    | 2 +-
 5 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/netstack/src/router/mod.rs b/netstack/src/router/mod.rs
index c8db1801e8..2a3eb21865 100644
--- a/netstack/src/router/mod.rs
+++ b/netstack/src/router/mod.rs
@@ -138,14 +138,14 @@ impl Router {
                 RouteType::Unreachable => {
                     if let Some(error_pkt) = icmp_error::build_icmpv4_port_unreachable(packet) {
                         let _ = self.rx_buffer.enqueue(error_pkt.len(), ())
-                            .map(|mut b| b.copy_from_slice(&error_pkt));
+                            .map(|b| b.copy_from_slice(&error_pkt));
                     }
                     continue;
                 }
                 RouteType::Prohibit => {
                     if let Some(error_pkt) = icmp_error::build_icmpv4_port_unreachable(packet) {
                         let _ = self.rx_buffer.enqueue(error_pkt.len(), ())
-                            .map(|mut b| b.copy_from_slice(&error_pkt));
+                            .map(|b| b.copy_from_slice(&error_pkt));
                     }
                     continue;
                 }
@@ -312,14 +312,14 @@ impl Router {
                         RouteType::Unreachable => {
                             if let Some(error_pkt) = icmp_error::build_icmpv4_port_unreachable(&packet_buf) {
                                 let _ = self.tx_buffer.enqueue(error_pkt.len(), ())
-                                    .map(|mut b| b.copy_from_slice(&error_pkt));
+                                    .map(|b| b.copy_from_slice(&error_pkt));
                             }
                             continue;
                         }
                         RouteType::Prohibit => {
                             if let Some(error_pkt) = icmp_error::build_icmpv4_port_unreachable(&packet_buf) {
                                 let _ = self.tx_buffer.enqueue(error_pkt.len(), ())
-                                    .map(|mut b| b.copy_from_slice(&error_pkt));
+                                    .map(|b| b.copy_from_slice(&error_pkt));
                             }
                             continue;
                         }
diff --git a/netstack/src/scheme/icmp.rs b/netstack/src/scheme/icmp.rs
index e326c67eb5..e40f01be20 100644
--- a/netstack/src/scheme/icmp.rs
+++ b/netstack/src/scheme/icmp.rs
@@ -269,9 +269,9 @@ impl<'a> SchemeSocket for IcmpSocket<'a> {
 
     fn handle_recvmsg(
         &mut self,
-        file: &mut SchemeFile<Self>,
-        how: &mut [u8],
-        flags: usize,
+        _file: &mut SchemeFile<Self>,
+        _how: &mut [u8],
+        _flags: usize,
     ) -> SyscallResult<usize> {
         return Err(SyscallError::new(syscall::EOPNOTSUPP));
     }
diff --git a/netstack/src/scheme/ip.rs b/netstack/src/scheme/ip.rs
index 18d0dc6d9a..4483c10775 100644
--- a/netstack/src/scheme/ip.rs
+++ b/netstack/src/scheme/ip.rs
@@ -146,9 +146,9 @@ impl<'a> SchemeSocket for RawSocket<'a> {
 
     fn handle_recvmsg(
         &mut self,
-        file: &mut SchemeFile<Self>,
-        how: &mut [u8],
-        flags: usize,
+        _file: &mut SchemeFile<Self>,
+        _how: &mut [u8],
+        _flags: usize,
     ) -> SyscallResult<usize> {
         return Err(SyscallError::new(syscall::EOPNOTSUPP));
     }
diff --git a/netstack/src/scheme/socket.rs b/netstack/src/scheme/socket.rs
index 342d6df4d0..2317288a3e 100644
--- a/netstack/src/scheme/socket.rs
+++ b/netstack/src/scheme/socket.rs
@@ -253,9 +253,9 @@ where
 
 fn get_sock_opt(
         &self,
-        file: &SchemeFile<Self>,
-        name: usize,
-        buf: &mut [u8],
+        _file: &SchemeFile<Self>,
+        _name: usize,
+        _buf: &mut [u8],
     ) -> SyscallResult<usize> {
         Err(SyscallError::new(syscall::ENOPROTOOPT))
     }
@@ -448,7 +448,7 @@ where
         fd: usize,
         payload: &mut [u8],
         metadata: &[u64],
-        ctx: &CallerCtx,
+        _ctx: &CallerCtx,
     ) -> SyscallResult<usize> {
         // metadata to Vec<u8>
         let Some(verb) = SocketCall::try_from_raw(metadata[0] as usize) else {
diff --git a/netstack/src/scheme/tun.rs b/netstack/src/scheme/tun.rs
index f1a1c23e35..bdc61f657a 100644
--- a/netstack/src/scheme/tun.rs
+++ b/netstack/src/scheme/tun.rs
@@ -116,7 +116,7 @@ impl TunScheme {
                 _ => {}
             }
         }
-        for (name, dev) in &self.inner.devices {
+        for (_name, dev) in &self.inner.devices {
             let mut written = Vec::new();
             {
                 let mut rx = dev.tx.borrow_mut();