From 8cad68ec41507bf70890cc1bef8f1be58b826928 Mon Sep 17 00:00:00 2001 From: Vasilito Date: Fri, 1 May 2026 01:17:17 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20Oracle=20review=204=20=E2=80=94=20all=20?= =?UTF-8?q?remaining=20issues=20resolved?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. KWin || true removed from sed commands (lines 53-57) 2. docs/07: RELIBC-COMPLETENESS+IMPLEMENTATION → KERNEL-IPC-CREDENTIAL 3. docs/README: v2.0 note → v4.0, date 2026-04-18 → 2026-05-01 4. local/AGENTS.md: v2.0 reference → v4.0 5. redox-drm: virtio-gpu (0x1AF4) added to auto-probe filter + P5-virtio-auto-probe.patch wired in recipe.toml 6. KWin cmake configs kept (downstream dependency, not KWin stub) --- docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md | 3 +-- docs/README.md | 10 +++++----- local/AGENTS.md | 4 ++-- .../patches/redox-drm/P5-virtio-auto-probe.patch | 16 ++++++++++++++++ .../gpu/redox-drm/P5-virtio-auto-probe.patch | 16 ++++++++++++++++ local/recipes/gpu/redox-drm/recipe.toml | 2 +- local/recipes/kde/kwin/recipe.toml | 6 +++--- 7 files changed, 44 insertions(+), 13 deletions(-) create mode 100644 local/patches/redox-drm/P5-virtio-auto-probe.patch create mode 100644 local/recipes/gpu/redox-drm/P5-virtio-auto-probe.patch diff --git a/docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md b/docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md index a885b03b..20bf5085 100644 --- a/docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md +++ b/docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md @@ -410,8 +410,7 @@ The current subsystem plans to treat as first-class are: - `local/docs/USB-IMPLEMENTATION-PLAN.md` - `local/docs/WIFI-IMPLEMENTATION-PLAN.md` - `local/docs/BLUETOOTH-IMPLEMENTATION-PLAN.md` -- `local/docs/RELIBC-COMPLETENESS-AND-ENHANCEMENT-PLAN.md` -- `local/docs/RELIBC-IMPLEMENTATION-PLAN.md` — implementation roadmap for relibc POSIX gaps +- `local/docs/KERNEL-IPC-CREDENTIAL-PLAN.md` — implemented credential syscalls + kernel robustness - `local/docs/RELIBC-IPC-ASSESSMENT-AND-IMPROVEMENT-PLAN.md` - `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` — **canonical comprehensive plan** diff --git a/docs/README.md b/docs/README.md index 3b83238f..1d3fdd4d 100644 --- a/docs/README.md +++ b/docs/README.md @@ -5,9 +5,9 @@ Technical documentation for Red Bear OS as an overlay distribution on top of Red This index is the entry point for the documentation set. Its main job is to make the current/canonical versus historical/reference split obvious. -> **Status note (2026-04-16):** The canonical desktop path document is now -> `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` (v2.0, three-track Phase 1–5 model). It consolidates -> the Wayland, KDE, and GPU roadmap into one honest implementation plan with testable exit criteria. +> **Status note (2026-04-30):** The canonical desktop path document is +> `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` (v4.0, single comprehensive plan). It supersedes +> all earlier individual assessments and is the single authority for current state. > The historical docs below (01–05) remain useful for architecture reference and implementation > rationale, but they should be read together with the new plan and the current local subsystem docs. @@ -92,9 +92,9 @@ Do not flatten those into one “supported” claim in public summaries. - `../local/docs/SCRIPT-BEHAVIOR-MATRIX.md` — what the main sync/fetch/apply/build scripts do and do not guarantee -## Current State Summary (as of 2026-04-18) +## Current State Summary (as of 2026-05-01) -This summary is only a quick orientation layer. For canonical current-state detail, prefer: +This summary is only a quick orientation layer. For canonical current-state detail, see `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` (v4.0). - `docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md` for repository-wide execution order, - `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` for the canonical comprehensive plan, diff --git a/local/AGENTS.md b/local/AGENTS.md index 1df6911b..c6d73ab4 100644 --- a/local/AGENTS.md +++ b/local/AGENTS.md @@ -370,8 +370,8 @@ When mainline updates affect our work: ## PLANNING NOTES - `docs/07-RED-BEAR-OS-IMPLEMENTATION-PLAN.md` is the canonical public execution plan. -- `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` (v2.0) is the canonical desktop path plan from console to - hardware-accelerated KDE Plasma on Wayland, using a three-track Phase 1–5 model. +- `local/docs/CONSOLE-TO-KDE-DESKTOP-PLAN.md` (v4.0) is the canonical comprehensive plan — + supersedes all individual subsystem docs. See it for current state, blockers, and roadmap. - `local/docs/WAYLAND-IMPLEMENTATION-PLAN.md` is the canonical Wayland subsystem plan beneath the desktop path. Use it for Wayland-specific stability, completeness, ownership, and runtime-proof sequencing. diff --git a/local/patches/redox-drm/P5-virtio-auto-probe.patch b/local/patches/redox-drm/P5-virtio-auto-probe.patch new file mode 100644 index 00000000..6c968c06 --- /dev/null +++ b/local/patches/redox-drm/P5-virtio-auto-probe.patch @@ -0,0 +1,16 @@ +diff --git a/local/recipes/gpu/redox-drm/source/src/main.rs b/local/recipes/gpu/redox-drm/source/src/main.rs +index 612a64e0f..f4abdc7bb 100644 +--- a/local/recipes/gpu/redox-drm/source/src/main.rs ++++ b/local/recipes/gpu/redox-drm/source/src/main.rs +@@ -168,9 +168,9 @@ fn select_gpu_from_args() -> Result { + .map_err(|e| DriverError::Pci(format!("PCI scan failed: {e}")))?; + let first = devices + .into_iter() +- .find(|d| d.vendor_id == PCI_VENDOR_ID_AMD || d.vendor_id == PCI_VENDOR_ID_INTEL) ++ .find(|d| d.vendor_id == PCI_VENDOR_ID_AMD || d.vendor_id == PCI_VENDOR_ID_INTEL || d.vendor_id == 0x1AF4) + .ok_or_else(|| { +- DriverError::NotFound("no AMD or Intel GPU found via scheme:pci".to_string()) ++ DriverError::NotFound("no AMD, Intel, or VirtIO GPU found via scheme:pci".to_string()) + })?; + let mut pci = PciDevice::open_location(&first.location) + .map_err(|e| DriverError::Pci(format!("failed to open GPU {}: {e}", first.location)))?; diff --git a/local/recipes/gpu/redox-drm/P5-virtio-auto-probe.patch b/local/recipes/gpu/redox-drm/P5-virtio-auto-probe.patch new file mode 100644 index 00000000..6c968c06 --- /dev/null +++ b/local/recipes/gpu/redox-drm/P5-virtio-auto-probe.patch @@ -0,0 +1,16 @@ +diff --git a/local/recipes/gpu/redox-drm/source/src/main.rs b/local/recipes/gpu/redox-drm/source/src/main.rs +index 612a64e0f..f4abdc7bb 100644 +--- a/local/recipes/gpu/redox-drm/source/src/main.rs ++++ b/local/recipes/gpu/redox-drm/source/src/main.rs +@@ -168,9 +168,9 @@ fn select_gpu_from_args() -> Result { + .map_err(|e| DriverError::Pci(format!("PCI scan failed: {e}")))?; + let first = devices + .into_iter() +- .find(|d| d.vendor_id == PCI_VENDOR_ID_AMD || d.vendor_id == PCI_VENDOR_ID_INTEL) ++ .find(|d| d.vendor_id == PCI_VENDOR_ID_AMD || d.vendor_id == PCI_VENDOR_ID_INTEL || d.vendor_id == 0x1AF4) + .ok_or_else(|| { +- DriverError::NotFound("no AMD or Intel GPU found via scheme:pci".to_string()) ++ DriverError::NotFound("no AMD, Intel, or VirtIO GPU found via scheme:pci".to_string()) + })?; + let mut pci = PciDevice::open_location(&first.location) + .map_err(|e| DriverError::Pci(format!("failed to open GPU {}: {e}", first.location)))?; diff --git a/local/recipes/gpu/redox-drm/recipe.toml b/local/recipes/gpu/redox-drm/recipe.toml index 5e85d701..b87a9f76 100644 --- a/local/recipes/gpu/redox-drm/recipe.toml +++ b/local/recipes/gpu/redox-drm/recipe.toml @@ -1,6 +1,6 @@ [source] path = "source" -patches = ["P1-intel-gen-gate.patch", "P2-intel-display-fixes.patch", "P3-intel-gen8-gen9-firmware.patch", "P4-virtio-gpu-driver.patch"] +patches = ["P1-intel-gen-gate.patch", "P2-intel-display-fixes.patch", "P3-intel-gen8-gen9-firmware.patch", "P4-virtio-gpu-driver.patch", "P5-virtio-auto-probe.patch"] [build] template = "cargo" diff --git a/local/recipes/kde/kwin/recipe.toml b/local/recipes/kde/kwin/recipe.toml index 5e445d97..7a828213 100644 --- a/local/recipes/kde/kwin/recipe.toml +++ b/local/recipes/kde/kwin/recipe.toml @@ -51,10 +51,10 @@ done # Attempt real cmake build with Redox-viable feature set sed -i "s/^ecm_install_po_files_as_qm/#ecm_install_po_files_as_qm/" \ - "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null || true + "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null sed -i 's/^ki18n_install(po)/#ki18n_install(po)/' \ - "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null || true -sed -i '/include(ECMQmlModule)/s/^/#/' "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null || true + "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null +sed -i '/include(ECMQmlModule)/s/^/#/' "${COOKBOOK_SOURCE}/CMakeLists.txt" 2>/dev/null rm -f CMakeCache.txt rm -rf CMakeFiles