diff --git a/src/header/sys_select/mod.rs b/src/header/sys_select/mod.rs index 39b7599322..80a833d540 100644 --- a/src/header/sys_select/mod.rs +++ b/src/header/sys_select/mod.rs @@ -71,53 +71,52 @@ pub fn select_epoll( for fd in 0..nfds { let mut events = 0; - if let Some(ref fd_set) = read_bitset { - if fd_set.contains(fd as usize) { - events |= EPOLLIN; - } + if let Some(ref fd_set) = read_bitset + && fd_set.contains(fd as usize) + { + events |= EPOLLIN; } - if let Some(ref fd_set) = write_bitset { - if fd_set.contains(fd as usize) { - events |= EPOLLOUT; - } + if let Some(ref fd_set) = write_bitset + && fd_set.contains(fd as usize) + { + events |= EPOLLOUT; } - if let Some(ref fd_set) = except_bitset { - if fd_set.contains(fd as usize) { - events |= EPOLLERR; - } + if let Some(ref fd_set) = except_bitset + && fd_set.contains(fd as usize) + { + events |= EPOLLERR; } if events > 0 { let mut event = epoll_event { events, data: epoll_data { fd }, - ..Default::default() }; - if unsafe { epoll_ctl(*ep, EPOLL_CTL_ADD, fd, &mut event) } < 0 { + if unsafe { epoll_ctl(*ep, EPOLL_CTL_ADD, fd, &raw mut event) } < 0 { if platform::ERRNO.get() == errno::EPERM { not_epoll += 1; } else { return -1; } } else { - if let Some(ref mut fd_set) = read_bitset { - if fd_set.contains(fd as usize) { - fd_set.remove(fd as usize); - } + if let Some(ref mut fd_set) = read_bitset + && fd_set.contains(fd as usize) + { + fd_set.remove(fd as usize); } - if let Some(ref mut fd_set) = write_bitset { - if fd_set.contains(fd as usize) { - fd_set.remove(fd as usize); - } + if let Some(ref mut fd_set) = write_bitset + && fd_set.contains(fd as usize) + { + fd_set.remove(fd as usize); } - if let Some(ref mut fd_set) = except_bitset { - if fd_set.contains(fd as usize) { - fd_set.remove(fd as usize); - } + if let Some(ref mut fd_set) = except_bitset + && fd_set.contains(fd as usize) + { + fd_set.remove(fd as usize); } } } @@ -153,23 +152,23 @@ pub fn select_epoll( let fd = unsafe { event.data.fd }; // TODO: Error status when fd does not match? if fd >= 0 && fd < FD_SETSIZE as c_int { - if event.events & EPOLLIN > 0 { - if let Some(ref mut fd_set) = read_bitset { - fd_set.insert(fd as usize); - count += 1; - } + if event.events & EPOLLIN > 0 + && let Some(ref mut fd_set) = read_bitset + { + fd_set.insert(fd as usize); + count += 1; } - if event.events & EPOLLOUT > 0 { - if let Some(ref mut fd_set) = write_bitset { - fd_set.insert(fd as usize); - count += 1; - } + if event.events & EPOLLOUT > 0 + && let Some(ref mut fd_set) = write_bitset + { + fd_set.insert(fd as usize); + count += 1; } - if event.events & EPOLLERR > 0 { - if let Some(ref mut fd_set) = except_bitset { - fd_set.insert(fd as usize); - count += 1; - } + if event.events & EPOLLERR > 0 + && let Some(ref mut fd_set) = except_bitset + { + fd_set.insert(fd as usize); + count += 1; } } } diff --git a/src/header/sys_syslog/linux.rs b/src/header/sys_syslog/linux.rs index 019b112168..6c4731d2c2 100644 --- a/src/header/sys_syslog/linux.rs +++ b/src/header/sys_syslog/linux.rs @@ -54,7 +54,7 @@ impl LogSink for LogFile { if unsafe { connect( log_fd, - &raw const log_addr as *const sockaddr, + (&raw const log_addr).cast::(), size_of::() as u32, ) < 0 } { diff --git a/src/header/sys_syslog/logger.rs b/src/header/sys_syslog/logger.rs index 1a004f05c5..11a695a7b4 100644 --- a/src/header/sys_syslog/logger.rs +++ b/src/header/sys_syslog/logger.rs @@ -117,8 +117,8 @@ impl LogParams { fprintf( stderr, c"%s: %s".as_ptr(), - self.ident.as_ptr() as *const c_char, - buffer[prefix..].as_ptr() as *const c_char, + self.ident.as_ptr().cast::(), + buffer[prefix..].as_ptr().cast::(), ); } } diff --git a/src/header/sys_syslog/mod.rs b/src/header/sys_syslog/mod.rs index f2277cd740..9aea6ed58a 100644 --- a/src/header/sys_syslog/mod.rs +++ b/src/header/sys_syslog/mod.rs @@ -85,10 +85,10 @@ pub const extern "C" fn LOG_MASK(p: c_int) -> c_int { pub extern "C" fn setlogmask(mask: c_int) -> c_int { let mut params = LOGGER.lock(); let old = params.mask.bits(); - if mask != 0 { - if let Some(mask) = params.mask.with_mask(mask) { - params.mask = mask; - } + if mask != 0 + && let Some(mask) = params.mask.with_mask(mask) + { + params.mask = mask; } old } @@ -110,9 +110,9 @@ pub unsafe extern "C" fn openlog(ident: *const c_char, opt: c_int, facility: c_i ); // Ensure log is ready to write now instead of checking on the first message. - if conf.contains(logger::Config::NoDelay) { - if let Ok(()) = params.open_logger() {}; // TODO handle error - } + if conf.contains(logger::Config::NoDelay) + && let Ok(()) = params.open_logger() + {}; // TODO handle error } /// See . diff --git a/src/header/sys_timeb/mod.rs b/src/header/sys_timeb/mod.rs index c0ab30ec78..85c0ff1ec9 100644 --- a/src/header/sys_timeb/mod.rs +++ b/src/header/sys_timeb/mod.rs @@ -42,7 +42,7 @@ pub unsafe extern "C" fn ftime(tp: *mut timeb) -> c_int { // SAFETY: tv and tz are created above, and thus will coerce to valid // pointers. - if unsafe { gettimeofday(&mut tv, &mut tz) } < 0 { + if unsafe { gettimeofday(&raw mut tv, &raw mut tz) } < 0 { return -1; } diff --git a/src/sync/cond.rs b/src/sync/cond.rs index 827d9c93a2..5b1be7c7b3 100644 --- a/src/sync/cond.rs +++ b/src/sync/cond.rs @@ -73,10 +73,7 @@ impl Cond { let relative = match clock_id { // FUTEX expect monotonic clock CLOCK_MONOTONIC => timeout.clone(), - CLOCK_REALTIME => match timespec_realtime_to_monotonic(timeout.clone()) { - Ok(relative) => relative, - Err(err) => return Err(err), - }, + CLOCK_REALTIME => timespec_realtime_to_monotonic(timeout.clone())?, _ => return Err(Errno(EINVAL)), };