From 2d04b76a2cb90545e0b0b5b5d0cb885131587bd8 Mon Sep 17 00:00:00 2001
From: 4lDO2 <4lDO2@protonmail.com>
Date: Sat, 14 Oct 2023 15:38:21 +0200
Subject: [PATCH] Close sendfd file descriptor unless consumed.

---
 src/scheme/user.rs | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/scheme/user.rs b/src/scheme/user.rs
index 11552f7917..cb5aa0cb42 100644
--- a/src/scheme/user.rs
+++ b/src/scheme/user.rs
@@ -452,6 +452,8 @@ impl UserInner {
                         _ => return Err(Error::new(ENOENT)),
                     };
 
+                    // FIXME: Description can leak if context::current() fails, or if there is no
+                    // additional file table space.
                     if flags.contains(FobtainFdFlags::MANUAL_FD) {
                         context::current()?.read().insert_file(FileHandle::from(packet.c), FileDescriptor { description, cloexec: true });
                     } else {
@@ -516,6 +518,8 @@ impl UserInner {
         Ok(())
     }
     fn respond(&self, id: u64, response: Response) -> Result<()> {
+        let to_close;
+
         match self.states.lock().entry(id) {
             Entry::Occupied(mut o) => match mem::replace(o.get_mut(), State::Placeholder) {
                 // invalid state
@@ -526,19 +530,25 @@ impl UserInner {
                     return Err(Error::new(EINVAL));
                 }
 
-                State::Waiting { context, .. } => {
+                State::Waiting { context, fd } => {
+                    to_close = fd.and_then(|f| Arc::try_unwrap(f).ok()).map(RwLock::into_inner);
+
                     if let Some(context) = context.upgrade() {
                         context.write().unblock();
                         *o.get_mut() = State::Responded(response);
                     } else {
                         o.remove();
                     }
-                    Ok(())
                 }
             }
             // invalid state
             Entry::Vacant(_) => return Err(Error::new(EBADFD)),
         }
+
+        if let Some(to_close) = to_close {
+            let _ = to_close.try_close();
+        }
+        Ok(())
     }
 
     pub fn fevent(&self, _flags: EventFlags) -> Result<EventFlags> {