From 2bc44dba9d3b50a7364a17317d14b71a90bbc9c1 Mon Sep 17 00:00:00 2001 From: Josh Williams Date: Fri, 24 Jan 2025 17:57:44 -0800 Subject: [PATCH] modify makefile and run_tests fix compiler warnings --- tests/Makefile | 20 ++++++-------------- tests/run_tests.sh | 20 ++++++-------------- tests/signals/kill-child.c | 2 +- tests/signals/kill-group.c | 2 ++ tests/signals/killpg-self.c | 1 + 5 files changed, 16 insertions(+), 29 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index a91e9d4770..0ec8b764e9 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -185,30 +185,22 @@ NAMES=\ sigchld \ signals/kill-self \ signals/kill0-self \ - signals/kill-child \ - signals/kill-group \ signals/kill-invalid \ signals/kill-permission \ - signals/killpg-child \ signals/killpg-esrch \ signals/killpg-invalid \ - signals/killpg-self \ signals/killpg0-self \ signals/pthread_kill-invalid \ - signals/pthread_kill-self \ signals/pthread_kill0-self \ signals/raise-compliance \ - signals/sigaddset-add \ - signals/sigdelset-delete \ signals/sigismember-invalid \ signals/sigismember-valid \ - signals/sigpause-revert \ - signals/sigrpocmask-6 \ - signals/sigrpocmask-7 \ - signals/sigrpocmask-8 \ - signals/sigrpocmask-9 \ - signals/sigrpocmask-11 \ - signals/sigrpocmask-blocksingle \ + signals/sigprocmask-6 \ + signals/sigprocmask-7 \ + signals/sigprocmask-8 \ + signals/sigprocmask-9 \ + signals/sigprocmask-11 \ + signals/sigprocmask-blocksingle \ signals/sigrelse-2 \ signals/sigrelse-3 \ stdio/ctermid \ diff --git a/tests/run_tests.sh b/tests/run_tests.sh index a58315e509..8df7b62e81 100755 --- a/tests/run_tests.sh +++ b/tests/run_tests.sh @@ -170,30 +170,22 @@ STATUS_NAMES=(\ sigqueue \ signals/kill-self \ signals/kill0-self \ - signals/kill-child \ - signals/kill-group \ signals/kill-invalid \ signals/kill-permission \ - signals/killpg-child \ signals/killpg-esrch \ signals/killpg-invalid \ - signals/killpg-self \ signals/killpg0-self \ signals/pthread_kill-invalid \ - signals/pthread_kill-self \ signals/pthread_kill0-self \ signals/raise-compliance \ - signals/sigaddset-add \ - signals/sigdelset-delete \ signals/sigismember-invalid \ signals/sigismember-valid \ - signals/sigpause-revert \ - signals/sigrpocmask-6 \ - signals/sigrpocmask-7 \ - signals/sigrpocmask-8 \ - signals/sigrpocmask-9 \ - signals/sigrpocmask-11 \ - signals/sigrpocmask-blocksingle \ + signals/sigprocmask-6 \ + signals/sigprocmask-7 \ + signals/sigprocmask-8 \ + signals/sigprocmask-9 \ + signals/sigprocmask-11 \ + signals/sigprocmask-blocksingle \ signals/sigrelse-2 \ signals/sigrelse-3 \ stdio/tempnam \ diff --git a/tests/signals/kill-child.c b/tests/signals/kill-child.c index deefb271ed..c8f66ddaf5 100644 --- a/tests/signals/kill-child.c +++ b/tests/signals/kill-child.c @@ -82,7 +82,7 @@ void kill_child(int signum) int main() { - for (int i = 1; i < sizeof(signals_list)/sizeof(signals_list[0]); i++) + for (long unsigned int i = 1; i < sizeof(signals_list)/sizeof(signals_list[0]); i++) { int sig = signals_list[i].signal; if (sig == SIGKILL || sig == SIGSTOP) diff --git a/tests/signals/kill-group.c b/tests/signals/kill-group.c index 17ae2fb895..dd8243c71b 100644 --- a/tests/signals/kill-group.c +++ b/tests/signals/kill-group.c @@ -10,6 +10,7 @@ int handler_called = 0; void sig_handler(int signo) { + (void) signo; handler_called = 1; return; } @@ -29,6 +30,7 @@ int kill_group(int signum) ERROR_IF(sigaction, status, == -1); status = getpgrp(); + pgrp = status; ERROR_IF(getpgrp, status, == -1); status = kill(-pgrp, signum); diff --git a/tests/signals/killpg-self.c b/tests/signals/killpg-self.c index 41186f0573..130506aacc 100644 --- a/tests/signals/killpg-self.c +++ b/tests/signals/killpg-self.c @@ -12,6 +12,7 @@ void sig_handler(int signo) { // printf("Caught signal %d being tested!\n", signo); // printf("Test PASSED\n"); + (void) signo; return; }