From 124f11bde1cbaea7ce8c71a84268b41dba7a2dd1 Mon Sep 17 00:00:00 2001
From: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Date: Thu, 26 Feb 2026 17:41:39 +0100
Subject: [PATCH] init: Convert all service definitions to toml

---
 Cargo.lock                       |  1 +
 init.d/00_logging_ramfs.service  | 21 ++++++++------------
 init.d/00_nulld.service          | 19 +++++++-----------
 init.d/00_randd.service          | 23 ++++++++--------------
 init.d/00_rtcd.service           | 17 +++++++---------
 init.d/00_runtime.target         | 23 ++++++++++------------
 init.d/00_zerod.service          | 19 +++++++-----------
 init.d/10_inputd.service         | 17 ++++++----------
 init.d/10_lived.service          | 17 +++++++---------
 init.d/20_fbbootlogd.service     | 19 +++++++-----------
 init.d/20_fbcond.service         | 21 ++++++++------------
 init.d/20_graphics.target        | 19 ++++++++----------
 init.d/20_vesad.service          | 33 ++++++++++++++------------------
 init.d/90_exit_initfs.switchroot | 15 ++++++---------
 init/Cargo.toml                  |  1 +
 init/src/unit.rs                 |  9 ++++++---
 16 files changed, 111 insertions(+), 163 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index fc341f992d..5a7ac88c98 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1133,6 +1133,7 @@ dependencies = [
  "libredox",
  "serde",
  "serde_json",
+ "toml",
 ]
 
 [[package]]
diff --git a/init.d/00_logging_ramfs.service b/init.d/00_logging_ramfs.service
index d46cea9f8f..6971bc984e 100644
--- a/init.d/00_logging_ramfs.service
+++ b/init.d/00_logging_ramfs.service
@@ -1,13 +1,8 @@
-{
-    "unit": {
-        "default_dependencies": false,
-        "requires_weak": ["00_randd.service"]
-    },
-    "service": {
-        "cmd": "ramfs",
-        "args": ["logging"],
-        "type": {
-            "scheme": "logging"
-        }
-    }
-}
+[unit]
+default_dependencies = false
+requires_weak = ["00_randd.service"]
+
+[service]
+cmd = "ramfs"
+args = ["logging"]
+type = { scheme = "logging" }
diff --git a/init.d/00_nulld.service b/init.d/00_nulld.service
index 6775040ba9..3ec760faa5 100644
--- a/init.d/00_nulld.service
+++ b/init.d/00_nulld.service
@@ -1,12 +1,7 @@
-{
-    "unit": {
-        "description": "/dev/null",
-        "default_dependencies": false
-    },
-    "service": {
-        "cmd": "nulld",
-        "type": {
-            "scheme": "null"
-        }
-    }
-}
+[unit]
+description = "/dev/null"
+default_dependencies = false
+
+[service]
+cmd = "nulld"
+type = { scheme = "null" }
diff --git a/init.d/00_randd.service b/init.d/00_randd.service
index 2155c4cb52..d0bb7d0e43 100644
--- a/init.d/00_randd.service
+++ b/init.d/00_randd.service
@@ -1,15 +1,8 @@
-{
-    "unit": {
-        "description": "/dev/rand",
-        "default_dependencies": false
-    },
-    "service": {
-        "cmd": "randd",
-        "args": [
-            "rand"
-        ],
-        "type": {
-            "scheme": "rand"
-        }
-    }
-}
+[unit]
+description = "/dev/random"
+default_dependencies = false
+
+[service]
+cmd = "randd"
+args = ["rand"]
+type = { scheme = "rand" }
diff --git a/init.d/00_rtcd.service b/init.d/00_rtcd.service
index 6c3157d44b..ffe8ea2e56 100644
--- a/init.d/00_rtcd.service
+++ b/init.d/00_rtcd.service
@@ -1,10 +1,7 @@
-{
-    "unit": {
-        "description": "Set time from realtime clock",
-        "default_dependencies": false
-    },
-    "service": {
-        "cmd": "rtcd",
-        "type": "oneshot"
-    }
-}
+[unit]
+description = "Set time from realtime clock"
+default_dependencies = false
+
+[service]
+cmd = "rtcd"
+type = "oneshot"
diff --git a/init.d/00_runtime.target b/init.d/00_runtime.target
index 2acf50168b..801821fb3e 100644
--- a/init.d/00_runtime.target
+++ b/init.d/00_runtime.target
@@ -1,13 +1,10 @@
-{
-    "unit": {
-        "description": "Services that relibc needs to function",
-        "default_dependencies": false,
-        "requires_weak": [
-            "00_nulld.service",
-            "00_randd.service",
-            "00_rtcd.service",
-            "00_zerod.service",
-            "00_logging_ramfs.service"
-        ]
-    }
-}
+[unit]
+description = "Services that relibc needs to function"
+default_dependencies = false
+requires_weak = [
+    "00_nulld.service",
+    "00_randd.service",
+    "00_rtcd.service",
+    "00_zerod.service",
+    "00_logging_ramfs.service",
+]
diff --git a/init.d/00_zerod.service b/init.d/00_zerod.service
index 576b095fd5..25673b89e6 100644
--- a/init.d/00_zerod.service
+++ b/init.d/00_zerod.service
@@ -1,12 +1,7 @@
-{
-    "unit": {
-        "description": "/dev/zero",
-        "default_dependencies": false
-    },
-    "service": {
-        "cmd": "zerod",
-        "type": {
-            "scheme": "zero"
-        }
-    }
-}
+[unit]
+description = "/dev/zero"
+default_dependencies = false
+
+[service]
+cmd = "zerod"
+type = { scheme = "zero" }
diff --git a/init.d/10_inputd.service b/init.d/10_inputd.service
index 96e7f1e0a6..ba291046ab 100644
--- a/init.d/10_inputd.service
+++ b/init.d/10_inputd.service
@@ -1,11 +1,6 @@
-{
-    "unit": {
-        "description": "VT input and graphics multiplexer"
-    },
-    "service": {
-        "cmd": "inputd",
-        "type": {
-            "scheme": "input"
-        }
-    }
-}
+[unit]
+description = "VT input and graphics multiplexer"
+
+[service]
+cmd = "inputd"
+type = { scheme = "input" }
diff --git a/init.d/10_lived.service b/init.d/10_lived.service
index baec5da7c0..7745f4b761 100644
--- a/init.d/10_lived.service
+++ b/init.d/10_lived.service
@@ -1,10 +1,7 @@
-{
-    "_comment": "Needs to start before drivers to ensure it gets priority when redoxfs searches for disks",
-    "unit": {
-        "description": "Live disk"
-    },
-    "service": {
-        "cmd": "lived",
-        "type": "notify"
-    }
-}
+# Needs to start before drivers to ensure it gets priority when redoxfs searches for disks
+[unit]
+description = "Live disk"
+
+[service]
+cmd = "lived"
+type = "notify"
diff --git a/init.d/20_fbbootlogd.service b/init.d/20_fbbootlogd.service
index 72d90b9abb..5a8bf3c820 100644
--- a/init.d/20_fbbootlogd.service
+++ b/init.d/20_fbbootlogd.service
@@ -1,12 +1,7 @@
-{
-    "unit": {
-        "description": "Graphical bootlog",
-        "requires_weak": ["10_inputd.service", "20_vesad.service"]
-    },
-    "service": {
-        "cmd": "fbbootlogd",
-        "type": {
-            "scheme": "fbbootlog"
-        }
-    }
-}
+[unit]
+description = "Graphical bootlog"
+requires_weak = ["10_inputd.service", "20_vesad.service"]
+
+[service]
+cmd = "fbbootlogd"
+type = { scheme = "fbbootlog" }
diff --git a/init.d/20_fbcond.service b/init.d/20_fbcond.service
index f11d4d5aa8..8db3dfdbeb 100644
--- a/init.d/20_fbcond.service
+++ b/init.d/20_fbcond.service
@@ -1,13 +1,8 @@
-{
-    "unit": {
-        "description": "Framebuffer text console",
-        "requires_weak": ["10_inputd.service", "20_vesad.service"]
-    },
-    "service": {
-        "cmd": "fbcond",
-        "args": ["2"],
-        "type": {
-            "scheme": "fbcon"
-        }
-    }
-}
+[unit]
+description = "Framebuffer text console"
+requires_weak = ["10_inputd.service", "20_vesad.service"]
+
+[service]
+cmd = "fbcond"
+args = ["2"]
+type = { scheme = "fbcon" }
diff --git a/init.d/20_graphics.target b/init.d/20_graphics.target
index f8230dfe5d..f4aa91fcc6 100644
--- a/init.d/20_graphics.target
+++ b/init.d/20_graphics.target
@@ -1,11 +1,8 @@
-{
-    "unit": {
-        "description": "Graphics subsystem",
-        "requires_weak": [
-            "10_inputd.service",
-            "20_vesad.service",
-            "20_fbbootlogd.service",
-            "20_fbcond.service"
-        ]
-    }
-}
+[unit]
+description = "Graphics subsystem"
+requires_weak = [
+    "10_inputd.service",
+    "20_vesad.service",
+    "20_fbbootlogd.service",
+    "20_fbcond.service",
+]
diff --git a/init.d/20_vesad.service b/init.d/20_vesad.service
index 5feea711ec..70fbfb35f1 100644
--- a/init.d/20_vesad.service
+++ b/init.d/20_vesad.service
@@ -1,19 +1,14 @@
-{
-    "unit": {
-        "description": "Bootloader framebuffer handler",
-        "requires_weak": [
-            "10_inputd.service"
-        ]
-    },
-    "service": {
-        "cmd": "vesad",
-        "inherit_envs": [
-            "FRAMEBUFFER_ADDR",
-            "FRAMEBUFFER_VIRT",
-            "FRAMEBUFFER_WIDTH",
-            "FRAMEBUFFER_HEIGHT",
-            "FRAMEBUFFER_STRIDE"
-        ],
-        "type": "notify"
-    }
-}
+[unit]
+description = "Bootloader framebuffer handler"
+requires_weak = ["10_inputd.service"]
+
+[service]
+cmd = "vesad"
+inherit_envs = [
+    "FRAMEBUFFER_ADDR",
+    "FRAMEBUFFER_VIRT",
+    "FRAMEBUFFER_WIDTH",
+    "FRAMEBUFFER_HEIGHT",
+    "FRAMEBUFFER_STRIDE",
+]
+type = "notify"
diff --git a/init.d/90_exit_initfs.switchroot b/init.d/90_exit_initfs.switchroot
index 054b414d60..f91243b3c5 100644
--- a/init.d/90_exit_initfs.switchroot
+++ b/init.d/90_exit_initfs.switchroot
@@ -1,9 +1,6 @@
-{
-    "unit": {
-        "requires_weak": ["50_rootfs"]
-    },
-    "switchroot": {
-        "prefix": "/usr",
-        "etcdir": "/etc"
-    }
-}
+[unit]
+requires_weak = ["50_rootfs"]
+
+[switchroot]
+prefix = "/usr"
+etcdir = "/etc"
diff --git a/init/Cargo.toml b/init/Cargo.toml
index 5320f3807b..dcd57db3bd 100644
--- a/init/Cargo.toml
+++ b/init/Cargo.toml
@@ -8,6 +8,7 @@ license = "MIT"
 libredox.workspace = true
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
+toml = "1"
 
 config = { path = "../config" }
 daemon = { path = "../daemon" }
diff --git a/init/src/unit.rs b/init/src/unit.rs
index a03a66bc40..42fac48070 100644
--- a/init/src/unit.rs
+++ b/init/src/unit.rs
@@ -149,7 +149,8 @@ impl Unit {
                 )
             }
             Some("service") => {
-                let service: SerializedService = serde_json::from_str(&config)?;
+                let service: SerializedService = toml::from_str(&config)
+                    .map_err(|err| io::Error::new(io::ErrorKind::InvalidData, err))?;
                 (
                     service.unit,
                     UnitKind::Service {
@@ -159,11 +160,13 @@ impl Unit {
                 )
             }
             Some("target") => {
-                let target: SerializedTarget = serde_json::from_str(&config)?;
+                let target: SerializedTarget = toml::from_str(&config)
+                    .map_err(|err| io::Error::new(io::ErrorKind::InvalidData, err))?;
                 (target.unit, UnitKind::Target {}, vec![])
             }
             Some("switchroot") => {
-                let switchroot: SerializedSwitchRoot = serde_json::from_str(&config)?;
+                let switchroot: SerializedSwitchRoot = toml::from_str(&config)
+                    .map_err(|err| io::Error::new(io::ErrorKind::InvalidData, err))?;
                 (
                     switchroot.unit,
                     UnitKind::SwitchRoot {