From 025086acd10d533e9d6e12c96e991aba7e14859e Mon Sep 17 00:00:00 2001 From: bjorn3 <17426603+bjorn3@users.noreply.github.com> Date: Mon, 23 Dec 2024 18:10:32 +0100 Subject: [PATCH] virtio-gpud: Add offset method to XferToHost2d This will hopefully avoid confusion if someone in the future changes the XferToHost2d in flush to pass a smaller GpuRect. Without adjusting offset this would cause glitches. --- graphics/virtio-gpud/src/main.rs | 4 ++-- graphics/virtio-gpud/src/scheme.rs | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/graphics/virtio-gpud/src/main.rs b/graphics/virtio-gpud/src/main.rs index dcb33958f1..66f41b64dd 100644 --- a/graphics/virtio-gpud/src/main.rs +++ b/graphics/virtio-gpud/src/main.rs @@ -392,7 +392,7 @@ pub struct XferToHost2d { } impl XferToHost2d { - pub fn new(resource_id: ResourceId, rect: GpuRect) -> Self { + pub fn new(resource_id: ResourceId, rect: GpuRect, offset: u64) -> Self { Self { header: ControlHeader { ty: VolatileCell::new(CommandTy::TransferToHost2d), @@ -400,8 +400,8 @@ impl XferToHost2d { }, rect, + offset, resource_id, - offset: 0, padding: 0, } } diff --git a/graphics/virtio-gpud/src/scheme.rs b/graphics/virtio-gpud/src/scheme.rs index 7654291251..a874d782cd 100644 --- a/graphics/virtio-gpud/src/scheme.rs +++ b/graphics/virtio-gpud/src/scheme.rs @@ -193,6 +193,7 @@ impl<'a> Display<'a> { width: self.width, height: self.height, }, + 0, ))?; let header = self.send_request(req).await?; assert_eq!(header.ty.get(), CommandTy::RespOkNodata);